autogenerate integrations.json #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Integrations folder
…ure for overload resolution
palazzem
approved these changes
Dec 12, 2018
bmermet
approved these changes
Dec 13, 2018
|
|
||
| // find all methods in Datadog.Trace.ClrProfiler.Managed.dll with [InterceptMethod] | ||
| // and create objects that will generate correct JSON schema | ||
| var integrations = from wrapperType in integrationsAssembly.GetTypes() |
There was a problem hiding this comment.
This is the longest LINQ query I've seen 😄
| var genericArguments = method.GetGenericArguments(); | ||
|
|
||
| var newSignatureBytes = new byte[signatureBytes.Length + 1]; | ||
| newSignatureBytes[0] = (byte)(signatureBytes[0] | 0x10); |
There was a problem hiding this comment.
Nit: would be nice to name 0x10 IMAGE_CEE_CS_CALLCONV_GENERIC or something similar for code readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tool that can generate the
integrations.jsonfile from declaration in code, reducing manual work when adding new integrations and reducing the chance of errors, since it can automatically determine many values, such as the wrapper method's signature blob.Usage:
[InterceptMethod]attributeFor example, to intercept method
System.Web.Mvc.Async.IAsyncActionInvoker.BeginInvokeAction()inSystem.Web.Mvc.dll:This PR also renames some integrations and move them to the
Integrationsfolder for consistency:PipelinetoElasticsearchNetIntegrationRedisNativeClienttoServiceStachRedisIntegrationFor now, we will run this tool manually and check the results before committing changes to
integrations.json. Later we can run it as part of the build process.