ADO.NET integration #248
Merged
ADO.NET integration #248
+337
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
added
type:new-feature
area:automatic-instrumentation
lucaspimentel
added
the
status:work-in-progress
lucaspimentel
force-pushed
the
lpimentel/adonet-integration
branch
from
a4127e8 to
b382e01
Compare
lucaspimentel
removed
the
status:work-in-progress
# Conflicts: # integrations.json
bmermet
reviewed
Jan 16, 2019
| @@ -30,8 +30,8 @@ public void SubmitsTraces() | |||
| Assert.True(spans.Count > 0, "expected at least one span"); | |||
| foreach (var span in spans) | |||
| { | |||
| Assert.Equal(SqlServerIntegration.OperationName, span.Name); | |||
| Assert.Equal($"Samples.SqlServer-{SqlServerIntegration.ServiceName}", span.Service); | |||
| Assert.Equal("sql-server.query", span.Name); | |||
There was a problem hiding this comment.
Why do we not also have integration tests for postgres?
There was a problem hiding this comment.
The short answer is "time." Postgres support is time-sensitive. I tested Postgres manually and the SQL Server tests cover ADO.NET as well. I'm adding more automated integration tests for different ADO.NET providers in a separate PR.
bmermet
reviewed
Jan 16, 2019
src/Datadog.Trace.ClrProfiler.Managed/Integrations/AdoNetIntegration.cs
Outdated
Show resolved
Hide resolved
bmermet
reviewed
Jan 16, 2019
bmermet
reviewed
Jan 16, 2019
bmermet
reviewed
Jan 16, 2019
|
@lucaspimentel Could you please explain how are you getting this signature for wrapper type? |
|
@hemant-learningforever: The work on this PR is finished and merged. Please ask questions by creating a new issue. EDIT: never mind, I just saw the issue you already created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new integration that should cover all ADO.NET providers.
Tested with:
System.Data.SqlClient(replaces current integration)NpgsqlOther ADO.NET providers (not tested yet):
System.Data.SqlServerCe