[Crashtracking] Zero the stackframe upon creation #6346

kevingosse · 2024-11-25T13:13:23Z

Summary of changes

Zero the stackframes on Linux on creation.

Reason for change

Because they were not zero'd, we ended up with garbage in the pdb info fields.

Implementation details

{}

andrewlock

datadog-ddstaging · 2024-11-25T13:45:24Z

Datadog Report

Branch report: kevin/pdb_info
Commit report: 42917c3
Test service: dd-trace-dotnet

✅ 0 Failed, 451418 Passed, 3200 Skipped, 21h 33m 38.01s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

CheckGitMetataFromDdTags - Datadog.Profiler.IntegrationTests.DebugInfo.GitMetadataTest

andrewlock · 2024-11-25T13:50:04Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6346) - mean (73ms)  : 63, 82
     .   : milestone, 73,
    master - mean (71ms)  : 65, 78
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6346) - mean (994ms)  : 957, 1031
     .   : milestone, 994,
    master - mean (981ms)  : 960, 1003
     .   : milestone, 981,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6346) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6346) - mean (724ms)  : 604, 843
     .   : milestone, 724,
    master - mean (683ms)  : 665, 702
     .   : milestone, 683,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6346) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6346) - mean (672ms)  : 529, 815
     .   : milestone, 672,
    master - mean (638ms)  : 623, 653
     .   : milestone, 638,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6346) - mean (192ms)  : 185, 198
     .   : milestone, 192,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6346) - mean (1,097ms)  : 1064, 1129
     .   : milestone, 1097,
    master - mean (1,094ms)  : 1072, 1115
     .   : milestone, 1094,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6346) - mean (276ms)  : 273, 279
     .   : milestone, 276,
    master - mean (276ms)  : 272, 279
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6346) - mean (881ms)  : 844, 917
     .   : milestone, 881,
    master - mean (875ms)  : 850, 900
     .   : milestone, 875,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6346) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6346) - mean (853ms)  : 820, 885
     .   : milestone, 853,
    master - mean (854ms)  : 825, 884
     .   : milestone, 854,

andrewlock · 2024-11-25T16:45:04Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6346) (11.245M)   : 0, 11245277
    master (11.216M)   : 0, 11215877
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6346) (7.372M)   : 0, 7372263
    master (7.356M)   : 0, 7355647
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.653M)   : 0, 7652612

    section Manual
    master (11.177M)   : 0, 11177132

    section Manual + Automatic
    This PR (6346) (6.757M)   : 0, 6756796
    master (6.722M)   : 0, 6722247

    section DD_TRACE_ENABLED=0
    master (10.246M)   : 0, 10246375

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6346) (9.508M)   : 0, 9508191
    master (9.495M)   : 0, 9495372
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6346) (6.311M)   : 0, 6311142
    master (6.445M)   : 0, 6445315

    section Trace stats
    master (6.617M)   : 0, 6617151

    section Manual
    master (9.564M)   : 0, 9564169

    section Manual + Automatic
    This PR (6346) (5.862M)   : 0, 5862214
    master (5.943M)   : 0, 5943103

    section DD_TRACE_ENABLED=0
    master (8.993M)   : 0, 8992941

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6346) (9.146M)   : 0, 9145576
    master (8.980M)   : 0, 8980408
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6346) (6.081M)   : 0, 6081458
    master (5.865M)   : 0, 5865070
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.446M)   : 0, 6446474

    section Manual
    master (9.151M)   : 0, 9151083

    section Manual + Automatic
    This PR (6346) (5.613M)   : 0, 5613194
    master (5.595M)   : 0, 5594798

    section DD_TRACE_ENABLED=0
    master (8.375M)   : 0, 8375216

andrewlock · 2024-11-25T20:35:59Z

Benchmarks Report for tracer 🐌

Benchmarks for #6346 compared to master:

1 benchmarks are faster, with geometric mean 1.155
2 benchmarks are slower, with geometric mean 1.184
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.96μs	44.8ns	294ns	0.0185	0.00739	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	56.8ns	368ns	0.0151	0.00502	0	5.8 KB
master	`StartStopWithChild`	net472	16.1μs	45.8ns	171ns	1.05	0.325	0.0974	6.21 KB
#6346	`StartStopWithChild`	net6.0	7.84μs	45.3ns	363ns	0.0157	0.00783	0	5.61 KB
#6346	`StartStopWithChild`	netcoreapp3.1	9.95μs	56.2ns	393ns	0.019	0.00951	0	5.8 KB
#6346	`StartStopWithChild`	net472	16.2μs	71.7ns	278ns	1.04	0.298	0.102	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	480μs	340ns	1.32μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	641μs	293ns	1.06μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	851μs	557ns	2.16μs	0.425	3.3 KB
#6346	`WriteAndFlushEnrichedTraces`	net6.0	501μs	271ns	1.05μs	0	2.7 KB
#6346	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	649μs	480ns	1.86μs	0	2.7 KB
#6346	`WriteAndFlushEnrichedTraces`	net472	846μs	831ns	3.22μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	152μs	964ns	9.49μs	0.157	14.47 KB
master	`SendRequest`	netcoreapp3.1	167μs	961ns	7.98μs	0.159	17.27 KB
master	`SendRequest`	net472	0.000193ns	0.000145ns	0.000521ns	0	0 b
#6346	`SendRequest`	net6.0	154μs	920ns	9.11μs	0.146	14.47 KB
#6346	`SendRequest`	netcoreapp3.1	168μs	977ns	8.05μs	0.173	17.27 KB
#6346	`SendRequest`	net472	4.78E‑06ns	4.78E‑06ns	1.72E‑05ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.54 KB	41.77 KB	226 B	0.54%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	570μs	2.95μs	14.2μs	0.558	0	0	41.54 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	664μs	3.35μs	16.7μs	0.347	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	net472	859μs	2.67μs	9.63μs	8.13	2.57	0.428	53.28 KB
#6346	`WriteAndFlushEnrichedTraces`	net6.0	584μs	3.22μs	20.6μs	0.576	0	0	41.77 KB
#6346	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	685μs	3.38μs	13.9μs	0.349	0	0	41.7 KB
#6346	`WriteAndFlushEnrichedTraces`	net472	847μs	2.65μs	10.3μs	8.42	2.66	0.443	53.33 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.25μs	0.559ns	2.01ns	0.0145	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.64ns	6.15ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	2.22ns	8.61ns	0.156	0.00104	987 B
#6346	`ExecuteNonQuery`	net6.0	1.3μs	1.18ns	4.58ns	0.0142	0	1.02 KB
#6346	`ExecuteNonQuery`	netcoreapp3.1	1.7μs	2.17ns	8.4ns	0.0135	0	1.02 KB
#6346	`ExecuteNonQuery`	net472	2.04μs	1.21ns	4.37ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.11μs	0.621ns	2.32ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.651ns	2.44ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.6μs	1.5ns	5.4ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.29μs	0.867ns	3.25ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	0.607ns	2.27ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.63μs	2.03ns	7.87ns	0.167	1.05 KB
#6346	`CallElasticsearch`	net6.0	1.09μs	0.291ns	1.09ns	0.0138	976 B
#6346	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.952ns	3.69ns	0.0137	976 B
#6346	`CallElasticsearch`	net472	2.69μs	1.42ns	5.5ns	0.158	995 B
#6346	`CallElasticsearchAsync`	net6.0	1.35μs	0.544ns	2.03ns	0.0135	952 B
#6346	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	0.952ns	3.56ns	0.0138	1.02 KB
#6346	`CallElasticsearchAsync`	net472	2.6μs	1.26ns	4.71ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6346

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.150	1,242.76	1,428.71

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	0.704ns	2.63ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.701ns	2.62ns	0.0133	952 B
master	`ExecuteAsync`	net472	1.83μs	1.2ns	4.5ns	0.145	915 B
#6346	`ExecuteAsync`	net6.0	1.43μs	0.9ns	3.37ns	0.0129	952 B
#6346	`ExecuteAsync`	netcoreapp3.1	1.7μs	0.644ns	2.5ns	0.0125	952 B
#6346	`ExecuteAsync`	net472	1.79μs	0.603ns	2.34ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.31μs	1.78ns	6.88ns	0.0325	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.37μs	2.88ns	11.1ns	0.0376	2.85 KB
master	`SendAsync`	net472	7.26μs	2.23ns	8.35ns	0.495	3.12 KB
#6346	`SendAsync`	net6.0	4.19μs	2.69ns	10.1ns	0.0316	2.31 KB
#6346	`SendAsync`	netcoreapp3.1	5.27μs	1.67ns	6.45ns	0.0395	2.85 KB
#6346	`SendAsync`	net472	7.38μs	1.72ns	6.65ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.58μs	0.448ns	1.62ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.32μs	1.64ns	6.13ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.55μs	1.09ns	4.22ns	0.249	1.57 KB
#6346	`EnrichedLog`	net6.0	1.46μs	0.477ns	1.85ns	0.0233	1.64 KB
#6346	`EnrichedLog`	netcoreapp3.1	2.22μs	1.29ns	4.65ns	0.0221	1.64 KB
#6346	`EnrichedLog`	net472	2.65μs	1.09ns	4.2ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	179ns	693ns	0.0594	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	137ns	514ns	0.0619	0	4.28 KB
master	`EnrichedLog`	net472	153μs	83.3ns	300ns	0.684	0.228	4.46 KB
#6346	`EnrichedLog`	net6.0	119μs	164ns	633ns	0.0595	0	4.28 KB
#6346	`EnrichedLog`	netcoreapp3.1	124μs	161ns	622ns	0.0625	0	4.28 KB
#6346	`EnrichedLog`	net472	151μs	195ns	757ns	0.681	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.06μs	1.9ns	7.38ns	0.032	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.27μs	3.82ns	14.8ns	0.0302	2.2 KB
master	`EnrichedLog`	net472	4.97μs	1.92ns	7.43ns	0.319	2.02 KB
#6346	`EnrichedLog`	net6.0	3.19μs	16.6ns	77.9ns	0.0308	2.2 KB
#6346	`EnrichedLog`	netcoreapp3.1	4.19μs	1.17ns	4.38ns	0.0298	2.2 KB
#6346	`EnrichedLog`	net472	4.85μs	1.37ns	5.3ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.36μs	0.579ns	2.24ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.71μs	0.73ns	2.73ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.07μs	0.996ns	3.86ns	0.183	1.16 KB
#6346	`SendReceive`	net6.0	1.32μs	0.52ns	2.02ns	0.0159	1.14 KB
#6346	`SendReceive`	netcoreapp3.1	1.65μs	0.907ns	3.51ns	0.0158	1.14 KB
#6346	`SendReceive`	net472	2.04μs	0.943ns	3.65ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.68μs	0.706ns	2.64ns	0.0227	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.91μs	2.33ns	8.72ns	0.0214	1.65 KB
master	`EnrichedLog`	net472	4.51μs	3.53ns	13.7ns	0.323	2.04 KB
#6346	`EnrichedLog`	net6.0	2.73μs	1.29ns	4.81ns	0.0219	1.6 KB
#6346	`EnrichedLog`	netcoreapp3.1	3.94μs	1.21ns	4.7ns	0.0216	1.65 KB
#6346	`EnrichedLog`	net472	4.4μs	2.66ns	10.3ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6346

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.219	479.11	584.11

Faster 🎉 in #6346

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.155	765.13	662.66

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	397ns	0.806ns	3.12ns	0.00815	576 B
master	`StartFinishSpan`	netcoreapp3.1	614ns	0.584ns	2.26ns	0.008	576 B
master	`StartFinishSpan`	net472	667ns	1.37ns	5.29ns	0.0917	578 B
master	`StartFinishScope`	net6.0	479ns	1.05ns	4.07ns	0.00983	696 B
master	`StartFinishScope`	netcoreapp3.1	765ns	1ns	3.88ns	0.00953	696 B
master	`StartFinishScope`	net472	865ns	1.21ns	4.69ns	0.104	658 B
#6346	`StartFinishSpan`	net6.0	411ns	0.557ns	2.08ns	0.00816	576 B
#6346	`StartFinishSpan`	netcoreapp3.1	556ns	0.817ns	3.16ns	0.00778	576 B
#6346	`StartFinishSpan`	net472	626ns	1.1ns	4.27ns	0.0917	578 B
#6346	`StartFinishScope`	net6.0	584ns	0.579ns	2.09ns	0.00977	696 B
#6346	`StartFinishScope`	netcoreapp3.1	663ns	0.925ns	3.58ns	0.00934	696 B
#6346	`StartFinishScope`	net472	887ns	2.28ns	8.84ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	657ns	1.1ns	4.27ns	0.00983	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	979ns	1.5ns	5.81ns	0.00916	696 B
master	`RunOnMethodBegin`	net472	1.09μs	2.55ns	9.89ns	0.104	658 B
#6346	`RunOnMethodBegin`	net6.0	645ns	1.22ns	4.56ns	0.00981	696 B
#6346	`RunOnMethodBegin`	netcoreapp3.1	898ns	0.855ns	3.2ns	0.00929	696 B
#6346	`RunOnMethodBegin`	net472	1.12μs	2.11ns	8.18ns	0.104	658 B

kevingosse · 2024-11-28T10:26:47Z

Merge activity

Nov 28, 5:26 AM EST: A user merged this pull request with Graphite.

## Summary of changes Zero the stackframes on Linux on creation. ## Reason for change Because they were not zero'd, we ended up with garbage in the pdb info fields. ## Implementation details `{}`

Zero the stackframe upon creation

42917c3

kevingosse requested a review from a team as a code owner November 25, 2024 13:13

github-actions bot added the area:profiler Issues related to the continous-profiler label Nov 25, 2024

andrewlock approved these changes Nov 25, 2024

View reviewed changes

gleocadie approved these changes Nov 26, 2024

View reviewed changes

kevingosse merged commit d727479 into master Nov 28, 2024
84 of 85 checks passed

kevingosse deleted the kevin/pdb_info branch November 28, 2024 10:26

github-actions bot added this to the vNext-v3 milestone Nov 28, 2024

andrewlock added identified-by:crashtracking area:crashtracking and removed area:profiler Issues related to the continous-profiler labels Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Crashtracking] Zero the stackframe upon creation #6346

[Crashtracking] Zero the stackframe upon creation #6346

kevingosse commented Nov 25, 2024

andrewlock left a comment

datadog-ddstaging bot commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024

andrewlock commented Nov 25, 2024

andrewlock commented Nov 25, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #6346

Raw results

Raw results

Raw results

Slower ⚠️ in #6346

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6346

Faster 🎉 in #6346

Raw results

Raw results

kevingosse commented Nov 28, 2024

[Crashtracking] Zero the stackframe upon creation #6346

[Crashtracking] Zero the stackframe upon creation #6346

Conversation

kevingosse commented Nov 25, 2024

Summary of changes

Reason for change

Implementation details

andrewlock left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Nov 25, 2024 • edited Loading

Datadog Report

New Flaky Tests (1)

andrewlock commented Nov 25, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 25, 2024

Throughput/Crank Report ⚡

andrewlock commented Nov 25, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6346

Raw results

Raw results

Raw results

Slower ⚠️ in #6346

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6346

Faster 🎉 in #6346

Raw results

Raw results

kevingosse commented Nov 28, 2024

Merge activity

datadog-ddstaging bot commented Nov 25, 2024 •

edited

Loading