[Profiler] Fix UBsan Job #6380

gleocadie · 2024-11-30T15:02:07Z

Summary of changes

Fix the UBSAN job.

Reason for change

A recent unit test was added. This test builds events by writing the field in raw memory (like the CLR does). But the alignment is not taken care of (like the CLR) and UBSAN shouts about.

Implementation details

Since it's a test, we just disable UBSAN on the function (in the test) that creates the event.

datadog-ddstaging · 2024-11-30T15:22:48Z

Datadog Report

Branch report: gleocadie/fix-ubsan-error
Commit report: 94448f2
Test service: dd-trace-dotnet

✅ 0 Failed, 453087 Passed, 3201 Skipped, 20h 57m 7.73s Total Time
⌛ 2 Performance Regressions

⌛ Performance Regressions vs Default Branch (2)

CallTarget+Inlining+NGEN - Samples.HttpMessageHandler.windows.netcoreapp31.json.scenarios 905.21ms (+33.99ms, +4%) - Details
Baseline - Samples.HttpMessageHandler.windows.net60.json.scenarios 329.11ms (+63.23ms, +24%) - Details

andrewlock · 2024-11-30T15:49:41Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6380) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6380) - mean (983ms)  : 954, 1012
     .   : milestone, 983,
    master - mean (981ms)  : 959, 1003
     .   : milestone, 981,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6380) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6380) - mean (681ms)  : 664, 698
     .   : milestone, 681,
    master - mean (681ms)  : 663, 700
     .   : milestone, 681,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6380) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6380) - mean (631ms)  : 617, 645
     .   : milestone, 631,
    master - mean (633ms)  : 620, 646
     .   : milestone, 633,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6380) - mean (190ms)  : 184, 197
     .   : milestone, 190,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6380) - mean (1,093ms)  : 1067, 1118
     .   : milestone, 1093,
    master - mean (1,095ms)  : 1066, 1123
     .   : milestone, 1095,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6380) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6380) - mean (905ms)  : 808, 1003
     .   : milestone, 905,
    master - mean (867ms)  : 842, 893
     .   : milestone, 867,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6380) - mean (329ms)  : 323, 335
     .   : milestone, 329,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6380) - mean (862ms)  : 826, 898
     .   : milestone, 862,
    master - mean (853ms)  : 822, 884
     .   : milestone, 853,

andrewlock · 2024-11-30T16:13:15Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6380) (11.287M)   : 0, 11286531
    master (11.142M)   : 0, 11142160
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6380) (7.344M)   : 0, 7344454
    master (7.363M)   : 0, 7363424
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.607M)   : 0, 7607008

    section Manual
    master (11.275M)   : 0, 11275455

    section Manual + Automatic
    This PR (6380) (6.719M)   : 0, 6719053
    master (6.792M)   : 0, 6792352

    section DD_TRACE_ENABLED=0
    master (10.439M)   : 0, 10439037

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6380) (9.758M)   : 0, 9757731
    master (9.654M)   : 0, 9653591
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6380) (6.116M)   : 0, 6116050
    master (6.390M)   : 0, 6389835

    section Trace stats
    master (6.750M)   : 0, 6750226

    section Manual
    master (9.569M)   : 0, 9568710

    section Manual + Automatic
    This PR (6380) (5.960M)   : 0, 5960149
    master (6.103M)   : 0, 6103364

    section DD_TRACE_ENABLED=0
    master (8.654M)   : 0, 8654106

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6380) (9.910M)   : 0, 9910221
    master (10.012M)   : 0, 10011511
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6380) (6.276M)   : 0, 6275979
    master (6.299M)   : 0, 6298610
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.028M)   : 0, 7027938

    section Manual
    master (9.897M)   : 0, 9896735

    section Manual + Automatic
    This PR (6380) (5.782M)   : 0, 5782428
    master (5.876M)   : 0, 5876361

    section DD_TRACE_ENABLED=0
    master (9.276M)   : 0, 9275838

chrisnas

LGTM

andrewlock · 2024-12-02T17:05:27Z

Benchmarks Report for tracer 🐌

Benchmarks for #6380 compared to master:

2 benchmarks are slower, with geometric mean 1.133
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.91μs	44.6ns	309ns	0.015	0.00751	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	44.6ns	194ns	0.0193	0.00482	0	5.81 KB
master	`StartStopWithChild`	net472	16.3μs	59.9ns	232ns	1.05	0.306	0.105	6.2 KB
#6380	`StartStopWithChild`	net6.0	8.04μs	43.1ns	228ns	0.0153	0.00763	0	5.62 KB
#6380	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.9ns	296ns	0.0193	0.00963	0	5.8 KB
#6380	`StartStopWithChild`	net472	16.2μs	36.8ns	142ns	1.05	0.315	0.0968	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	483μs	125ns	468ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	586ns	2.19μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	498ns	1.93μs	0.419	3.3 KB
#6380	`WriteAndFlushEnrichedTraces`	net6.0	528μs	824ns	3.19μs	0	2.7 KB
#6380	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	671μs	368ns	1.43μs	0	2.7 KB
#6380	`WriteAndFlushEnrichedTraces`	net472	841μs	497ns	1.92μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	148μs	849ns	6.52μs	0.142	14.47 KB
master	`SendRequest`	netcoreapp3.1	170μs	954ns	8.69μs	0.157	17.27 KB
master	`SendRequest`	net472	0.000269ns	0.000207ns	0.000748ns	0	0 b
#6380	`SendRequest`	net6.0	151μs	872ns	7.03μs	0.153	14.47 KB
#6380	`SendRequest`	netcoreapp3.1	166μs	922ns	5.97μs	0.157	17.27 KB
#6380	`SendRequest`	net472	0.000214ns	0.000214ns	0.000771ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	590μs	3.35μs	23μs	0.568	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	693μs	3.78μs	21.4μs	0.336	0	0	41.85 KB
master	`WriteAndFlushEnrichedTraces`	net472	863μs	4.43μs	22.2μs	8.5	2.55	0.425	53.35 KB
#6380	`WriteAndFlushEnrichedTraces`	net6.0	575μs	3.15μs	18.9μs	0.278	0	0	41.67 KB
#6380	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	3.32μs	14.8μs	0.332	0	0	41.75 KB
#6380	`WriteAndFlushEnrichedTraces`	net472	886μs	4.34μs	18.9μs	8.13	2.57	0.428	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	0.915ns	3.42ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.36ns	5.28ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	1.26ns	4.7ns	0.156	0.00105	987 B
#6380	`ExecuteNonQuery`	net6.0	1.28μs	0.768ns	2.97ns	0.0141	0	1.02 KB
#6380	`ExecuteNonQuery`	netcoreapp3.1	1.67μs	1.09ns	3.93ns	0.0137	0	1.02 KB
#6380	`ExecuteNonQuery`	net472	2.21μs	11.3ns	75.6ns	0.156	0.00108	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.861ns	3.33ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.876ns	3.39ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.59μs	7.43ns	28.8ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.445ns	1.72ns	0.0128	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.798ns	3.09ns	0.0136	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	0.884ns	3.19ns	0.166	1.05 KB
#6380	`CallElasticsearch`	net6.0	1.27μs	0.356ns	1.33ns	0.0133	976 B
#6380	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.653ns	2.44ns	0.0132	976 B
#6380	`CallElasticsearch`	net472	2.56μs	1.18ns	4.42ns	0.157	995 B
#6380	`CallElasticsearchAsync`	net6.0	1.4μs	0.546ns	2.04ns	0.0134	952 B
#6380	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	0.423ns	1.53ns	0.0133	1.02 KB
#6380	`CallElasticsearchAsync`	net472	2.59μs	1.43ns	5.36ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.32μs	0.442ns	1.65ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	4.13ns	15.5ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.77μs	0.709ns	2.75ns	0.145	915 B
#6380	`ExecuteAsync`	net6.0	1.34μs	1.11ns	4.14ns	0.0135	952 B
#6380	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.464ns	1.73ns	0.013	952 B
#6380	`ExecuteAsync`	net472	1.86μs	0.463ns	1.79ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.3μs	1.74ns	6.53ns	0.0324	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.32μs	2.56ns	9.57ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.38μs	1.92ns	7.43ns	0.493	3.12 KB
#6380	`SendAsync`	net6.0	4.26μs	1.35ns	4.88ns	0.032	2.31 KB
#6380	`SendAsync`	netcoreapp3.1	5.25μs	1.87ns	7.25ns	0.0369	2.85 KB
#6380	`SendAsync`	net472	7.24μs	1.08ns	3.74ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6380

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472	1.118	2,479.26	2,771.05

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.47μs	2.06ns	7.97ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.19μs	1.73ns	6.7ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.48μs	1.15ns	4.29ns	0.249	1.57 KB
#6380	`EnrichedLog`	net6.0	1.46μs	0.634ns	2.45ns	0.0233	1.64 KB
#6380	`EnrichedLog`	netcoreapp3.1	2.12μs	0.763ns	2.95ns	0.0214	1.64 KB
#6380	`EnrichedLog`	net472	2.77μs	1.02ns	3.81ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	172ns	620ns	0.0606	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	226ns	875ns	0	0	4.28 KB
master	`EnrichedLog`	net472	153μs	85.2ns	330ns	0.683	0.228	4.46 KB
#6380	`EnrichedLog`	net6.0	119μs	100ns	362ns	0	0	4.28 KB
#6380	`EnrichedLog`	netcoreapp3.1	124μs	116ns	450ns	0	0	4.28 KB
#6380	`EnrichedLog`	net472	152μs	171ns	660ns	0.681	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.09μs	0.872ns	3.38ns	0.031	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.21μs	3.09ns	12ns	0.0293	2.2 KB
master	`EnrichedLog`	net472	4.87μs	1.41ns	5.28ns	0.319	2.02 KB
#6380	`EnrichedLog`	net6.0	3.06μs	3.3ns	12.8ns	0.0303	2.2 KB
#6380	`EnrichedLog`	netcoreapp3.1	4.08μs	1.16ns	4.49ns	0.0285	2.2 KB
#6380	`EnrichedLog`	net472	4.75μs	1.57ns	6.07ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.33μs	0.963ns	3.73ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.73μs	0.295ns	1.1ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.09μs	1.09ns	4.24ns	0.184	1.16 KB
#6380	`SendReceive`	net6.0	1.37μs	0.617ns	2.39ns	0.0164	1.14 KB
#6380	`SendReceive`	netcoreapp3.1	1.82μs	0.885ns	3.43ns	0.0155	1.14 KB
#6380	`SendReceive`	net472	2.04μs	1.38ns	5.33ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	1.05ns	4.07ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.84μs	8.26ns	32ns	0.0227	1.65 KB
master	`EnrichedLog`	net472	4.39μs	3.6ns	13.9ns	0.322	2.04 KB
#6380	`EnrichedLog`	net6.0	2.84μs	0.618ns	2.31ns	0.0226	1.6 KB
#6380	`EnrichedLog`	netcoreapp3.1	4.01μs	1.72ns	6.68ns	0.022	1.65 KB
#6380	`EnrichedLog`	net472	4.39μs	1.78ns	6.67ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6380

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.149	396.12	455.16

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	396ns	0.253ns	0.979ns	0.00807	576 B
master	`StartFinishSpan`	netcoreapp3.1	636ns	0.527ns	2.04ns	0.00747	576 B
master	`StartFinishSpan`	net472	609ns	0.368ns	1.43ns	0.0918	578 B
master	`StartFinishScope`	net6.0	503ns	0.279ns	1.08ns	0.00961	696 B
master	`StartFinishScope`	netcoreapp3.1	768ns	0.609ns	2.36ns	0.00953	696 B
master	`StartFinishScope`	net472	831ns	1.18ns	4.59ns	0.104	658 B
#6380	`StartFinishSpan`	net6.0	455ns	0.254ns	0.984ns	0.00804	576 B
#6380	`StartFinishSpan`	netcoreapp3.1	613ns	0.766ns	2.87ns	0.00773	576 B
#6380	`StartFinishSpan`	net472	667ns	0.687ns	2.66ns	0.0916	578 B
#6380	`StartFinishScope`	net6.0	485ns	0.364ns	1.41ns	0.00973	696 B
#6380	`StartFinishScope`	netcoreapp3.1	750ns	0.477ns	1.72ns	0.0093	696 B
#6380	`StartFinishScope`	net472	905ns	0.558ns	2.09ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	641ns	0.381ns	1.47ns	0.00968	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	881ns	0.657ns	2.54ns	0.00925	696 B
master	`RunOnMethodBegin`	net472	1.07μs	0.673ns	2.61ns	0.104	658 B
#6380	`RunOnMethodBegin`	net6.0	688ns	0.667ns	2.58ns	0.01	696 B
#6380	`RunOnMethodBegin`	netcoreapp3.1	880ns	0.565ns	2.19ns	0.00931	696 B
#6380	`RunOnMethodBegin`	net472	1.12μs	0.381ns	1.47ns	0.104	658 B

link04

Ty!

## Summary of changes Fix the UBSAN job. ## Reason for change A recent unit test was added. This test builds events by writing the field in raw memory (like the CLR does). But the alignment is not taken care of (like the CLR) and UBSAN shouts about. ## Implementation details Since it's a test, we just disable UBSAN on the function (in the test) that creates the event.

github-actions bot added the area:profiler Issues related to the continous-profiler label Nov 30, 2024

gleocadie force-pushed the gleocadie/fix-ubsan-error branch from 10b4827 to cf4978e Compare December 2, 2024 15:17

gleocadie marked this pull request as ready for review December 2, 2024 15:31

gleocadie requested a review from a team as a code owner December 2, 2024 15:31

chrisnas approved these changes Dec 2, 2024

View reviewed changes

Fix UBsan Job

713700b

gleocadie force-pushed the gleocadie/fix-ubsan-error branch from cf4978e to 713700b Compare December 2, 2024 20:06

link04 approved these changes Dec 2, 2024

View reviewed changes

Fix clang-tidy job

94448f2

link04 merged commit b017748 into master Dec 3, 2024
84 of 86 checks passed

link04 deleted the gleocadie/fix-ubsan-error branch December 3, 2024 11:59

github-actions bot added this to the vNext-v3 milestone Dec 3, 2024

andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages and removed area:profiler Issues related to the continous-profiler labels Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Profiler] Fix UBsan Job #6380

[Profiler] Fix UBsan Job #6380

gleocadie commented Nov 30, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 30, 2024 •

edited

Loading

andrewlock commented Nov 30, 2024 •

edited

Loading

andrewlock commented Nov 30, 2024 •

edited

Loading

chrisnas left a comment

andrewlock commented Dec 2, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6380

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6380

Raw results

Raw results

link04 left a comment

[Profiler] Fix UBsan Job #6380

[Profiler] Fix UBsan Job #6380

Conversation

gleocadie commented Nov 30, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

datadog-ddstaging bot commented Nov 30, 2024 • edited Loading

Datadog Report

⌛ Performance Regressions vs Default Branch (2)

andrewlock commented Nov 30, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 30, 2024 • edited Loading

Throughput/Crank Report ⚡

chrisnas left a comment

Choose a reason for hiding this comment

andrewlock commented Dec 2, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6380

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6380

Raw results

Raw results

link04 left a comment

Choose a reason for hiding this comment

gleocadie commented Nov 30, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 30, 2024 •

edited

Loading

andrewlock commented Nov 30, 2024 •

edited

Loading

andrewlock commented Nov 30, 2024 •

edited

Loading

andrewlock commented Dec 2, 2024 •

edited

Loading