Dump process and children processes when a test hangups #6401

tonyredondo · 2024-12-05T11:11:37Z

Summary of changes

This PR adds the mechanism to create a memory dump not only on the process id but also the children processes ids of a samples app.

Reason for change

This is useful for a dotnet test scenario where the CLI spawn multiple processes (testhost, datacollectorhost)

Ticket: SDTEST-1309

datadog-ddstaging · 2024-12-05T11:56:04Z

Datadog Report

Branch report: tony/dump-children-ids
Commit report: 8ea942c
Test service: dd-trace-dotnet

✅ 0 Failed, 463489 Passed, 2870 Skipped, 20h 21m 21.36s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyResolveMscorlibResourcesInfiniteRecursionCrashSmokeTest - Last Failure
Expand for error
```
 Expected no errors in smoke test: [createdump] ptrace(ATTACH, 18769) FAILED Operation not permitted
 
 Expected: True
 Actual:   False
```

andrewlock · 2024-12-05T12:36:32Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6401) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6401) - mean (984ms)  : 960, 1008
     .   : milestone, 984,
    master - mean (981ms)  : 960, 1003
     .   : milestone, 981,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6401) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6401) - mean (680ms)  : 664, 697
     .   : milestone, 680,
    master - mean (679ms)  : 666, 692
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6401) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6401) - mean (631ms)  : 616, 646
     .   : milestone, 631,
    master - mean (634ms)  : 620, 649
     .   : milestone, 634,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6401) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6401) - mean (1,100ms)  : 1073, 1127
     .   : milestone, 1100,
    master - mean (1,093ms)  : 1065, 1121
     .   : milestone, 1093,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6401) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6401) - mean (871ms)  : 840, 902
     .   : milestone, 871,
    master - mean (870ms)  : 847, 893
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6401) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6401) - mean (849ms)  : 818, 880
     .   : milestone, 849,
    master - mean (850ms)  : 818, 882
     .   : milestone, 850,

andrewlock · 2024-12-05T23:05:09Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6401) (11.250M)   : 0, 11250268
    master (11.262M)   : 0, 11261987
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6401) (7.216M)   : 0, 7215626
    master (7.252M)   : 0, 7252121
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.492M)   : 0, 7491512

    section Manual
    master (11.082M)   : 0, 11081514

    section Manual + Automatic
    This PR (6401) (6.605M)   : 0, 6604893
    master (6.511M)   : 0, 6511339

    section DD_TRACE_ENABLED=0
    master (10.305M)   : 0, 10305041

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6401) (9.598M)   : 0, 9597831
    master (9.633M)   : 0, 9633274
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6401) (6.343M)   : 0, 6343379
    master (6.436M)   : 0, 6436394

    section Trace stats
    master (6.676M)   : 0, 6676124

    section Manual
    master (9.575M)   : 0, 9575331

    section Manual + Automatic
    This PR (6401) (5.951M)   : 0, 5951432
    master (5.718M)   : 0, 5718155

    section DD_TRACE_ENABLED=0
    master (8.573M)   : 0, 8572716

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6401) (9.473M)   : 0, 9472639
    master (9.876M)   : 0, 9876001
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6401) (6.164M)   : crit ,0, 6164420
    master (6.512M)   : 0, 6511943
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.089M)   : 0, 7089152

    section Manual
    master (10.204M)   : 0, 10203572

    section Manual + Automatic
    This PR (6401) (5.715M)   : crit ,0, 5714521
    master (6.050M)   : 0, 6050240

    section DD_TRACE_ENABLED=0
    master (9.471M)   : 0, 9471285

andrewlock · 2024-12-06T01:25:20Z

Benchmarks Report for tracer 🐌

Benchmarks for #6401 compared to master:

1 benchmarks are slower, with geometric mean 1.128
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.89μs	44.4ns	301ns	0.0124	0.00415	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	55ns	316ns	0.0146	0.00486	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	50.5ns	196ns	1.03	0.307	0.097	6.2 KB
#6401	`StartStopWithChild`	net6.0	8.21μs	46.1ns	303ns	0.0172	0.00858	0	5.61 KB
#6401	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.6ns	284ns	0.0257	0.0103	0	5.8 KB
#6401	`StartStopWithChild`	net472	16.3μs	54.2ns	210ns	1.03	0.292	0.0892	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	507μs	240ns	897ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	587ns	2.2μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	603ns	2.34μs	0.425	3.3 KB
#6401	`WriteAndFlushEnrichedTraces`	net6.0	471μs	251ns	973ns	0	2.7 KB
#6401	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	671μs	321ns	1.24μs	0	2.7 KB
#6401	`WriteAndFlushEnrichedTraces`	net472	865μs	506ns	1.96μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	147μs	926ns	9.16μs	0.147	14.47 KB
master	`SendRequest`	netcoreapp3.1	165μs	940ns	6.84μs	0.161	17.27 KB
master	`SendRequest`	net472	0.00054ns	0.000248ns	0.000929ns	0	0 b
#6401	`SendRequest`	net6.0	145μs	734ns	3.2μs	0.147	14.47 KB
#6401	`SendRequest`	netcoreapp3.1	161μs	897ns	6.15μs	0.167	17.27 KB
#6401	`SendRequest`	net472	0.00198ns	0.000637ns	0.00247ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6401

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.61 KB	41.92 KB	310 B	0.74%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	572μs	2.85μs	12.1μs	0.573	0	0	41.8 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	2.39μs	8.94μs	0.332	0	0	41.61 KB
master	`WriteAndFlushEnrichedTraces`	net472	837μs	3.61μs	13.5μs	8.39	2.52	0.419	53.28 KB
#6401	`WriteAndFlushEnrichedTraces`	net6.0	549μs	1.42μs	5.51μs	0.598	0	0	41.62 KB
#6401	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	2.32μs	9μs	0.327	0	0	41.92 KB
#6401	`WriteAndFlushEnrichedTraces`	net472	853μs	2.58μs	9.98μs	8.81	2.52	0.419	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	1.49ns	5.77ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.22ns	4.58ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.03μs	1.08ns	4.2ns	0.157	0.00102	987 B
#6401	`ExecuteNonQuery`	net6.0	1.36μs	0.595ns	2.23ns	0.0143	0	1.02 KB
#6401	`ExecuteNonQuery`	netcoreapp3.1	1.72μs	2.2ns	8.51ns	0.013	0	1.02 KB
#6401	`ExecuteNonQuery`	net472	2.09μs	1.6ns	6.21ns	0.157	0.00105	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.2μs	0.435ns	1.69ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.79ns	3.06ns	0.0134	976 B
master	`CallElasticsearch`	net472	2.57μs	2.05ns	7.66ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	0.556ns	2.15ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	1.19ns	4.63ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	0.971ns	3.63ns	0.167	1.05 KB
#6401	`CallElasticsearch`	net6.0	1.32μs	0.481ns	1.86ns	0.014	976 B
#6401	`CallElasticsearch`	netcoreapp3.1	1.59μs	1.06ns	3.96ns	0.0128	976 B
#6401	`CallElasticsearch`	net472	2.59μs	3.69ns	14.3ns	0.158	995 B
#6401	`CallElasticsearchAsync`	net6.0	1.38μs	0.56ns	2.1ns	0.0131	952 B
#6401	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.01ns	3.8ns	0.0135	1.02 KB
#6401	`CallElasticsearchAsync`	net472	2.7μs	1.93ns	7.48ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.761ns	2.95ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.936ns	3.62ns	0.0123	952 B
master	`ExecuteAsync`	net472	1.83μs	0.553ns	2.14ns	0.145	915 B
#6401	`ExecuteAsync`	net6.0	1.19μs	1.12ns	4.2ns	0.0132	952 B
#6401	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.422ns	1.58ns	0.0124	952 B
#6401	`ExecuteAsync`	net472	1.84μs	0.715ns	2.77ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.45μs	2.05ns	7.92ns	0.0318	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.25μs	1.28ns	4.8ns	0.0368	2.85 KB
master	`SendAsync`	net472	7.36μs	1.45ns	5.42ns	0.496	3.12 KB
#6401	`SendAsync`	net6.0	4.57μs	1.73ns	6.47ns	0.032	2.31 KB
#6401	`SendAsync`	netcoreapp3.1	5.46μs	3.4ns	13.2ns	0.038	2.85 KB
#6401	`SendAsync`	net472	7.41μs	1.9ns	7.13ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	0.734ns	2.75ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	0.725ns	2.71ns	0.022	1.64 KB
master	`EnrichedLog`	net472	2.66μs	1.17ns	4.39ns	0.249	1.57 KB
#6401	`EnrichedLog`	net6.0	1.49μs	1.18ns	4.55ns	0.0228	1.64 KB
#6401	`EnrichedLog`	netcoreapp3.1	2.17μs	3.46ns	13.4ns	0.0225	1.64 KB
#6401	`EnrichedLog`	net472	2.68μs	5.83ns	22.6ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	183ns	709ns	0.0608	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	125μs	75.6ns	283ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	97.3ns	364ns	0.684	0.228	4.46 KB
#6401	`EnrichedLog`	net6.0	118μs	245ns	949ns	0.0594	0	4.28 KB
#6401	`EnrichedLog`	netcoreapp3.1	124μs	160ns	618ns	0	0	4.28 KB
#6401	`EnrichedLog`	net472	152μs	67.4ns	252ns	0.686	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.08μs	1.16ns	4.5ns	0.0308	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.21μs	1.21ns	4.36ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	4.94μs	2.46ns	9.53ns	0.319	2.02 KB
#6401	`EnrichedLog`	net6.0	3μs	0.954ns	3.69ns	0.0302	2.2 KB
#6401	`EnrichedLog`	netcoreapp3.1	4.25μs	1.23ns	4.75ns	0.0297	2.2 KB
#6401	`EnrichedLog`	net472	4.83μs	1.38ns	5.34ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.3μs	0.649ns	2.51ns	0.0161	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.79μs	1.09ns	4.07ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.11μs	0.805ns	2.79ns	0.183	1.16 KB
#6401	`SendReceive`	net6.0	1.4μs	0.822ns	3.18ns	0.0161	1.14 KB
#6401	`SendReceive`	netcoreapp3.1	1.81μs	0.711ns	2.75ns	0.0154	1.14 KB
#6401	`SendReceive`	net472	2.18μs	0.958ns	3.58ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.8μs	0.721ns	2.7ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	2.46ns	9.51ns	0.0214	1.65 KB
master	`EnrichedLog`	net472	4.24μs	1.71ns	6.4ns	0.323	2.04 KB
#6401	`EnrichedLog`	net6.0	2.8μs	0.842ns	3.15ns	0.021	1.6 KB
#6401	`EnrichedLog`	netcoreapp3.1	4.05μs	2.19ns	8.5ns	0.0203	1.65 KB
#6401	`EnrichedLog`	net472	4.47μs	4.33ns	16.8ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6401

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.128	565.51	637.68

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	401ns	0.364ns	1.41ns	0.00807	576 B
master	`StartFinishSpan`	netcoreapp3.1	565ns	0.252ns	0.942ns	0.00766	576 B
master	`StartFinishSpan`	net472	651ns	0.474ns	1.83ns	0.0917	578 B
master	`StartFinishScope`	net6.0	502ns	0.321ns	1.24ns	0.00975	696 B
master	`StartFinishScope`	netcoreapp3.1	741ns	0.466ns	1.81ns	0.00927	696 B
master	`StartFinishScope`	net472	885ns	0.453ns	1.76ns	0.104	658 B
#6401	`StartFinishSpan`	net6.0	406ns	0.289ns	1.12ns	0.00813	576 B
#6401	`StartFinishSpan`	netcoreapp3.1	638ns	0.441ns	1.71ns	0.0077	576 B
#6401	`StartFinishSpan`	net472	648ns	0.326ns	1.26ns	0.0916	578 B
#6401	`StartFinishScope`	net6.0	497ns	0.32ns	1.2ns	0.00962	696 B
#6401	`StartFinishScope`	netcoreapp3.1	722ns	0.625ns	2.42ns	0.0096	696 B
#6401	`StartFinishScope`	net472	874ns	1.31ns	5.06ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	668ns	0.918ns	3.56ns	0.00967	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	934ns	1.5ns	5.59ns	0.00928	696 B
master	`RunOnMethodBegin`	net472	1.14μs	0.959ns	3.71ns	0.105	658 B
#6401	`RunOnMethodBegin`	net6.0	643ns	0.303ns	1.05ns	0.00982	696 B
#6401	`RunOnMethodBegin`	netcoreapp3.1	879ns	0.658ns	2.37ns	0.00936	696 B
#6401	`RunOnMethodBegin`	net472	1.13μs	0.796ns	3.08ns	0.104	658 B

andrewlock

LGTM (tested it works on Windows)

As discussed, pushed a small change to keep the default behaviour except in dotnet test

## Summary of changes This PR adds the mechanism to create a memory dump not only on the process id but also the children processes ids of a samples app. ## Reason for change This is useful for a `dotnet test` scenario where the CLI spawn multiple processes (testhost, datacollectorhost) Ticket: SDTEST-1309 --------- Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>

…in tests (#6520) ## Summary of changes Fix "dump child processes" not working ## Reason for change #6401 added the ability to say "dump the child processes too", except we didn't wire up the parameter. ## Implementation details Wire up the parameter

…in tests - part 2 :D (#6537) ## Summary of changes Fix "dump child processes" not working ## Reason for change #6401 added the ability to say "dump the child processes too", except we didn't wire up the parameter. #6520 tried to fix it, but was missing another call. ## Implementation details Wire up the parameter

github-actions bot added the area:tests unit tests, integration tests label Dec 5, 2024

tonyredondo added 2 commits December 9, 2024 13:01

Dump process and children processes when a test hangups

89fe93c

final check

eec5686

tonyredondo force-pushed the tony/dump-children-ids branch from 3f5bda8 to eec5686 Compare December 9, 2024 12:01

tonyredondo marked this pull request as ready for review December 9, 2024 16:23

tonyredondo requested a review from a team as a code owner December 9, 2024 16:23

andrewlock added 2 commits December 10, 2024 12:53

Make capturing the child dumps optional

7d256ea

Capture the child processes for dotnet test executions

8ea942c

andrewlock approved these changes Dec 10, 2024

View reviewed changes

tonyredondo merged commit a5d0a57 into master Dec 10, 2024
102 of 104 checks passed

tonyredondo deleted the tony/dump-children-ids branch December 10, 2024 21:52

github-actions bot added this to the vNext-v3 milestone Dec 10, 2024

andrewlock mentioned this pull request Jan 9, 2025

Actually include child processes when requested during a memory dump in tests #6520

Merged

tonyredondo mentioned this pull request Jan 13, 2025

Actually include child processes when requested during a memory dump in tests - part 2 :D #6537

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dump process and children processes when a test hangups #6401

Dump process and children processes when a test hangups #6401

tonyredondo commented Dec 5, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 5, 2024 •

edited

Loading

andrewlock commented Dec 5, 2024 •

edited

Loading

andrewlock commented Dec 5, 2024 •

edited

Loading

andrewlock commented Dec 6, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6401

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6401

Raw results

Raw results

andrewlock left a comment

Dump process and children processes when a test hangups #6401

Dump process and children processes when a test hangups #6401

Conversation

tonyredondo commented Dec 5, 2024 • edited Loading

Summary of changes

Reason for change

datadog-ddstaging bot commented Dec 5, 2024 • edited Loading

Datadog Report

New Flaky Tests (1)

andrewlock commented Dec 5, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 5, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Dec 6, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6401

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6401

Raw results

Raw results

andrewlock left a comment

Choose a reason for hiding this comment

tonyredondo commented Dec 5, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 5, 2024 •

edited

Loading

andrewlock commented Dec 5, 2024 •

edited

Loading

andrewlock commented Dec 5, 2024 •

edited

Loading

andrewlock commented Dec 6, 2024 •

edited

Loading