[Crashtracking] Display a nicer error message when the glibc version is too old #6402

kevingosse · 2024-12-05T12:55:14Z

Summary of changes

Change the error message when loading the profiler fails because of the glibc version.

Before:

Datadog - Some errors occurred while analyzing the crash:
- Unexpected exception: System.DllNotFoundException: Unable to load shared 
library 
'/opt/datadog-packages/datadog-apm-library-dotnet/3.6.1/linux-arm64/Datadog.Prof
iler.Native.so' or one of its dependencies. In order to help diagnose loading 
problems, consider using a tool like strace. If you're using glibc, consider 
setting the LD_DEBUG environment variable: 
/lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by 
/opt/datadog-packages/datadog-apm-library-dotnet/3.6.1/linux-arm64/Datadog.Profi
ler.Native.so)

   at 
System.Runtime.InteropServices.NativeLibrary.LoadLibErrorTracker.Throw(String) +
0x50
   at System.Runtime.InteropServices.NativeLibrary.LoadFromPath(String, Boolean)
+ 0x4c
   at Datadog.Trace.Tools.dd_dotnet.CreatedumpCommand.GenerateCrashReport(Int32,
Nullable`1, Nullable`1) + 0x110
   at Datadog.Trace.Tools.dd_dotnet.CreatedumpCommand.Execute(InvocationContext 
context) + 0x94

After:

Datadog - Some errors occurred while analyzing the crash:
- The GLIBC version is too old

Reason for change

The error is "expected" in some environment, so it's better to make the message less scary.

andrewlock

I wonder if it's worth extracting the GLIBC_2.28 part to display to the user 🤔 Probably not worth the hassle I guess, especially as this only happens during a crash anyway

datadog-ddstaging · 2024-12-05T13:54:29Z

Datadog Report

Branch report: kevin/dd-dotnet-glibc
Commit report: e655986
Test service: dd-trace-dotnet

✅ 0 Failed, 448367 Passed, 2726 Skipped, 19h 35m 47.07s Total Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

Baseline_contention - scenarios 1.02s (+9.68ms, +1%) - Details

kevingosse · 2024-12-05T14:00:33Z

I wonder if it's worth extracting the GLIBC_2.28 part to display to the user 🤔 Probably not worth the hassle I guess, especially as this only happens during a crash anyway

Yeah, I don't think the users actually care about this (at least not until crashtracking becomes a public feature), and for us the information is mostly useless (it would be useful if it showed the actual glibc instead of the required one)

andrewlock · 2024-12-05T15:21:02Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6402) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6402) - mean (978ms)  : 958, 997
     .   : milestone, 978,
    master - mean (975ms)  : 946, 1004
     .   : milestone, 975,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6402) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6402) - mean (677ms)  : 666, 688
     .   : milestone, 677,
    master - mean (680ms)  : 667, 693
     .   : milestone, 680,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6402) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6402) - mean (631ms)  : 616, 646
     .   : milestone, 631,
    master - mean (632ms)  : 615, 649
     .   : milestone, 632,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6402) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6402) - mean (1,096ms)  : 1061, 1131
     .   : milestone, 1096,
    master - mean (1,091ms)  : 1060, 1122
     .   : milestone, 1091,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6402) - mean (277ms)  : 271, 282
     .   : milestone, 277,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6402) - mean (874ms)  : 840, 909
     .   : milestone, 874,
    master - mean (867ms)  : 844, 890
     .   : milestone, 867,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6402) - mean (266ms)  : 260, 272
     .   : milestone, 266,
    master - mean (267ms)  : 262, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6402) - mean (854ms)  : 817, 891
     .   : milestone, 854,
    master - mean (849ms)  : 822, 876
     .   : milestone, 849,

andrewlock · 2024-12-05T19:02:19Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6402) (11.245M)   : 0, 11245248
    master (11.222M)   : 0, 11221800
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6402) (7.308M)   : 0, 7307770
    master (7.306M)   : 0, 7305807
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.621M)   : 0, 7620774

    section Manual
    master (11.257M)   : 0, 11257171

    section Manual + Automatic
    This PR (6402) (6.790M)   : 0, 6789501
    master (6.783M)   : 0, 6782564

    section DD_TRACE_ENABLED=0
    master (10.363M)   : 0, 10362594

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6402) (9.639M)   : 0, 9638553
    master (9.664M)   : 0, 9664098
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6402) (6.449M)   : 0, 6449393
    master (6.272M)   : 0, 6271501

    section Trace stats
    master (6.601M)   : 0, 6601213

    section Manual
    master (9.639M)   : 0, 9638684

    section Manual + Automatic
    This PR (6402) (5.967M)   : 0, 5966744
    master (5.996M)   : 0, 5996086

    section DD_TRACE_ENABLED=0
    master (8.743M)   : 0, 8742779

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6402) (9.934M)   : 0, 9934079
    master (10.051M)   : 0, 10050841
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6402) (6.370M)   : 0, 6370276
    master (6.245M)   : 0, 6245212
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.094M)   : 0, 7093813

    section Manual
    master (9.987M)   : 0, 9987436

    section Manual + Automatic
    This PR (6402) (5.711M)   : 0, 5710616
    master (5.990M)   : 0, 5990374

    section DD_TRACE_ENABLED=0
    master (9.233M)   : 0, 9232530

andrewlock · 2024-12-05T23:21:57Z

Benchmarks Report for tracer 🐌

Benchmarks for #6402 compared to master:

2 benchmarks are faster, with geometric mean 1.213
1 benchmarks are slower, with geometric mean 1.228
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.11μs	46.2ns	330ns	0.0206	0.00822	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	52.7ns	253ns	0.0199	0.00997	0	5.8 KB
master	`StartStopWithChild`	net472	16.1μs	62.4ns	242ns	1.05	0.324	0.105	6.21 KB
#6402	`StartStopWithChild`	net6.0	7.86μs	43.5ns	279ns	0.0159	0.00794	0	5.61 KB
#6402	`StartStopWithChild`	netcoreapp3.1	10.1μs	56.6ns	380ns	0.0294	0.0147	0	5.8 KB
#6402	`StartStopWithChild`	net472	16.3μs	49.5ns	192ns	1.03	0.294	0.0899	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	512μs	207ns	803ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	690μs	540ns	2.09μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	867μs	522ns	1.95μs	0.431	3.3 KB
#6402	`WriteAndFlushEnrichedTraces`	net6.0	498μs	198ns	741ns	0	2.7 KB
#6402	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	664μs	755ns	2.82μs	0	2.7 KB
#6402	`WriteAndFlushEnrichedTraces`	net472	858μs	550ns	2.06μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	152μs	889ns	8.48μs	0.151	14.47 KB
master	`SendRequest`	netcoreapp3.1	168μs	986ns	9.66μs	0.163	17.27 KB
master	`SendRequest`	net472	0.00269ns	0.000968ns	0.00375ns	0	0 b
#6402	`SendRequest`	net6.0	148μs	806ns	6.79μs	0.145	14.47 KB
#6402	`SendRequest`	netcoreapp3.1	168μs	978ns	8.86μs	0.163	17.27 KB
#6402	`SendRequest`	net472	0.00262ns	0.00092ns	0.00356ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	546μs	1.93μs	6.97μs	0.543	0	0	41.49 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	3.01μs	13.1μs	0.324	0	0	41.93 KB
master	`WriteAndFlushEnrichedTraces`	net472	846μs	4.16μs	19.1μs	8.33	2.5	0.417	53.29 KB
#6402	`WriteAndFlushEnrichedTraces`	net6.0	571μs	3.18μs	20.1μs	0.553	0	0	41.59 KB
#6402	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	649μs	3.02μs	12.1μs	0.331	0	0	41.79 KB
#6402	`WriteAndFlushEnrichedTraces`	net472	859μs	4.67μs	25.6μs	8.25	2.6	0.434	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	1.47ns	5.68ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.07ns	4ns	0.0137	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.05μs	2.12ns	8.22ns	0.157	0.00103	987 B
#6402	`ExecuteNonQuery`	net6.0	1.36μs	1.8ns	6.98ns	0.0144	0	1.02 KB
#6402	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.77ns	6.12ns	0.0134	0	1.02 KB
#6402	`ExecuteNonQuery`	net472	2.12μs	1.78ns	6.88ns	0.156	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.545ns	2.04ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.75ns	6.78ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.62μs	2.27ns	8.79ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.392ns	1.47ns	0.0129	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.59μs	1.16ns	4.34ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.68μs	1.45ns	5.62ns	0.166	1.05 KB
#6402	`CallElasticsearch`	net6.0	1.2μs	0.471ns	1.82ns	0.0139	976 B
#6402	`CallElasticsearch`	netcoreapp3.1	1.57μs	1.12ns	4.32ns	0.0133	976 B
#6402	`CallElasticsearch`	net472	2.61μs	2.98ns	11.5ns	0.157	995 B
#6402	`CallElasticsearchAsync`	net6.0	1.3μs	0.741ns	2.87ns	0.0129	952 B
#6402	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	0.627ns	2.17ns	0.0138	1.02 KB
#6402	`CallElasticsearchAsync`	net472	2.61μs	2.41ns	9.34ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	0.727ns	2.72ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.673ns	2.43ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.82μs	0.461ns	1.73ns	0.145	915 B
#6402	`ExecuteAsync`	net6.0	1.18μs	0.805ns	3.01ns	0.0131	952 B
#6402	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.973ns	3.64ns	0.0123	952 B
#6402	`ExecuteAsync`	net472	1.88μs	0.607ns	2.35ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.6μs	3.96ns	13.7ns	0.0323	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.26μs	2.08ns	8.06ns	0.0395	2.85 KB
master	`SendAsync`	net472	7.36μs	1.75ns	6.79ns	0.493	3.12 KB
#6402	`SendAsync`	net6.0	4.51μs	1.95ns	7.3ns	0.0317	2.31 KB
#6402	`SendAsync`	netcoreapp3.1	5.43μs	2.18ns	8.16ns	0.0378	2.85 KB
#6402	`SendAsync`	net472	7.28μs	1.54ns	5.98ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.57μs	1.12ns	4.19ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.27μs	0.74ns	2.67ns	0.0217	1.64 KB
master	`EnrichedLog`	net472	2.68μs	1.48ns	5.71ns	0.249	1.57 KB
#6402	`EnrichedLog`	net6.0	1.49μs	1.3ns	5.02ns	0.0231	1.64 KB
#6402	`EnrichedLog`	netcoreapp3.1	2.35μs	1.42ns	5.32ns	0.0223	1.64 KB
#6402	`EnrichedLog`	net472	2.58μs	1.15ns	4.46ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	122ns	474ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	101ns	390ns	0.062	0	4.28 KB
master	`EnrichedLog`	net472	153μs	82.1ns	307ns	0.689	0.23	4.46 KB
#6402	`EnrichedLog`	net6.0	120μs	203ns	788ns	0.061	0	4.28 KB
#6402	`EnrichedLog`	netcoreapp3.1	125μs	92.1ns	345ns	0	0	4.28 KB
#6402	`EnrichedLog`	net472	151μs	119ns	460ns	0.681	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.03μs	0.858ns	3.32ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.21μs	1.92ns	7.43ns	0.0292	2.2 KB
master	`EnrichedLog`	net472	4.85μs	1.37ns	5.3ns	0.32	2.02 KB
#6402	`EnrichedLog`	net6.0	3.28μs	0.926ns	3.59ns	0.0296	2.2 KB
#6402	`EnrichedLog`	netcoreapp3.1	4.08μs	0.978ns	3.79ns	0.0286	2.2 KB
#6402	`EnrichedLog`	net472	4.89μs	1.84ns	7.12ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.45μs	1.63ns	6.32ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.828ns	3.21ns	0.0159	1.14 KB
master	`SendReceive`	net472	2.1μs	1.75ns	6.79ns	0.183	1.16 KB
#6402	`SendReceive`	net6.0	1.34μs	0.73ns	2.73ns	0.016	1.14 KB
#6402	`SendReceive`	netcoreapp3.1	1.74μs	0.705ns	2.44ns	0.0156	1.14 KB
#6402	`SendReceive`	net472	2.12μs	8.91ns	34.5ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.74μs	1.38ns	5.35ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.94μs	1.3ns	4.87ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.49μs	3.15ns	12.2ns	0.322	2.04 KB
#6402	`EnrichedLog`	net6.0	2.78μs	1.08ns	4.19ns	0.0222	1.6 KB
#6402	`EnrichedLog`	netcoreapp3.1	3.87μs	1.49ns	5.56ns	0.0212	1.65 KB
#6402	`EnrichedLog`	net472	4.43μs	4.05ns	15.7ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6402

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.228	394.77	484.64

Faster 🎉 in #6402

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.314	636.90	484.60

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.665ns	2.58ns	0.00808	576 B
master	`StartFinishSpan`	netcoreapp3.1	607ns	1.15ns	4.44ns	0.00778	576 B
master	`StartFinishSpan`	net472	629ns	1.58ns	6.1ns	0.0916	578 B
master	`StartFinishScope`	net6.0	636ns	1.09ns	4.24ns	0.00957	696 B
master	`StartFinishScope`	netcoreapp3.1	689ns	1.02ns	3.97ns	0.00941	696 B
master	`StartFinishScope`	net472	901ns	3.72ns	14.4ns	0.104	658 B
#6402	`StartFinishSpan`	net6.0	484ns	0.902ns	3.49ns	0.00799	576 B
#6402	`StartFinishSpan`	netcoreapp3.1	589ns	0.854ns	3.31ns	0.00773	576 B
#6402	`StartFinishSpan`	net472	621ns	1.34ns	5.2ns	0.0915	578 B
#6402	`StartFinishScope`	net6.0	485ns	0.885ns	3.43ns	0.00977	696 B
#6402	`StartFinishScope`	netcoreapp3.1	666ns	1.08ns	4.18ns	0.00958	696 B
#6402	`StartFinishScope`	net472	955ns	1.32ns	5.12ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6402

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.120	936.28	835.83

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	648ns	1.7ns	6.6ns	0.00959	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	946ns	3.99ns	15.4ns	0.00904	696 B
master	`RunOnMethodBegin`	net472	1.12μs	1.06ns	3.95ns	0.104	658 B
#6402	`RunOnMethodBegin`	net6.0	705ns	1.03ns	3.98ns	0.00978	696 B
#6402	`RunOnMethodBegin`	netcoreapp3.1	837ns	1.83ns	7.11ns	0.00957	696 B
#6402	`RunOnMethodBegin`	net472	1.18μs	2.1ns	8.12ns	0.104	658 B

…is too old (#6402) ## Summary of changes Change the error message when loading the profiler fails because of the glibc version. Before: ``` Datadog - Some errors occurred while analyzing the crash: - Unexpected exception: System.DllNotFoundException: Unable to load shared library '/opt/datadog-packages/datadog-apm-library-dotnet/3.6.1/linux-arm64/Datadog.Prof iler.Native.so' or one of its dependencies. In order to help diagnose loading problems, consider using a tool like strace. If you're using glibc, consider setting the LD_DEBUG environment variable: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /opt/datadog-packages/datadog-apm-library-dotnet/3.6.1/linux-arm64/Datadog.Profi ler.Native.so) at System.Runtime.InteropServices.NativeLibrary.LoadLibErrorTracker.Throw(String) + 0x50 at System.Runtime.InteropServices.NativeLibrary.LoadFromPath(String, Boolean) + 0x4c at Datadog.Trace.Tools.dd_dotnet.CreatedumpCommand.GenerateCrashReport(Int32, Nullable`1, Nullable`1) + 0x110 at Datadog.Trace.Tools.dd_dotnet.CreatedumpCommand.Execute(InvocationContext context) + 0x94 ``` After: ``` Datadog - Some errors occurred while analyzing the crash: - The GLIBC version is too old ``` ## Reason for change The error is "expected" in some environment, so it's better to make the message less scary.

Display a nicer error message when the glibc version is too old

e655986

kevingosse added the area:crashtracking label Dec 5, 2024

kevingosse requested a review from a team as a code owner December 5, 2024 12:55

andrewlock approved these changes Dec 5, 2024

View reviewed changes

kevingosse merged commit 01a63d6 into master Dec 6, 2024
104 checks passed

kevingosse deleted the kevin/dd-dotnet-glibc branch December 6, 2024 10:08

github-actions bot added this to the vNext-v3 milestone Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Crashtracking] Display a nicer error message when the glibc version is too old #6402

[Crashtracking] Display a nicer error message when the glibc version is too old #6402

kevingosse commented Dec 5, 2024

andrewlock left a comment

datadog-ddstaging bot commented Dec 5, 2024 •

edited

Loading

kevingosse commented Dec 5, 2024

andrewlock commented Dec 5, 2024

andrewlock commented Dec 5, 2024

andrewlock commented Dec 5, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6402

Faster 🎉 in #6402

Raw results

Faster 🎉 in #6402

Raw results

[Crashtracking] Display a nicer error message when the glibc version is too old #6402

[Crashtracking] Display a nicer error message when the glibc version is too old #6402

Conversation

kevingosse commented Dec 5, 2024

Summary of changes

Reason for change

andrewlock left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Dec 5, 2024 • edited Loading

Datadog Report

⌛ Performance Regressions vs Default Branch (1)

kevingosse commented Dec 5, 2024

andrewlock commented Dec 5, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 5, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 5, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6402

Faster 🎉 in #6402

Raw results

Faster 🎉 in #6402

Raw results

datadog-ddstaging bot commented Dec 5, 2024 •

edited

Loading