-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #6437
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 458175 Passed, 2819 Skipped, 19h 16m 45.52s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6437) - mean (69ms) : 65, 72
. : milestone, 69,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6437) - mean (980ms) : 955, 1005
. : milestone, 980,
master - mean (976ms) : 953, 998
. : milestone, 976,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6437) - mean (107ms) : 105, 109
. : milestone, 107,
master - mean (107ms) : 104, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6437) - mean (677ms) : 655, 698
. : milestone, 677,
master - mean (679ms) : 662, 695
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6437) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 92
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6437) - mean (635ms) : 619, 651
. : milestone, 635,
master - mean (635ms) : 619, 651
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6437) - mean (194ms) : 190, 198
. : milestone, 194,
master - mean (193ms) : 188, 198
. : milestone, 193,
section CallTarget+Inlining+NGEN
This PR (6437) - mean (1,098ms) : 1075, 1121
. : milestone, 1098,
master - mean (1,096ms) : 1070, 1122
. : milestone, 1096,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6437) - mean (279ms) : 273, 284
. : milestone, 279,
master - mean (279ms) : 275, 284
. : milestone, 279,
section CallTarget+Inlining+NGEN
This PR (6437) - mean (872ms) : 841, 903
. : milestone, 872,
master - mean (871ms) : 845, 896
. : milestone, 871,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6437) - mean (267ms) : 262, 272
. : milestone, 267,
master - mean (266ms) : 263, 269
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6437) - mean (853ms) : 823, 884
. : milestone, 853,
master - mean (851ms) : 818, 884
. : milestone, 851,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6437) (11.086M) : 0, 11086277
master (11.244M) : 0, 11243896
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6437) (7.306M) : 0, 7306212
master (7.201M) : 0, 7201119
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.576M) : 0, 7576229
section Manual
master (11.196M) : 0, 11196081
section Manual + Automatic
This PR (6437) (6.737M) : 0, 6736945
master (6.638M) : 0, 6638437
section DD_TRACE_ENABLED=0
master (10.422M) : 0, 10421912
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6437) (9.671M) : 0, 9671042
master (9.372M) : 0, 9372216
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6437) (6.352M) : 0, 6352289
master (6.384M) : 0, 6383601
section Trace stats
master (6.655M) : 0, 6655008
section Manual
master (9.413M) : 0, 9413276
section Manual + Automatic
This PR (6437) (5.987M) : 0, 5986581
master (5.896M) : 0, 5895709
section DD_TRACE_ENABLED=0
master (8.890M) : 0, 8890260
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6437) (10.119M) : 0, 10119436
master (9.902M) : 0, 9901561
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6437) (6.476M) : 0, 6475933
master (6.645M) : 0, 6645144
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.167M) : 0, 7167171
section Manual
master (10.054M) : 0, 10054191
section Manual + Automatic
This PR (6437) (6.097M) : 0, 6097257
master (6.071M) : 0, 6070705
section DD_TRACE_ENABLED=0
master (9.440M) : 0, 9439995
|
Benchmarks Report for tracer 🐌Benchmarks for #6437 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.170 | 556.20 | 475.49 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 407ns | 0.154ns | 0.576ns | 0.00802 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 543ns | 0.315ns | 1.22ns | 0.00782 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 702ns | 0.585ns | 2.27ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 556ns | 0.232ns | 0.869ns | 0.00977 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 711ns | 0.489ns | 1.83ns | 0.00939 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 923ns | 0.52ns | 2.01ns | 0.104 | 0 | 0 | 658 B |
#6437 | StartFinishSpan |
net6.0 | 396ns | 0.223ns | 0.836ns | 0.00798 | 0 | 0 | 576 B |
#6437 | StartFinishSpan |
netcoreapp3.1 | 590ns | 0.713ns | 2.76ns | 0.00772 | 0 | 0 | 576 B |
#6437 | StartFinishSpan |
net472 | 637ns | 0.161ns | 0.624ns | 0.0918 | 0 | 0 | 578 B |
#6437 | StartFinishScope |
net6.0 | 475ns | 0.254ns | 0.985ns | 0.0098 | 0 | 0 | 696 B |
#6437 | StartFinishScope |
netcoreapp3.1 | 713ns | 0.412ns | 1.6ns | 0.00932 | 0 | 0 | 696 B |
#6437 | StartFinishScope |
net472 | 854ns | 0.285ns | 1.11ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 630ns | 0.423ns | 1.58ns | 0.00979 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 897ns | 0.46ns | 1.78ns | 0.00943 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.11μs | 0.573ns | 2.22ns | 0.104 | 0 | 0 | 658 B |
#6437 | RunOnMethodBegin |
net6.0 | 615ns | 0.303ns | 1.18ns | 0.00968 | 0 | 0 | 696 B |
#6437 | RunOnMethodBegin |
netcoreapp3.1 | 954ns | 1.03ns | 4ns | 0.00952 | 0 | 0 | 696 B |
#6437 | RunOnMethodBegin |
net472 | 1.12μs | 1.2ns | 4.64ns | 0.104 | 0 | 0 | 658 B |
37eb7d9
to
7501c05
Compare
7501c05
to
28bf702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pretty simple bumps
Updates the package versions for integration tests.