Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6437

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners December 13, 2024 16:33
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 13, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 28bf702
Test service: dd-trace-dotnet

✅ 0 Failed, 458175 Passed, 2819 Skipped, 19h 16m 45.52s Total Time

@andrewlock
Copy link
Member

andrewlock commented Dec 13, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6437) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6437) - mean (980ms)  : 955, 1005
     .   : milestone, 980,
    master - mean (976ms)  : 953, 998
     .   : milestone, 976,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6437) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6437) - mean (677ms)  : 655, 698
     .   : milestone, 677,
    master - mean (679ms)  : 662, 695
     .   : milestone, 679,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6437) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6437) - mean (635ms)  : 619, 651
     .   : milestone, 635,
    master - mean (635ms)  : 619, 651
     .   : milestone, 635,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6437) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (193ms)  : 188, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6437) - mean (1,098ms)  : 1075, 1121
     .   : milestone, 1098,
    master - mean (1,096ms)  : 1070, 1122
     .   : milestone, 1096,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6437) - mean (279ms)  : 273, 284
     .   : milestone, 279,
    master - mean (279ms)  : 275, 284
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6437) - mean (872ms)  : 841, 903
     .   : milestone, 872,
    master - mean (871ms)  : 845, 896
     .   : milestone, 871,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6437) - mean (267ms)  : 262, 272
     .   : milestone, 267,
    master - mean (266ms)  : 263, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6437) - mean (853ms)  : 823, 884
     .   : milestone, 853,
    master - mean (851ms)  : 818, 884
     .   : milestone, 851,

Loading

@andrewlock
Copy link
Member

andrewlock commented Dec 13, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6437) (11.086M)   : 0, 11086277
    master (11.244M)   : 0, 11243896
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6437) (7.306M)   : 0, 7306212
    master (7.201M)   : 0, 7201119
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.576M)   : 0, 7576229

    section Manual
    master (11.196M)   : 0, 11196081

    section Manual + Automatic
    This PR (6437) (6.737M)   : 0, 6736945
    master (6.638M)   : 0, 6638437

    section DD_TRACE_ENABLED=0
    master (10.422M)   : 0, 10421912

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6437) (9.671M)   : 0, 9671042
    master (9.372M)   : 0, 9372216
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6437) (6.352M)   : 0, 6352289
    master (6.384M)   : 0, 6383601

    section Trace stats
    master (6.655M)   : 0, 6655008

    section Manual
    master (9.413M)   : 0, 9413276

    section Manual + Automatic
    This PR (6437) (5.987M)   : 0, 5986581
    master (5.896M)   : 0, 5895709

    section DD_TRACE_ENABLED=0
    master (8.890M)   : 0, 8890260

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6437) (10.119M)   : 0, 10119436
    master (9.902M)   : 0, 9901561
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6437) (6.476M)   : 0, 6475933
    master (6.645M)   : 0, 6645144
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.167M)   : 0, 7167171

    section Manual
    master (10.054M)   : 0, 10054191

    section Manual + Automatic
    This PR (6437) (6.097M)   : 0, 6097257
    master (6.071M)   : 0, 6070705

    section DD_TRACE_ENABLED=0
    master (9.440M)   : 0, 9439995

Loading

@andrewlock
Copy link
Member

andrewlock commented Dec 13, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6437 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.170
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.03μs 44.8ns 280ns 0.0168 0.00842 0 5.62 KB
master StartStopWithChild netcoreapp3.1 9.86μs 55.9ns 379ns 0.0251 0.01 0 5.8 KB
master StartStopWithChild net472 16.4μs 56.9ns 221ns 1.05 0.327 0.106 6.21 KB
#6437 StartStopWithChild net6.0 8.26μs 44.3ns 255ns 0.02 0.00798 0 5.61 KB
#6437 StartStopWithChild netcoreapp3.1 10.1μs 50.7ns 278ns 0.0196 0.00982 0 5.8 KB
#6437 StartStopWithChild net472 16.6μs 59.2ns 229ns 1.03 0.298 0.0805 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 478μs 321ns 1.25μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 355ns 1.38μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 857μs 450ns 1.68μs 0.431 0 0 3.3 KB
#6437 WriteAndFlushEnrichedTraces net6.0 472μs 216ns 837ns 0 0 0 2.7 KB
#6437 WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 665ns 2.58μs 0 0 0 2.7 KB
#6437 WriteAndFlushEnrichedTraces net472 857μs 434ns 1.62μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 155μs 934ns 9.11μs 0.145 0 0 14.47 KB
master SendRequest netcoreapp3.1 169μs 992ns 9.09μs 0.173 0 0 17.27 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6437 SendRequest net6.0 148μs 845ns 6.15μs 0.145 0 0 14.47 KB
#6437 SendRequest netcoreapp3.1 169μs 1.08μs 10.5μs 0.16 0 0 17.27 KB
#6437 SendRequest net472 0.000445ns 0.000254ns 0.00095ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 572μs 2.72μs 11.5μs 0.581 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 3.38μs 20.3μs 0.379 0 0 41.65 KB
master WriteAndFlushEnrichedTraces net472 833μs 2.98μs 10.8μs 8.33 2.5 0.417 53.27 KB
#6437 WriteAndFlushEnrichedTraces net6.0 570μs 2.55μs 9.86μs 0.581 0 0 41.62 KB
#6437 WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 3.17μs 13.8μs 0.342 0 0 41.77 KB
#6437 WriteAndFlushEnrichedTraces net472 857μs 4.51μs 21.6μs 8.81 2.52 0.419 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.34μs 1.63ns 6.08ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.79μs 1.58ns 6.12ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.13μs 1.5ns 5.6ns 0.157 0.00105 0 987 B
#6437 ExecuteNonQuery net6.0 1.31μs 1.04ns 4.02ns 0.0141 0 0 1.02 KB
#6437 ExecuteNonQuery netcoreapp3.1 1.85μs 1.05ns 3.78ns 0.0139 0 0 1.02 KB
#6437 ExecuteNonQuery net472 2.09μs 3.05ns 11.8ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.33μs 0.421ns 1.52ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.64μs 1.13ns 4.21ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.54μs 2.48ns 9.62ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.3μs 3.34ns 13ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 0.985ns 3.82ns 0.0132 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 2.27ns 8.5ns 0.166 0 0 1.05 KB
#6437 CallElasticsearch net6.0 1.3μs 2.23ns 8.63ns 0.0136 0 0 976 B
#6437 CallElasticsearch netcoreapp3.1 1.61μs 1ns 3.74ns 0.0129 0 0 976 B
#6437 CallElasticsearch net472 2.46μs 2.03ns 7.87ns 0.157 0 0 995 B
#6437 CallElasticsearchAsync net6.0 1.23μs 0.753ns 2.72ns 0.013 0 0 952 B
#6437 CallElasticsearchAsync netcoreapp3.1 1.71μs 1.03ns 3.85ns 0.0141 0 0 1.02 KB
#6437 CallElasticsearchAsync net472 2.69μs 2ns 7.73ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 0.67ns 2.6ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.626ns 2.43ns 0.0131 0 0 952 B
master ExecuteAsync net472 1.81μs 0.718ns 2.78ns 0.145 0 0 915 B
#6437 ExecuteAsync net6.0 1.38μs 0.858ns 3.09ns 0.0132 0 0 952 B
#6437 ExecuteAsync netcoreapp3.1 1.56μs 0.832ns 3ns 0.0124 0 0 952 B
#6437 ExecuteAsync net472 1.78μs 0.678ns 2.63ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.46μs 1.41ns 5.46ns 0.0311 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.55μs 1.45ns 5.44ns 0.039 0 0 2.85 KB
master SendAsync net472 7.37μs 2.3ns 8.92ns 0.494 0 0 3.12 KB
#6437 SendAsync net6.0 4.36μs 2.17ns 7.84ns 0.0327 0 0 2.31 KB
#6437 SendAsync netcoreapp3.1 5.23μs 1.43ns 5.37ns 0.0368 0 0 2.85 KB
#6437 SendAsync net472 7.31μs 2.17ns 8.41ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.991ns 3.71ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.18μs 5.29ns 20.5ns 0.0216 0 0 1.64 KB
master EnrichedLog net472 2.71μs 1.18ns 4.57ns 0.249 0 0 1.57 KB
#6437 EnrichedLog net6.0 1.44μs 1.25ns 4.66ns 0.0231 0 0 1.64 KB
#6437 EnrichedLog netcoreapp3.1 2.22μs 0.856ns 3.2ns 0.023 0 0 1.64 KB
#6437 EnrichedLog net472 2.62μs 1.15ns 4ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 153ns 592ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 140ns 540ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 228ns 884ns 0.675 0.225 0 4.46 KB
#6437 EnrichedLog net6.0 118μs 387ns 1.5μs 0.0593 0 0 4.28 KB
#6437 EnrichedLog netcoreapp3.1 124μs 209ns 808ns 0 0 0 4.28 KB
#6437 EnrichedLog net472 154μs 160ns 620ns 0.695 0.232 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 0.832ns 3.11ns 0.031 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.19μs 3.91ns 15.2ns 0.0294 0 0 2.2 KB
master EnrichedLog net472 4.87μs 1.82ns 7.03ns 0.319 0 0 2.02 KB
#6437 EnrichedLog net6.0 3.07μs 1.37ns 5.11ns 0.0308 0 0 2.2 KB
#6437 EnrichedLog netcoreapp3.1 4.12μs 1.72ns 6.67ns 0.0288 0 0 2.2 KB
#6437 EnrichedLog net472 4.91μs 1.38ns 5.36ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.44μs 0.785ns 2.94ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.88μs 1.56ns 5.82ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.21μs 0.867ns 3.01ns 0.184 0 0 1.16 KB
#6437 SendReceive net6.0 1.31μs 0.556ns 2.15ns 0.0157 0 0 1.14 KB
#6437 SendReceive netcoreapp3.1 1.75μs 1.15ns 4.47ns 0.0157 0 0 1.14 KB
#6437 SendReceive net472 2.11μs 1.76ns 6.57ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 0.86ns 3.33ns 0.0222 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.02μs 1.3ns 4.85ns 0.0225 0 0 1.65 KB
master EnrichedLog net472 4.55μs 3.92ns 15.2ns 0.323 0 0 2.04 KB
#6437 EnrichedLog net6.0 2.72μs 1.33ns 5.15ns 0.0217 0 0 1.6 KB
#6437 EnrichedLog netcoreapp3.1 3.83μs 3.16ns 12.2ns 0.0208 0 0 1.65 KB
#6437 EnrichedLog net472 4.35μs 3.44ns 13.3ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6437

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.170 556.20 475.49

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 407ns 0.154ns 0.576ns 0.00802 0 0 576 B
master StartFinishSpan netcoreapp3.1 543ns 0.315ns 1.22ns 0.00782 0 0 576 B
master StartFinishSpan net472 702ns 0.585ns 2.27ns 0.0915 0 0 578 B
master StartFinishScope net6.0 556ns 0.232ns 0.869ns 0.00977 0 0 696 B
master StartFinishScope netcoreapp3.1 711ns 0.489ns 1.83ns 0.00939 0 0 696 B
master StartFinishScope net472 923ns 0.52ns 2.01ns 0.104 0 0 658 B
#6437 StartFinishSpan net6.0 396ns 0.223ns 0.836ns 0.00798 0 0 576 B
#6437 StartFinishSpan netcoreapp3.1 590ns 0.713ns 2.76ns 0.00772 0 0 576 B
#6437 StartFinishSpan net472 637ns 0.161ns 0.624ns 0.0918 0 0 578 B
#6437 StartFinishScope net6.0 475ns 0.254ns 0.985ns 0.0098 0 0 696 B
#6437 StartFinishScope netcoreapp3.1 713ns 0.412ns 1.6ns 0.00932 0 0 696 B
#6437 StartFinishScope net472 854ns 0.285ns 1.11ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 630ns 0.423ns 1.58ns 0.00979 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 897ns 0.46ns 1.78ns 0.00943 0 0 696 B
master RunOnMethodBegin net472 1.11μs 0.573ns 2.22ns 0.104 0 0 658 B
#6437 RunOnMethodBegin net6.0 615ns 0.303ns 1.18ns 0.00968 0 0 696 B
#6437 RunOnMethodBegin netcoreapp3.1 954ns 1.03ns 4ns 0.00952 0 0 696 B
#6437 RunOnMethodBegin net472 1.12μs 1.2ns 4.64ns 0.104 0 0 658 B

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 37eb7d9 to 7501c05 Compare December 15, 2024 00:28
@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 7501c05 to 28bf702 Compare December 16, 2024 16:44
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty simple bumps

@andrewlock andrewlock merged commit 45b92ba into master Dec 17, 2024
94 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch December 17, 2024 12:10
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 17, 2024
@andrewlock andrewlock added dependencies Pull requests that update a dependency file area:dependabot dependabot updates area:integrations labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates area:integrations dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant