[ASM] Update WAF version to 1.22.0 #6440

NachoEchevarria · 2024-12-16T11:21:13Z

Summary of changes

This PR updated the WAF to version 1.22.0

No breaking changes are expected from this version change.

Reason for change

Implementation details

Test coverage

Other details

github-actions · 2024-12-16T11:22:00Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

-        "_dd.appsec.waf.version": "1.21.0",
+        "_dd.appsec.waf.version": "1.22.0",

8 occurrences of :

-      _dd.appsec.waf.version: 1.21.0,
+      _dd.appsec.waf.version: 1.22.0,

andrewlock · 2024-12-16T11:54:15Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6440) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6440) - mean (980ms)  : 947, 1013
     .   : milestone, 980,
    master - mean (976ms)  : 953, 998
     .   : milestone, 976,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6440) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6440) - mean (677ms)  : 661, 693
     .   : milestone, 677,
    master - mean (679ms)  : 662, 695
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6440) - mean (91ms)  : 88, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6440) - mean (633ms)  : 608, 658
     .   : milestone, 633,
    master - mean (635ms)  : 619, 651
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6440) - mean (194ms)  : 189, 199
     .   : milestone, 194,
    master - mean (193ms)  : 188, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6440) - mean (1,101ms)  : 1065, 1136
     .   : milestone, 1101,
    master - mean (1,096ms)  : 1070, 1122
     .   : milestone, 1096,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6440) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (279ms)  : 275, 284
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6440) - mean (868ms)  : 843, 894
     .   : milestone, 868,
    master - mean (871ms)  : 845, 896
     .   : milestone, 871,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6440) - mean (267ms)  : 263, 270
     .   : milestone, 267,
    master - mean (266ms)  : 263, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6440) - mean (853ms)  : 822, 884
     .   : milestone, 853,
    master - mean (851ms)  : 818, 884
     .   : milestone, 851,

andrewlock · 2024-12-16T12:18:03Z

Benchmarks Report for tracer 🐌

Benchmarks for #6440 compared to master:

1 benchmarks are faster, with geometric mean 1.115
2 benchmarks are slower, with geometric mean 1.192
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.02μs	43.7ns	287ns	0.0157	0.00784	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	46.8ns	181ns	0.0201	0.0101	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	38.9ns	151ns	1.04	0.303	0.0983	6.2 KB
#6440	`StartStopWithChild`	net6.0	8.22μs	45.2ns	286ns	0.0197	0.00789	0	5.61 KB
#6440	`StartStopWithChild`	netcoreapp3.1	10.3μs	58.3ns	404ns	0.0155	0.00516	0	5.81 KB
#6440	`StartStopWithChild`	net472	16.3μs	58.4ns	226ns	1.04	0.308	0.0974	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	785ns	3.04μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	1.74μs	6.75μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	757ns	2.62μs	0.422	3.3 KB
#6440	`WriteAndFlushEnrichedTraces`	net6.0	483μs	345ns	1.29μs	0	2.7 KB
#6440	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	642μs	309ns	1.2μs	0	2.7 KB
#6440	`WriteAndFlushEnrichedTraces`	net472	853μs	401ns	1.55μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	149μs	869ns	8.24μs	0.153	14.47 KB
master	`SendRequest`	netcoreapp3.1	169μs	976ns	8.4μs	0.17	17.27 KB
master	`SendRequest`	net472	0.000589ns	0.000489ns	0.00183ns	0	0 b
#6440	`SendRequest`	net6.0	152μs	866ns	6.12μs	0.155	14.47 KB
#6440	`SendRequest`	netcoreapp3.1	173μs	1μs	8.15μs	0.165	17.27 KB
#6440	`SendRequest`	net472	0.000488ns	0.000249ns	0.000966ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	588μs	3.25μs	19.2μs	0.561	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	2.92μs	16μs	0.331	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	net472	838μs	4.22μs	17.9μs	8.52	2.44	0.406	53.26 KB
#6440	`WriteAndFlushEnrichedTraces`	net6.0	568μs	2.88μs	12.9μs	0.551	0	0	41.71 KB
#6440	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	3.06μs	11.4μs	0.331	0	0	41.83 KB
#6440	`WriteAndFlushEnrichedTraces`	net472	849μs	3.47μs	13μs	8.28	2.48	0.414	53.26 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	1.02ns	3.94ns	0.0146	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	2.54ns	9.85ns	0.0136	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.14μs	1.84ns	7.12ns	0.157	0.00107	987 B
#6440	`ExecuteNonQuery`	net6.0	1.31μs	0.882ns	3.41ns	0.0145	0	1.02 KB
#6440	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	2.49ns	9.64ns	0.0139	0	1.02 KB
#6440	`ExecuteNonQuery`	net472	2.09μs	1.15ns	4.29ns	0.157	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.33μs	0.64ns	2.48ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.39ns	5.2ns	0.013	976 B
master	`CallElasticsearch`	net472	2.59μs	2.4ns	9.28ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.36μs	0.422ns	1.52ns	0.0128	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.02ns	3.93ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	2.13ns	8.26ns	0.166	1.05 KB
#6440	`CallElasticsearch`	net6.0	1.3μs	0.82ns	3.17ns	0.0137	976 B
#6440	`CallElasticsearch`	netcoreapp3.1	1.49μs	1.45ns	5.63ns	0.0127	976 B
#6440	`CallElasticsearch`	net472	2.62μs	2.87ns	11.1ns	0.158	995 B
#6440	`CallElasticsearchAsync`	net6.0	1.25μs	0.665ns	2.58ns	0.0131	952 B
#6440	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.809ns	3.13ns	0.014	1.02 KB
#6440	`CallElasticsearchAsync`	net472	2.61μs	2.34ns	9.08ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.38μs	0.494ns	1.91ns	0.0128	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.436ns	1.63ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.82μs	0.371ns	1.39ns	0.145	915 B
#6440	`ExecuteAsync`	net6.0	1.31μs	0.954ns	3.69ns	0.0132	952 B
#6440	`ExecuteAsync`	netcoreapp3.1	1.69μs	0.75ns	2.9ns	0.0127	952 B
#6440	`ExecuteAsync`	net472	1.81μs	0.409ns	1.53ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.3μs	1.95ns	7.54ns	0.0323	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	1.59ns	5.97ns	0.0374	2.85 KB
master	`SendAsync`	net472	7.38μs	1.78ns	6.88ns	0.494	3.12 KB
#6440	`SendAsync`	net6.0	4.38μs	1.34ns	5ns	0.0327	2.31 KB
#6440	`SendAsync`	netcoreapp3.1	5.29μs	1.79ns	6.95ns	0.037	2.85 KB
#6440	`SendAsync`	net472	7.28μs	1.99ns	7.73ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	0.72ns	2.69ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.43μs	2.01ns	7.79ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.8μs	1.47ns	5.68ns	0.249	1.57 KB
#6440	`EnrichedLog`	net6.0	1.61μs	0.853ns	3.3ns	0.0229	1.64 KB
#6440	`EnrichedLog`	netcoreapp3.1	2.32μs	4.3ns	16.7ns	0.0226	1.64 KB
#6440	`EnrichedLog`	net472	2.63μs	1.14ns	4.4ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	243ns	941ns	0.0591	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	171ns	662ns	0	0	4.28 KB
master	`EnrichedLog`	net472	154μs	81.5ns	294ns	0.684	0.228	4.46 KB
#6440	`EnrichedLog`	net6.0	116μs	141ns	545ns	0.058	0	4.28 KB
#6440	`EnrichedLog`	netcoreapp3.1	121μs	197ns	739ns	0	0	4.28 KB
#6440	`EnrichedLog`	net472	150μs	70.8ns	274ns	0.675	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.06ns	4.1ns	0.0299	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.25μs	2.98ns	11.5ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	4.89μs	1.4ns	5.42ns	0.32	2.02 KB
#6440	`EnrichedLog`	net6.0	3.14μs	15.4ns	61.8ns	0.031	2.2 KB
#6440	`EnrichedLog`	netcoreapp3.1	4.22μs	3.38ns	13.1ns	0.0297	2.2 KB
#6440	`EnrichedLog`	net472	4.8μs	1.7ns	6.59ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	0.911ns	3.53ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.93μs	0.778ns	3.01ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.21μs	0.887ns	3.44ns	0.183	1.16 KB
#6440	`SendReceive`	net6.0	1.33μs	0.563ns	2.11ns	0.0159	1.14 KB
#6440	`SendReceive`	netcoreapp3.1	1.84μs	2.15ns	8.33ns	0.0156	1.14 KB
#6440	`SendReceive`	net472	2.1μs	0.863ns	3.34ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	0.668ns	2.41ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	2.14ns	8.29ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.42μs	3.49ns	13.5ns	0.322	2.04 KB
#6440	`EnrichedLog`	net6.0	2.67μs	0.446ns	1.67ns	0.0228	1.6 KB
#6440	`EnrichedLog`	netcoreapp3.1	3.95μs	2.18ns	8.43ns	0.0216	1.65 KB
#6440	`EnrichedLog`	net472	4.37μs	3.35ns	13ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6440

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.138	402.04	457.57

Faster 🎉 in #6440

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.115	555.70	498.39

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	402ns	0.238ns	0.921ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	616ns	0.76ns	2.95ns	0.00768	576 B
master	`StartFinishSpan`	net472	631ns	0.366ns	1.42ns	0.0916	578 B
master	`StartFinishScope`	net6.0	556ns	0.355ns	1.38ns	0.00982	696 B
master	`StartFinishScope`	netcoreapp3.1	733ns	0.697ns	2.7ns	0.00919	696 B
master	`StartFinishScope`	net472	849ns	0.866ns	3.35ns	0.104	658 B
#6440	`StartFinishSpan`	net6.0	458ns	0.216ns	0.837ns	0.00807	576 B
#6440	`StartFinishSpan`	netcoreapp3.1	615ns	0.559ns	2.16ns	0.0077	576 B
#6440	`StartFinishSpan`	net472	637ns	0.323ns	1.25ns	0.0917	578 B
#6440	`StartFinishScope`	net6.0	498ns	0.401ns	1.55ns	0.00981	696 B
#6440	`StartFinishScope`	netcoreapp3.1	667ns	0.4ns	1.55ns	0.00937	696 B
#6440	`StartFinishScope`	net472	870ns	1.18ns	4.59ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6440

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.249	591.12	738.31

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	591ns	0.394ns	1.47ns	0.00976	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	885ns	0.35ns	1.31ns	0.00973	696 B
master	`RunOnMethodBegin`	net472	1.16μs	1.04ns	4.04ns	0.104	658 B
#6440	`RunOnMethodBegin`	net6.0	738ns	0.682ns	2.64ns	0.01	696 B
#6440	`RunOnMethodBegin`	netcoreapp3.1	926ns	1.7ns	6.59ns	0.00918	696 B
#6440	`RunOnMethodBegin`	net472	1.06μs	0.576ns	2.15ns	0.104	658 B

andrewlock · 2024-12-16T12:18:14Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6440) (11.066M)   : 0, 11066195
    master (11.173M)   : 0, 11172862
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6440) (7.295M)   : 0, 7294988
    master (7.214M)   : 0, 7214402
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.560M)   : 0, 7559850

    section Manual
    master (11.194M)   : 0, 11193707

    section Manual + Automatic
    This PR (6440) (6.815M)   : 0, 6814902
    master (6.718M)   : 0, 6717525

    section DD_TRACE_ENABLED=0
    master (10.296M)   : 0, 10295976

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6440) (9.483M)   : 0, 9482509
    master (9.776M)   : 0, 9776047
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6440) (6.372M)   : 0, 6371528
    master (6.425M)   : 0, 6425271

    section Trace stats
    master (6.758M)   : 0, 6757513

    section Manual
    master (9.661M)   : 0, 9660549

    section Manual + Automatic
    This PR (6440) (5.877M)   : 0, 5877195
    master (6.039M)   : 0, 6038872

    section DD_TRACE_ENABLED=0
    master (8.861M)   : 0, 8860501

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6440) (10.058M)   : 0, 10057721
    master (9.399M)   : 0, 9399211
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6440) (6.346M)   : 0, 6345722
    master (5.619M)   : 0, 5618747
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.816M)   : 0, 6816490

    section Manual
    master (9.559M)   : 0, 9558747

    section Manual + Automatic
    This PR (6440) (5.831M)   : 0, 5831196
    master (6.022M)   : 0, 6022498

    section DD_TRACE_ENABLED=0
    master (9.201M)   : 0, 9201064

datadog-ddstaging · 2024-12-16T12:27:48Z

Datadog Report

Branch report: nacho/UpdateWAF1.22.0
Commit report: 3091af0
Test service: dd-trace-dotnet

✅ 0 Failed, 457341 Passed, 2817 Skipped, 20h 11m 24.74s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

FlakyRetries - Datadog.Trace.ClrProfiler.IntegrationTests.CI.MsTestV2RetriesTests - Last Failure
Expand for error
```
 The sample did not exit in 600000ms. Memory dump taken: True. Killing process.
```
EarlyFlakeDetection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.UdsXUnitEvpTests - Last Failure
Expand for error
```
 The sample did not exit in 600000ms. Memory dump taken: True. Killing process.
```

e-n-0

LGTM 😄

NachoEchevarria · 2024-12-17T13:45:27Z

Thank you for you reviews!

Update waf version to 1.22.0

3091af0

NachoEchevarria changed the title ~~Update waf version to 1.22.0~~ [ASM] Update WAF version to 1.22.0 Dec 16, 2024

github-actions bot added the area:asm label Dec 16, 2024

NachoEchevarria marked this pull request as ready for review December 17, 2024 11:54

NachoEchevarria requested review from a team as code owners December 17, 2024 11:54

andrewlock approved these changes Dec 17, 2024

View reviewed changes

e-n-0 approved these changes Dec 17, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

daniel-romano-DD approved these changes Dec 17, 2024

View reviewed changes

NachoEchevarria merged commit a307e05 into master Dec 17, 2024
102 of 104 checks passed

NachoEchevarria deleted the nacho/UpdateWAF1.22.0 branch December 17, 2024 13:45

github-actions bot added this to the vNext-v3 milestone Dec 17, 2024

robertpi added the area:asm-waf-update label Dec 18, 2024

andrewlock removed the area:asm-waf-update label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASM] Update WAF version to 1.22.0 #6440

[ASM] Update WAF version to 1.22.0 #6440

NachoEchevarria commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024

andrewlock commented Dec 16, 2024

andrewlock commented Dec 16, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6440

Faster 🎉 in #6440

Raw results

Slower ⚠️ in #6440

Raw results

andrewlock commented Dec 16, 2024

datadog-ddstaging bot commented Dec 16, 2024 •

edited

Loading

e-n-0 left a comment

This comment was marked as duplicate.

NachoEchevarria commented Dec 17, 2024

[ASM] Update WAF version to 1.22.0 #6440

[ASM] Update WAF version to 1.22.0 #6440

Conversation

NachoEchevarria commented Dec 16, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

github-actions bot commented Dec 16, 2024

Snapshots difference summary

andrewlock commented Dec 16, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 16, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6440

Faster 🎉 in #6440

Raw results

Slower ⚠️ in #6440

Raw results

andrewlock commented Dec 16, 2024

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Dec 16, 2024 • edited Loading

Datadog Report

New Flaky Tests (2)

e-n-0 left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

NachoEchevarria commented Dec 17, 2024

NachoEchevarria commented Dec 16, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 16, 2024 •

edited

Loading