Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Instrumentation] Hotfix SymDB and ER (#6468) #6473

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

dudikeleti
Copy link
Contributor

  • Disable compression in SymDB
  • Fix out of range exception while collecting arguments of some methods
  • Fix type mismatch in dnlib metadata reader that causes invalid cast exception
  • Exception Replay should work even Live Debugger has not initialized

- Disable compression in SymDB
- Fix out of range exception while collecting arguments of some methods
- Fix type mismatch in dnlib metadata reader that causes invalid cast exception
- Exception Replay should work even Live Debugger has not initialized
@dudikeleti dudikeleti requested a review from a team as a code owner December 20, 2024 05:05
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 20, 2024

Datadog Report

Branch report: dudik/hotfix-3.7.1
Commit report: 4550f7a
Test service: dd-trace-dotnet

✅ 0 Failed, 300135 Passed, 2043 Skipped, 20h 25m 1.05s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6473) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6473) - mean (973ms)  : 954, 993
     .   : milestone, 973,
    master - mean (975ms)  : 954, 997
     .   : milestone, 975,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6473) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6473) - mean (678ms)  : 665, 691
     .   : milestone, 678,
    master - mean (677ms)  : 660, 694
     .   : milestone, 677,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6473) - mean (91ms)  : 88, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6473) - mean (634ms)  : 619, 649
     .   : milestone, 634,
    master - mean (635ms)  : 620, 651
     .   : milestone, 635,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6473) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (193ms)  : 189, 196
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6473) - mean (1,098ms)  : 1061, 1136
     .   : milestone, 1098,
    master - mean (1,095ms)  : 1070, 1120
     .   : milestone, 1095,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6473) - mean (277ms)  : 274, 281
     .   : milestone, 277,
    master - mean (278ms)  : 273, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6473) - mean (870ms)  : 843, 897
     .   : milestone, 870,
    master - mean (869ms)  : 838, 900
     .   : milestone, 869,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6473) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (271ms)  : 251, 292
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6473) - mean (848ms)  : 812, 885
     .   : milestone, 848,
    master - mean (848ms)  : 815, 881
     .   : milestone, 848,

Loading

Copy link
Contributor

@GreenMatan GreenMatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudikeleti dudikeleti merged commit eee5579 into hotfix/3.7.1 Dec 20, 2024
52 of 58 checks passed
@dudikeleti dudikeleti deleted the dudik/hotfix-3.7.1 branch December 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants