Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #6499

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[Test Package Versions Bump] Updating package versions #6499

merged 1 commit into from
Jan 7, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 5, 2025

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners January 5, 2025 00:25
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6499) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6499) - mean (982ms)  : 955, 1008
     .   : milestone, 982,
    master - mean (982ms)  : 960, 1004
     .   : milestone, 982,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6499) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6499) - mean (678ms)  : 663, 693
     .   : milestone, 678,
    master - mean (675ms)  : 662, 689
     .   : milestone, 675,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6499) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6499) - mean (633ms)  : 617, 650
     .   : milestone, 633,
    master - mean (636ms)  : 623, 648
     .   : milestone, 636,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6499) - mean (194ms)  : 190, 199
     .   : milestone, 194,
    master - mean (193ms)  : 190, 197
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6499) - mean (1,099ms)  : 1069, 1130
     .   : milestone, 1099,
    master - mean (1,098ms)  : 1074, 1123
     .   : milestone, 1098,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6499) - mean (278ms)  : 273, 282
     .   : milestone, 278,
    master - mean (277ms)  : 271, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6499) - mean (870ms)  : 842, 897
     .   : milestone, 870,
    master - mean (872ms)  : 844, 901
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6499) - mean (267ms)  : 262, 271
     .   : milestone, 267,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6499) - mean (853ms)  : 818, 887
     .   : milestone, 853,
    master - mean (849ms)  : 817, 882
     .   : milestone, 849,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 5, 2025 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 42e5e8b
Test service: dd-trace-dotnet

✅ 0 Failed, 230191 Passed, 2087 Skipped, 18h 27m 48.39s Total Time

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6499 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.07μs 43.9ns 335ns 0.0155 0.00774 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.3μs 53.4ns 311ns 0.021 0.0105 0 5.8 KB
master StartStopWithChild net472 16.6μs 51.4ns 199ns 1.03 0.306 0.0992 6.2 KB
#6499 StartStopWithChild net6.0 7.91μs 42.3ns 232ns 0.0153 0.00765 0 5.6 KB
#6499 StartStopWithChild netcoreapp3.1 10.1μs 46.7ns 193ns 0.0151 0.00503 0 5.8 KB
#6499 StartStopWithChild net472 16.4μs 46.2ns 179ns 1.04 0.322 0.0991 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 480μs 241ns 935ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 372ns 1.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 855μs 578ns 2.24μs 0.428 0 0 3.3 KB
#6499 WriteAndFlushEnrichedTraces net6.0 475μs 251ns 938ns 0 0 0 2.7 KB
#6499 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 328ns 1.23μs 0 0 0 2.7 KB
#6499 WriteAndFlushEnrichedTraces net472 861μs 918ns 3.55μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 147μs 851ns 6.91μs 0.144 0 0 14.47 KB
master SendRequest netcoreapp3.1 174μs 1.15μs 11.3μs 0.163 0 0 17.27 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6499 SendRequest net6.0 151μs 777ns 4.85μs 0.148 0 0 14.47 KB
#6499 SendRequest netcoreapp3.1 177μs 1.4μs 13.6μs 0.173 0 0 17.27 KB
#6499 SendRequest net472 0.000873ns 0.000647ns 0.00233ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6499

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.54 KB 41.77 KB 228 B 0.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 554μs 2.86μs 13.4μs 0.539 0 0 41.54 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 3.37μs 16.2μs 0.317 0 0 41.77 KB
master WriteAndFlushEnrichedTraces net472 850μs 2.53μs 9.46μs 8.17 2.45 0.408 53.26 KB
#6499 WriteAndFlushEnrichedTraces net6.0 613μs 5.61μs 53.2μs 0.576 0 0 41.77 KB
#6499 WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 3.42μs 15.3μs 0.332 0 0 41.86 KB
#6499 WriteAndFlushEnrichedTraces net472 851μs 2.76μs 9.96μs 8.17 2.45 0.408 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.24μs 1.14ns 4.42ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.85μs 1.79ns 6.7ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 2.04ns 7.91ns 0.157 0.00108 0 987 B
#6499 ExecuteNonQuery net6.0 1.25μs 0.719ns 2.79ns 0.0144 0 0 1.02 KB
#6499 ExecuteNonQuery netcoreapp3.1 1.75μs 1.11ns 4.28ns 0.0138 0 0 1.02 KB
#6499 ExecuteNonQuery net472 2.05μs 1.78ns 6.65ns 0.157 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.15μs 0.479ns 1.86ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 0.752ns 2.71ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.51μs 1.08ns 4.18ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 0.581ns 2.25ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 1.38ns 5.35ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.59μs 0.919ns 3.44ns 0.167 0 0 1.05 KB
#6499 CallElasticsearch net6.0 1.1μs 0.413ns 1.49ns 0.0138 0 0 976 B
#6499 CallElasticsearch netcoreapp3.1 1.59μs 1.16ns 4.33ns 0.0127 0 0 976 B
#6499 CallElasticsearch net472 2.59μs 1.08ns 4.04ns 0.158 0 0 995 B
#6499 CallElasticsearchAsync net6.0 1.24μs 1.01ns 3.77ns 0.0137 0 0 952 B
#6499 CallElasticsearchAsync netcoreapp3.1 1.62μs 2.93ns 11ns 0.0139 0 0 1.02 KB
#6499 CallElasticsearchAsync net472 2.52μs 0.941ns 3.52ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.35μs 0.574ns 2.15ns 0.0129 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 0.749ns 2.7ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.83μs 0.493ns 1.91ns 0.145 0 0 915 B
#6499 ExecuteAsync net6.0 1.29μs 0.822ns 3.07ns 0.0135 0 0 952 B
#6499 ExecuteAsync netcoreapp3.1 1.67μs 0.632ns 2.36ns 0.0124 0 0 952 B
#6499 ExecuteAsync net472 1.86μs 0.953ns 3.69ns 0.144 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.38μs 2.2ns 7.62ns 0.0329 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.29μs 1.51ns 5.46ns 0.0372 0 0 2.85 KB
master SendAsync net472 7.4μs 1.96ns 7.61ns 0.495 0 0 3.12 KB
#6499 SendAsync net6.0 4.43μs 1.81ns 6.78ns 0.0311 0 0 2.31 KB
#6499 SendAsync netcoreapp3.1 5.34μs 1.79ns 6.94ns 0.0375 0 0 2.85 KB
#6499 SendAsync net472 7.3μs 2.02ns 7.55ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 0.556ns 2.08ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.3μs 1.32ns 4.75ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.69μs 1.45ns 5.6ns 0.249 0 0 1.57 KB
#6499 EnrichedLog net6.0 1.46μs 1.21ns 4.7ns 0.0233 0 0 1.64 KB
#6499 EnrichedLog netcoreapp3.1 2.18μs 1.01ns 3.77ns 0.0216 0 0 1.64 KB
#6499 EnrichedLog net472 2.7μs 1.5ns 5.61ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 128ns 495ns 0.0584 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 362ns 1.4μs 0 0 0 4.28 KB
master EnrichedLog net472 153μs 127ns 494ns 0.681 0.227 0 4.46 KB
#6499 EnrichedLog net6.0 118μs 315ns 1.22μs 0 0 0 4.28 KB
#6499 EnrichedLog netcoreapp3.1 122μs 405ns 1.57μs 0 0 0 4.28 KB
#6499 EnrichedLog net472 150μs 155ns 602ns 0.678 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.01μs 1.69ns 6.31ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.18μs 3.35ns 13ns 0.0292 0 0 2.2 KB
master EnrichedLog net472 4.87μs 1.55ns 5.58ns 0.32 0 0 2.02 KB
#6499 EnrichedLog net6.0 3μs 1.18ns 4.58ns 0.0302 0 0 2.2 KB
#6499 EnrichedLog netcoreapp3.1 4.19μs 2.41ns 9.33ns 0.029 0 0 2.2 KB
#6499 EnrichedLog net472 4.76μs 1.62ns 6.26ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 1.97ns 7.62ns 0.0156 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 0.812ns 3.14ns 0.0159 0 0 1.14 KB
master SendReceive net472 2.12μs 1.56ns 6.03ns 0.183 0 0 1.16 KB
#6499 SendReceive net6.0 1.34μs 0.57ns 2.21ns 0.016 0 0 1.14 KB
#6499 SendReceive netcoreapp3.1 1.86μs 0.931ns 3.61ns 0.0158 0 0 1.14 KB
#6499 SendReceive net472 2.14μs 0.538ns 1.86ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.666ns 2.4ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 1.44ns 5.56ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.46μs 7.23ns 28ns 0.323 0 0 2.04 KB
#6499 EnrichedLog net6.0 2.72μs 1.16ns 4.35ns 0.0231 0 0 1.6 KB
#6499 EnrichedLog netcoreapp3.1 3.98μs 2.99ns 11.6ns 0.0223 0 0 1.65 KB
#6499 EnrichedLog net472 4.37μs 2.13ns 7.96ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 391ns 0.165ns 0.594ns 0.00809 0 0 576 B
master StartFinishSpan netcoreapp3.1 599ns 0.905ns 3.51ns 0.00774 0 0 576 B
master StartFinishSpan net472 697ns 0.592ns 2.29ns 0.0917 0 0 578 B
master StartFinishScope net6.0 520ns 0.267ns 1.04ns 0.00977 0 0 696 B
master StartFinishScope netcoreapp3.1 660ns 0.483ns 1.81ns 0.00929 0 0 696 B
master StartFinishScope net472 869ns 0.66ns 2.56ns 0.105 0 0 658 B
#6499 StartFinishSpan net6.0 406ns 0.242ns 0.939ns 0.00812 0 0 576 B
#6499 StartFinishSpan netcoreapp3.1 552ns 0.196ns 0.76ns 0.0077 0 0 576 B
#6499 StartFinishSpan net472 696ns 0.489ns 1.89ns 0.0915 0 0 578 B
#6499 StartFinishScope net6.0 489ns 0.62ns 2.4ns 0.00982 0 0 696 B
#6499 StartFinishScope netcoreapp3.1 696ns 0.551ns 2.14ns 0.00908 0 0 696 B
#6499 StartFinishScope net472 894ns 0.598ns 2.24ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 646ns 0.399ns 1.54ns 0.00981 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 954ns 0.985ns 3.82ns 0.00959 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.645ns 2.5ns 0.104 0 0 658 B
#6499 RunOnMethodBegin net6.0 637ns 0.446ns 1.61ns 0.00959 0 0 696 B
#6499 RunOnMethodBegin netcoreapp3.1 1μs 0.479ns 1.79ns 0.00911 0 0 696 B
#6499 RunOnMethodBegin net472 1.07μs 0.41ns 1.59ns 0.104 0 0 658 B

andrewlock
andrewlock approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, standard AWS version bump

@andrewlock andrewlock added area:tests unit tests, integration tests area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file area:dependabot dependabot updates labels Jan 6, 2025
@andrewlock andrewlock merged commit 94ff790 into master Jan 7, 2025
90 of 92 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch January 7, 2025 12:09
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock