[Test Package Versions Bump] Updating package versions #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 247689 Passed, 2149 Skipped, 18h 37m 55.15s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6519) - mean (69ms) : 65, 72
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6519) - mean (980ms) : 954, 1006
. : milestone, 980,
master - mean (981ms) : 954, 1008
. : milestone, 981,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6519) - mean (107ms) : 105, 110
. : milestone, 107,
master - mean (107ms) : 105, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6519) - mean (677ms) : 665, 690
. : milestone, 677,
master - mean (678ms) : 662, 695
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6519) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 90, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6519) - mean (635ms) : 621, 649
. : milestone, 635,
master - mean (633ms) : 616, 651
. : milestone, 633,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6519) - mean (194ms) : 190, 198
. : milestone, 194,
master - mean (195ms) : 189, 202
. : milestone, 195,
section CallTarget+Inlining+NGEN
This PR (6519) - mean (1,102ms) : 1075, 1129
. : milestone, 1102,
master - mean (1,104ms) : 1076, 1132
. : milestone, 1104,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6519) - mean (279ms) : 274, 283
. : milestone, 279,
master - mean (278ms) : 273, 282
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (6519) - mean (872ms) : 843, 901
. : milestone, 872,
master - mean (874ms) : 847, 901
. : milestone, 874,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6519) - mean (266ms) : 263, 270
. : milestone, 266,
master - mean (268ms) : 264, 272
. : milestone, 268,
section CallTarget+Inlining+NGEN
This PR (6519) - mean (854ms) : 816, 892
. : milestone, 854,
master - mean (857ms) : 829, 885
. : milestone, 857,
|
Benchmarks Report for tracer 🐌Benchmarks for #6519 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.164 | 732.44 | 629.35 | |
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.144 | 796.60 | 696.23 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 397ns | 0.636ns | 2.46ns | 0.00798 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 546ns | 0.881ns | 3.41ns | 0.00786 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 731ns | 2.25ns | 8.7ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 551ns | 1.01ns | 3.9ns | 0.00975 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 797ns | 1.39ns | 5.39ns | 0.0094 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 859ns | 0.867ns | 3.36ns | 0.104 | 0 | 0 | 658 B |
| #6519 | StartFinishSpan |
net6.0 | 405ns | 0.437ns | 1.69ns | 0.00809 | 0 | 0 | 576 B |
| #6519 | StartFinishSpan |
netcoreapp3.1 | 553ns | 0.764ns | 2.96ns | 0.00773 | 0 | 0 | 576 B |
| #6519 | StartFinishSpan |
net472 | 632ns | 1.08ns | 4.19ns | 0.0916 | 0 | 0 | 578 B |
| #6519 | StartFinishScope |
net6.0 | 502ns | 0.653ns | 2.53ns | 0.00967 | 0 | 0 | 696 B |
| #6519 | StartFinishScope |
netcoreapp3.1 | 698ns | 1.32ns | 5.13ns | 0.00947 | 0 | 0 | 696 B |
| #6519 | StartFinishScope |
net472 | 823ns | 1.25ns | 4.85ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 644ns | 1.2ns | 4.66ns | 0.00959 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 985ns | 3.19ns | 12.4ns | 0.00922 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.13μs | 1.45ns | 5.62ns | 0.105 | 0 | 0 | 658 B |
| #6519 | RunOnMethodBegin |
net6.0 | 613ns | 0.584ns | 2.26ns | 0.00975 | 0 | 0 | 696 B |
| #6519 | RunOnMethodBegin |
netcoreapp3.1 | 923ns | 1.57ns | 6.09ns | 0.00963 | 0 | 0 | 696 B |
| #6519 | RunOnMethodBegin |
net472 | 1.09μs | 1.66ns | 6.2ns | 0.104 | 0 | 0 | 658 B |
andrewlock
approved these changes
Jan 9, 2025
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6519) (11.131M) : 0, 11131390
master (11.079M) : 0, 11079429
benchmarks/2.9.0 (11.045M) : 0, 11045405
section Automatic
This PR (6519) (7.214M) : 0, 7214269
master (7.196M) : 0, 7196111
benchmarks/2.9.0 (7.885M) : 0, 7885346
section Trace stats
master (7.490M) : 0, 7489517
section Manual
master (11.074M) : 0, 11073999
section Manual + Automatic
This PR (6519) (6.699M) : 0, 6698689
master (6.696M) : 0, 6695951
section DD_TRACE_ENABLED=0
master (10.272M) : 0, 10272006
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6519) (9.743M) : 0, 9742519
benchmarks/2.9.0 (9.586M) : 0, 9586476
section Automatic
This PR (6519) (6.439M) : 0, 6439099
section Manual + Automatic
This PR (6519) (5.878M) : 0, 5877961
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6519) (10.151M) : 0, 10150615
master (10.073M) : 0, 10073011
section Automatic
This PR (6519) (6.744M) : 0, 6744234
master (6.508M) : 0, 6508031
section Trace stats
master (6.899M) : 0, 6898631
section Manual
master (10.075M) : 0, 10074906
section Manual + Automatic
This PR (6519) (6.277M) : 0, 6276715
master (6.260M) : 0, 6260325
section DD_TRACE_ENABLED=0
master (9.595M) : 0, 9595026
|
andrewlock
added
area:tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package versions for integration tests.