Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact ##vso in CI #6525

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Redact ##vso in CI #6525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tracer/test/Datadog.Trace.TestHelpers/CustomTestFramework.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,9 @@ protected override async Task<RunSummary> RunTestCaseAsync(IXunitTestCase testCa

if (testCase.TestMethodArguments != null)
{
parameters = string.Join(", ", testCase.TestMethodArguments.Select(a => a?.ToString() ?? "null"));
// We replace ##vso to avoid sending "commands" via the log output when we're testing CI Visibility stuff
// We should redact other CI's command prefixes as well in the future, but for now this is enough
parameters = string.Join(", ", testCase.TestMethodArguments.Select(a => a?.ToString()?.Replace("##vso", "#####") ?? "null"));
}

var test = $"{TestMethod.TestClass.Class.Name}.{TestMethod.Method.Name}({parameters})";
Expand Down
Loading