Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #6530

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[Test Package Versions Bump] Updating package versions #6530

merged 1 commit into from
Jan 13, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners January 12, 2025 00:25
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 12, 2025 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: fdc8731
Test service: dd-trace-dotnet

✅ 0 Failed, 241669 Passed, 2114 Skipped, 18h 43m 58.65s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6530) - mean (68ms)  : 65, 72
     .   : milestone, 68,
    master - mean (69ms)  : 65, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6530) - mean (979ms)  : 947, 1010
     .   : milestone, 979,
    master - mean (983ms)  : 955, 1012
     .   : milestone, 983,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6530) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6530) - mean (676ms)  : 660, 692
     .   : milestone, 676,
    master - mean (680ms)  : 657, 703
     .   : milestone, 680,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6530) - mean (91ms)  : 88, 93
     .   : milestone, 91,
    master - mean (91ms)  : 88, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6530) - mean (632ms)  : 615, 648
     .   : milestone, 632,
    master - mean (636ms)  : 619, 652
     .   : milestone, 636,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6530) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (194ms)  : 189, 199
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6530) - mean (1,103ms)  : 1071, 1135
     .   : milestone, 1103,
    master - mean (1,097ms)  : 1070, 1125
     .   : milestone, 1097,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6530) - mean (278ms)  : 272, 283
     .   : milestone, 278,
    master - mean (278ms)  : 273, 284
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6530) - mean (874ms)  : 843, 905
     .   : milestone, 874,
    master - mean (872ms)  : 845, 899
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6530) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (268ms)  : 263, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6530) - mean (849ms)  : 822, 875
     .   : milestone, 849,
    master - mean (854ms)  : 823, 886
     .   : milestone, 854,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6530 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.128
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.15μs 44.6ns 252ns 0.016 0.00799 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10μs 53ns 281ns 0.0202 0.0101 0 5.8 KB
master StartStopWithChild net472 16.4μs 33.7ns 126ns 1.04 0.306 0.0886 6.2 KB
#6530 StartStopWithChild net6.0 8.14μs 44.9ns 284ns 0.0159 0.00797 0 5.61 KB
#6530 StartStopWithChild netcoreapp3.1 10.1μs 54.4ns 313ns 0.0147 0.00982 0 5.81 KB
#6530 StartStopWithChild net472 16.2μs 29.9ns 112ns 1.03 0.308 0.0892 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 493μs 523ns 2.02μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 410ns 1.59μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 854μs 573ns 2.14μs 0.425 0 0 3.3 KB
#6530 WriteAndFlushEnrichedTraces net6.0 494μs 259ns 970ns 0 0 0 2.7 KB
#6530 WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 674ns 2.61μs 0 0 0 2.7 KB
#6530 WriteAndFlushEnrichedTraces net472 861μs 799ns 2.99μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 149μs 897ns 8.88μs 0.141 0 0 14.48 KB
master SendRequest netcoreapp3.1 171μs 1.21μs 11.9μs 0.16 0 0 17.27 KB
master SendRequest net472 0.00209ns 0.00104ns 0.00374ns 0 0 0 0 b
#6530 SendRequest net6.0 151μs 861ns 6.32μs 0.17 0 0 14.47 KB
#6530 SendRequest netcoreapp3.1 172μs 946ns 5.83μs 0.178 0 0 17.27 KB
#6530 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6530

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.96 KB 41.7 KB -251 B -0.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 565μs 2.88μs 15.5μs 0.553 0 0 41.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 675μs 2.86μs 9.9μs 0.336 0 0 41.96 KB
master WriteAndFlushEnrichedTraces net472 823μs 3.27μs 12.2μs 8.22 2.47 0.411 53.27 KB
#6530 WriteAndFlushEnrichedTraces net6.0 567μs 2.83μs 15.2μs 0.604 0 0 41.56 KB
#6530 WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 3.28μs 14.7μs 0.314 0 0 41.7 KB
#6530 WriteAndFlushEnrichedTraces net472 837μs 3.89μs 20.2μs 8.17 2.45 0.408 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 0.846ns 3.28ns 0.0148 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.03ns 3.99ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 1.77ns 6.87ns 0.157 0.00105 0 987 B
#6530 ExecuteNonQuery net6.0 1.34μs 1.46ns 5.67ns 0.0147 0 0 1.02 KB
#6530 ExecuteNonQuery netcoreapp3.1 1.82μs 1.6ns 6.21ns 0.0136 0 0 1.02 KB
#6530 ExecuteNonQuery net472 2μs 2.04ns 7.88ns 0.156 0.000996 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6530

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.128 1,236.39 1,394.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 0.926ns 3.47ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 0.655ns 2.54ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.71μs 0.92ns 3.44ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.24μs 0.476ns 1.78ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.48ns 1.66ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 1.11ns 4.14ns 0.166 0 0 1.05 KB
#6530 CallElasticsearch net6.0 1.24μs 0.614ns 2.38ns 0.0139 0 0 976 B
#6530 CallElasticsearch netcoreapp3.1 1.56μs 0.904ns 3.38ns 0.0134 0 0 976 B
#6530 CallElasticsearch net472 2.5μs 1.11ns 4ns 0.158 0 0 995 B
#6530 CallElasticsearchAsync net6.0 1.39μs 0.447ns 1.67ns 0.0132 0 0 952 B
#6530 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.62ns 2.23ns 0.0138 0 0 1.02 KB
#6530 CallElasticsearchAsync net472 2.56μs 1.62ns 6.27ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.809ns 3.03ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 1.04ns 3.74ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.78μs 0.487ns 1.76ns 0.145 0 0 915 B
#6530 ExecuteAsync net6.0 1.3μs 0.526ns 1.97ns 0.013 0 0 952 B
#6530 ExecuteAsync netcoreapp3.1 1.63μs 0.525ns 1.96ns 0.013 0 0 952 B
#6530 ExecuteAsync net472 1.82μs 0.654ns 2.45ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.49μs 3.28ns 12.7ns 0.0314 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.32μs 2.52ns 9.75ns 0.0371 0 0 2.85 KB
master SendAsync net472 7.44μs 2.13ns 8.23ns 0.493 0 0 3.12 KB
#6530 SendAsync net6.0 4.44μs 1.61ns 6.25ns 0.0312 0 0 2.31 KB
#6530 SendAsync netcoreapp3.1 5.36μs 1.33ns 5.16ns 0.0375 0 0 2.85 KB
#6530 SendAsync net472 7.39μs 1.79ns 6.94ns 0.496 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 1.48ns 5.74ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.13μs 0.939ns 3.51ns 0.0223 0 0 1.64 KB
master EnrichedLog net472 2.69μs 1.74ns 6.74ns 0.249 0 0 1.57 KB
#6530 EnrichedLog net6.0 1.48μs 0.585ns 2.19ns 0.0229 0 0 1.64 KB
#6530 EnrichedLog netcoreapp3.1 2.22μs 1ns 3.74ns 0.0222 0 0 1.64 KB
#6530 EnrichedLog net472 2.65μs 1.03ns 4ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 172ns 643ns 0.0579 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 130ns 503ns 0 0 0 4.28 KB
master EnrichedLog net472 154μs 100ns 388ns 0.688 0.229 0 4.46 KB
#6530 EnrichedLog net6.0 120μs 151ns 584ns 0 0 0 4.28 KB
#6530 EnrichedLog netcoreapp3.1 124μs 250ns 969ns 0 0 0 4.28 KB
#6530 EnrichedLog net472 154μs 189ns 681ns 0.692 0.231 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.1μs 0.92ns 3.56ns 0.0297 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.15μs 1.18ns 4.41ns 0.0291 0 0 2.2 KB
master EnrichedLog net472 4.77μs 1.02ns 3.68ns 0.32 0 0 2.02 KB
#6530 EnrichedLog net6.0 3.03μs 1.2ns 4.49ns 0.0303 0 0 2.2 KB
#6530 EnrichedLog netcoreapp3.1 4.32μs 2.48ns 9.6ns 0.0302 0 0 2.2 KB
#6530 EnrichedLog net472 4.86μs 1.05ns 3.92ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 0.901ns 3.25ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.74μs 0.847ns 3.17ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.22μs 4.66ns 18ns 0.183 0 0 1.16 KB
#6530 SendReceive net6.0 1.4μs 0.495ns 1.85ns 0.0161 0 0 1.14 KB
#6530 SendReceive netcoreapp3.1 1.76μs 0.888ns 3.44ns 0.015 0 0 1.14 KB
#6530 SendReceive net472 2.14μs 1.45ns 5.61ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.684ns 2.65ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.08μs 1.7ns 6.59ns 0.0224 0 0 1.65 KB
master EnrichedLog net472 4.26μs 1.76ns 6.6ns 0.322 0 0 2.04 KB
#6530 EnrichedLog net6.0 2.72μs 1.12ns 4.35ns 0.0217 0 0 1.6 KB
#6530 EnrichedLog netcoreapp3.1 3.94μs 1.49ns 5.78ns 0.0216 0 0 1.65 KB
#6530 EnrichedLog net472 4.31μs 1.7ns 6.34ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 409ns 0.112ns 0.419ns 0.00808 0 0 576 B
master StartFinishSpan netcoreapp3.1 566ns 1.13ns 4.39ns 0.00785 0 0 576 B
master StartFinishSpan net472 642ns 0.148ns 0.574ns 0.0918 0 0 578 B
master StartFinishScope net6.0 533ns 0.3ns 1.16ns 0.00964 0 0 696 B
master StartFinishScope netcoreapp3.1 725ns 0.289ns 1.12ns 0.00921 0 0 696 B
master StartFinishScope net472 799ns 0.231ns 0.866ns 0.104 0 0 658 B
#6530 StartFinishSpan net6.0 404ns 0.53ns 2.05ns 0.00807 0 0 576 B
#6530 StartFinishSpan netcoreapp3.1 587ns 0.661ns 2.47ns 0.00787 0 0 576 B
#6530 StartFinishSpan net472 706ns 0.48ns 1.8ns 0.0918 0 0 578 B
#6530 StartFinishScope net6.0 550ns 0.466ns 1.74ns 0.00964 0 0 696 B
#6530 StartFinishScope netcoreapp3.1 789ns 0.796ns 2.98ns 0.0093 0 0 696 B
#6530 StartFinishScope net472 844ns 0.975ns 3.77ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 592ns 0.278ns 1.04ns 0.00971 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 934ns 0.628ns 2.43ns 0.00937 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.406ns 1.57ns 0.104 0 0 658 B
#6530 RunOnMethodBegin net6.0 635ns 0.51ns 1.91ns 0.00958 0 0 696 B
#6530 RunOnMethodBegin netcoreapp3.1 899ns 0.906ns 3.51ns 0.00945 0 0 696 B
#6530 RunOnMethodBegin net472 1.08μs 0.424ns 1.59ns 0.104 0 0 658 B

@andrewlock andrewlock merged commit f444a47 into master Jan 13, 2025
110 of 113 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch January 13, 2025 09:56
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 13, 2025
@andrewlock andrewlock added area:tests unit tests, integration tests area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file area:dependabot dependabot updates labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock