Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Visibility] Disable ImpactedTests flaky test #6616

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[CI Visibility] Disable ImpactedTests flaky test #6616

merged 1 commit into from
Feb 3, 2025

Conversation

daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Feb 3, 2025 •
edited
Loading

Summary of changes

This PR disables a test failing in Alpine due to a Detached Head status. We are working in a way to handle this situation.

Reason for change

Test failing in Alpine

Implementation details

Test coverage

Other details

@daniel-romano-DD daniel-romano-DD added area:tests unit tests, integration tests area:ci-visibility labels Feb 3, 2025
@daniel-romano-DD daniel-romano-DD requested review from a team as code owners February 3, 2025 10:21
andrewlock
andrewlock approved these changes Feb 3, 2025
View reviewed changes
tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/CI/XUnitImpactedTests.cs
@@ -86,6 +86,8 @@ public Task DisabledByEnvVar(string packageVersion)
[Trait("Category", "TestIntegrations")]
public Task EnabledBySettings(string packageVersion)
{
Skip.If(EnvironmentHelper.IsAlpine(), "This test is currently flaky in alpine due to a Detached Head status. An issue has been opened to handle the situation. Meanwhile we are skipping it.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify it only seems to happen on arm64 too. Which is... weird... but this covers it so for now: 😄 :shipit:

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Feb 3, 2025 •
edited
Loading

Datadog Report

Branch report: dani/testvis/skip_alpine_flaky_test
Commit report: 1808845
Test service: dd-trace-dotnet

❌ 2 Failed (0 Known Flaky), 247189 Passed, 2401 Skipped, 18h 34m 10.46s Total Time

❌ Failed Tests (2)

  • Baseline - Samples.HttpMessageHandler.windows.net80.json.scenarios - Details

    Expand for error 
     
 <null>rd Output: tnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=win-x64&os=win10

  • CallTarget+Inlining+NGEN - Samples.HttpMessageHandler.windows.net80.json.scenarios - Details

    Expand for error 
     
 <null>rd Output: tnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=win-x64&os=win10

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6616 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.170
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.29μs 61.3ns 584ns 0.0163 0.00816 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.91μs 55.4ns 342ns 0.0149 0.00498 0 5.8 KB
master StartStopWithChild net472 16.2μs 41.6ns 161ns 1.03 0.287 0.0877 6.21 KB
#6616 StartStopWithChild net6.0 7.76μs 42.8ns 303ns 0.0161 0.00403 0 5.62 KB
#6616 StartStopWithChild netcoreapp3.1 10.2μs 56.5ns 362ns 0.0248 0.00992 0 5.8 KB
#6616 StartStopWithChild net472 16.2μs 75.8ns 303ns 1.04 0.315 0.105 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 484μs 157ns 587ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 333ns 1.29μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 859μs 629ns 2.27μs 0.425 0 0 3.3 KB
#6616 WriteAndFlushEnrichedTraces net6.0 482μs 1.16μs 4.35μs 0 0 0 2.7 KB
#6616 WriteAndFlushEnrichedTraces netcoreapp3.1 704μs 308ns 1.11μs 0 0 0 2.7 KB
#6616 WriteAndFlushEnrichedTraces net472 858μs 688ns 2.67μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 127μs 551ns 2.14μs 0.193 0 0 14.47 KB
master SendRequest netcoreapp3.1 145μs 308ns 1.19μs 0.147 0 0 17.27 KB
master SendRequest net472 0.0107ns 0.0026ns 0.0101ns 0 0 0 0 b
#6616 SendRequest net6.0 129μs 406ns 1.57μs 0.194 0 0 14.47 KB
#6616 SendRequest netcoreapp3.1 142μs 609ns 2.36μs 0.209 0 0 17.27 KB
#6616 SendRequest net472 0.00755ns 0.00292ns 0.0113ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6616

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.48 KB 41.8 KB 316 B 0.76%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 554μs 1.99μs 7.72μs 0.548 0 0 41.48 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 2.77μs 10.4μs 0.319 0 0 41.65 KB
master WriteAndFlushEnrichedTraces net472 873μs 2.61μs 9.78μs 8.13 2.57 0.428 53.31 KB
#6616 WriteAndFlushEnrichedTraces net6.0 579μs 2.95μs 14.2μs 0.563 0 0 41.8 KB
#6616 WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 2.6μs 9.71μs 0.321 0 0 41.64 KB
#6616 WriteAndFlushEnrichedTraces net472 840μs 4.34μs 20.8μs 8.45 2.53 0.422 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.26μs 1.16ns 4.51ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.02ns 3.82ns 0.013 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 1.62ns 6.06ns 0.156 0.00106 0 987 B
#6616 ExecuteNonQuery net6.0 1.34μs 1.16ns 4.33ns 0.0143 0 0 1.02 KB
#6616 ExecuteNonQuery netcoreapp3.1 1.77μs 1.47ns 5.71ns 0.0134 0 0 1.02 KB
#6616 ExecuteNonQuery net472 2.08μs 5.01ns 19.4ns 0.156 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 0.506ns 1.83ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.49μs 1.32ns 5.12ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.57μs 2.55ns 9.87ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.31μs 0.731ns 2.83ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.653ns 2.44ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.7μs 1.36ns 5.26ns 0.167 0 0 1.05 KB
#6616 CallElasticsearch net6.0 1.24μs 0.308ns 1.15ns 0.014 0 0 976 B
#6616 CallElasticsearch netcoreapp3.1 1.64μs 0.655ns 2.45ns 0.0131 0 0 976 B
#6616 CallElasticsearch net472 2.58μs 2.4ns 9.28ns 0.158 0 0 995 B
#6616 CallElasticsearchAsync net6.0 1.29μs 0.541ns 2.1ns 0.0129 0 0 952 B
#6616 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.765ns 2.86ns 0.0134 0 0 1.02 KB
#6616 CallElasticsearchAsync net472 2.62μs 2.16ns 8.07ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6616

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.183 1,190.80 1,408.69

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.19μs 0.34ns 1.27ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.58μs 0.64ns 2.48ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.85μs 0.43ns 1.61ns 0.145 0 0 915 B
#6616 ExecuteAsync net6.0 1.41μs 1.65ns 6.39ns 0.0134 0 0 952 B
#6616 ExecuteAsync netcoreapp3.1 1.64μs 1.21ns 4.7ns 0.0123 0 0 952 B
#6616 ExecuteAsync net472 1.89μs 0.507ns 1.96ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.26μs 0.821ns 2.84ns 0.032 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.32μs 5.84ns 22.6ns 0.0373 0 0 2.85 KB
master SendAsync net472 7.46μs 1.53ns 5.94ns 0.496 0 0 3.12 KB
#6616 SendAsync net6.0 4.25μs 1.23ns 4.6ns 0.0318 0 0 2.31 KB
#6616 SendAsync netcoreapp3.1 5.27μs 2.39ns 9.24ns 0.0395 0 0 2.85 KB
#6616 SendAsync net472 7.31μs 1.74ns 6.74ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.769ns 2.98ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.07μs 1.52ns 5.89ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.42μs 0.75ns 2.81ns 0.249 0 0 1.57 KB
#6616 EnrichedLog net6.0 1.46μs 0.954ns 3.69ns 0.0227 0 0 1.64 KB
#6616 EnrichedLog netcoreapp3.1 2.27μs 1.23ns 4.76ns 0.0216 0 0 1.64 KB
#6616 EnrichedLog net472 2.54μs 1.15ns 4.46ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 49.4ns 178ns 0.0566 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 116μs 143ns 553ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 159ns 616ns 0.672 0.224 0 4.46 KB
#6616 EnrichedLog net6.0 112μs 138ns 535ns 0.056 0 0 4.28 KB
#6616 EnrichedLog netcoreapp3.1 117μs 153ns 594ns 0.0583 0 0 4.28 KB
#6616 EnrichedLog net472 151μs 122ns 474ns 0.676 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 1.02ns 3.93ns 0.0304 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.23μs 1.11ns 4.29ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 5.04μs 2.04ns 7.9ns 0.32 0 0 2.02 KB
#6616 EnrichedLog net6.0 3.03μs 0.963ns 3.6ns 0.0303 0 0 2.2 KB
#6616 EnrichedLog netcoreapp3.1 4.03μs 1.2ns 4.31ns 0.0283 0 0 2.2 KB
#6616 EnrichedLog net472 4.82μs 1.89ns 7.06ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 0.493ns 1.91ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 0.966ns 3.74ns 0.015 0 0 1.14 KB
master SendReceive net472 2.13μs 2.1ns 7.88ns 0.183 0 0 1.16 KB
#6616 SendReceive net6.0 1.46μs 1.17ns 4.37ns 0.0159 0 0 1.14 KB
#6616 SendReceive netcoreapp3.1 1.87μs 0.628ns 2.43ns 0.015 0 0 1.14 KB
#6616 SendReceive net472 2.07μs 1.39ns 5.2ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 0.867ns 3.36ns 0.0228 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 2.27ns 8.81ns 0.0215 0 0 1.65 KB
master EnrichedLog net472 4.35μs 3.72ns 14.4ns 0.322 0 0 2.04 KB
#6616 EnrichedLog net6.0 2.83μs 1.27ns 4.74ns 0.0213 0 0 1.6 KB
#6616 EnrichedLog netcoreapp3.1 3.9μs 14.1ns 54.8ns 0.0227 0 0 1.65 KB
#6616 EnrichedLog net472 4.29μs 3.61ns 14ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6616

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.157 712.74 824.59

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 393ns 0.822ns 3.18ns 0.00811 0 0 576 B
master StartFinishSpan netcoreapp3.1 557ns 0.987ns 3.82ns 0.00778 0 0 576 B
master StartFinishSpan net472 596ns 1.03ns 3.99ns 0.0916 0 0 578 B
master StartFinishScope net6.0 488ns 0.575ns 2.23ns 0.00984 0 0 696 B
master StartFinishScope netcoreapp3.1 712ns 1.03ns 4ns 0.00958 0 0 696 B
master StartFinishScope net472 864ns 2.22ns 8.59ns 0.104 0 0 658 B
#6616 StartFinishSpan net6.0 425ns 0.469ns 1.76ns 0.00815 0 0 576 B
#6616 StartFinishSpan netcoreapp3.1 547ns 0.968ns 3.75ns 0.00765 0 0 576 B
#6616 StartFinishSpan net472 642ns 1.29ns 5.01ns 0.0916 0 0 578 B
#6616 StartFinishScope net6.0 486ns 0.623ns 2.41ns 0.00982 0 0 696 B
#6616 StartFinishScope netcoreapp3.1 824ns 0.468ns 1.75ns 0.00936 0 0 696 B
#6616 StartFinishScope net472 823ns 1.33ns 5.14ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 649ns 0.948ns 3.67ns 0.00979 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 926ns 1.74ns 6.76ns 0.00968 0 0 696 B
master RunOnMethodBegin net472 1.06μs 2.02ns 7.83ns 0.104 0 0 658 B
#6616 RunOnMethodBegin net6.0 618ns 0.694ns 2.69ns 0.00983 0 0 696 B
#6616 RunOnMethodBegin netcoreapp3.1 880ns 1.49ns 5.77ns 0.00939 0 0 696 B
#6616 RunOnMethodBegin net472 1.12μs 0.949ns 3.68ns 0.104 0 0 658 B

@daniel-romano-DD daniel-romano-DD merged commit 1748679 into master Feb 3, 2025
136 of 139 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/testvis/skip_alpine_flaky_test branch February 3, 2025 15:33
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:ci-visibility area:tests unit tests, integration tests
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-romano-DD @andrewlock @tonyredondo