Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6641

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 9, 2025

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners February 9, 2025 00:25
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Feb 9, 2025

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: ae59568
Test service: dd-trace-dotnet

✅ 0 Failed, 249480 Passed, 2406 Skipped, 17h 54m 38.48s Total Time

@andrewlock
Copy link
Member

andrewlock commented Feb 9, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6641) - mean (69ms)  : 67, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6641) - mean (995ms)  : 970, 1021
     .   : milestone, 995,
    master - mean (993ms)  : 972, 1013
     .   : milestone, 993,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6641) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6641) - mean (673ms)  : 660, 686
     .   : milestone, 673,
    master - mean (677ms)  : 662, 692
     .   : milestone, 677,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6641) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6641) - mean (632ms)  : 616, 648
     .   : milestone, 632,
    master - mean (629ms)  : 613, 646
     .   : milestone, 629,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6641) - mean (191ms)  : 186, 195
     .   : milestone, 191,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6641) - mean (1,101ms)  : 1067, 1135
     .   : milestone, 1101,
    master - mean (1,103ms)  : 1075, 1131
     .   : milestone, 1103,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6641) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (270ms)  : 266, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (6641) - mean (866ms)  : 831, 901
     .   : milestone, 866,
    master - mean (860ms)  : 835, 885
     .   : milestone, 860,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6641) - mean (261ms)  : 257, 264
     .   : milestone, 261,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6641) - mean (847ms)  : 814, 881
     .   : milestone, 847,
    master - mean (841ms)  : 814, 868
     .   : milestone, 841,

Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6641 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.163
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.9μs 41.1ns 240ns 0.0163 0.00816 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.3μs 57.4ns 363ns 0.0243 0.00974 0 5.8 KB
master StartStopWithChild net472 16.1μs 66.9ns 259ns 1.03 0.296 0.0961 6.21 KB
#6641 StartStopWithChild net6.0 7.9μs 44.2ns 297ns 0.0151 0.00754 0 5.61 KB
#6641 StartStopWithChild netcoreapp3.1 9.88μs 55.2ns 379ns 0.0186 0.0093 0 5.8 KB
#6641 StartStopWithChild net472 16.1μs 63.6ns 246ns 1.05 0.299 0.102 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 474μs 279ns 1.01μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 312ns 1.08μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 844μs 500ns 1.94μs 0.417 0 0 3.3 KB
#6641 WriteAndFlushEnrichedTraces net6.0 499μs 646ns 2.42μs 0 0 0 2.7 KB
#6641 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 383ns 1.38μs 0 0 0 2.7 KB
#6641 WriteAndFlushEnrichedTraces net472 855μs 494ns 1.91μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 370ns 1.43μs 0.189 0 0 14.47 KB
master SendRequest netcoreapp3.1 146μs 435ns 1.68μs 0.22 0 0 17.27 KB
master SendRequest net472 0.0107ns 0.0028ns 0.0105ns 0 0 0 0 b
#6641 SendRequest net6.0 126μs 435ns 1.68μs 0.186 0 0 14.47 KB
#6641 SendRequest netcoreapp3.1 143μs 419ns 1.62μs 0.212 0 0 17.27 KB
#6641 SendRequest net472 0.00257ns 0.00126ns 0.00487ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 593μs 3.05μs 14.6μs 0.561 0 0 41.78 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 705μs 3.62μs 16.2μs 0.349 0 0 41.71 KB
master WriteAndFlushEnrichedTraces net472 845μs 4.09μs 16.4μs 8.08 2.55 0.425 53.35 KB
#6641 WriteAndFlushEnrichedTraces net6.0 567μs 1.61μs 5.57μs 0.553 0 0 41.67 KB
#6641 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 3.4μs 17.7μs 0.319 0 0 41.71 KB
#6641 WriteAndFlushEnrichedTraces net472 826μs 3.16μs 12.2μs 8.33 2.5 0.417 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.31μs 1.28ns 4.79ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.86μs 1.83ns 7.09ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.08μs 2.42ns 9.36ns 0.156 0.00104 0 987 B
#6641 ExecuteNonQuery net6.0 1.32μs 0.997ns 3.59ns 0.0139 0 0 1.02 KB
#6641 ExecuteNonQuery netcoreapp3.1 1.82μs 1.55ns 5.81ns 0.0138 0 0 1.02 KB
#6641 ExecuteNonQuery net472 2.08μs 2.19ns 8.48ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 0.417ns 1.56ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.52μs 1.55ns 5.79ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.58μs 1.95ns 7.55ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.29μs 0.495ns 1.92ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.459ns 1.72ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.67μs 1.38ns 5.18ns 0.166 0 0 1.05 KB
#6641 CallElasticsearch net6.0 1.3μs 0.467ns 1.75ns 0.0137 0 0 976 B
#6641 CallElasticsearch netcoreapp3.1 1.55μs 2.08ns 7.79ns 0.0131 0 0 976 B
#6641 CallElasticsearch net472 2.68μs 2.15ns 8.31ns 0.157 0 0 995 B
#6641 CallElasticsearchAsync net6.0 1.28μs 0.86ns 3.22ns 0.0135 0 0 952 B
#6641 CallElasticsearchAsync netcoreapp3.1 1.59μs 0.82ns 3.07ns 0.0137 0 0 1.02 KB
#6641 CallElasticsearchAsync net472 2.66μs 1.42ns 5.51ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.26μs 0.604ns 2.26ns 0.0137 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.69μs 2.27ns 8.79ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.85μs 0.693ns 2.68ns 0.145 0 0 915 B
#6641 ExecuteAsync net6.0 1.37μs 0.698ns 2.7ns 0.013 0 0 952 B
#6641 ExecuteAsync netcoreapp3.1 1.6μs 0.63ns 2.44ns 0.0128 0 0 952 B
#6641 ExecuteAsync net472 1.86μs 0.499ns 1.93ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.37μs 1.66ns 6ns 0.0326 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.2μs 2.2ns 8.53ns 0.0391 0 0 2.85 KB
master SendAsync net472 7.33μs 1.93ns 7.49ns 0.493 0 0 3.12 KB
#6641 SendAsync net6.0 4.6μs 2.13ns 7.96ns 0.0323 0 0 2.31 KB
#6641 SendAsync netcoreapp3.1 5.16μs 1.91ns 7.39ns 0.0365 0 0 2.85 KB
#6641 SendAsync net472 7.4μs 2.08ns 8.04ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 1.18ns 4.42ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.2μs 1.99ns 7.46ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.53μs 0.701ns 2.53ns 0.249 0 0 1.57 KB
#6641 EnrichedLog net6.0 1.63μs 1.46ns 5.67ns 0.0229 0 0 1.64 KB
#6641 EnrichedLog netcoreapp3.1 2.22μs 2.31ns 8.64ns 0.022 0 0 1.64 KB
#6641 EnrichedLog net472 2.47μs 1.19ns 4.63ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 100ns 374ns 0.0563 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 123ns 461ns 0.0582 0 0 4.28 KB
master EnrichedLog net472 151μs 89.1ns 321ns 0.68 0.227 0 4.46 KB
#6641 EnrichedLog net6.0 113μs 91.3ns 353ns 0.0562 0 0 4.28 KB
#6641 EnrichedLog netcoreapp3.1 117μs 215ns 832ns 0 0 0 4.28 KB
#6641 EnrichedLog net472 150μs 79.7ns 309ns 0.677 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.97μs 1.26ns 4.89ns 0.0312 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.22μs 3.35ns 13ns 0.0295 0 0 2.2 KB
master EnrichedLog net472 4.94μs 11ns 42.5ns 0.319 0 0 2.02 KB
#6641 EnrichedLog net6.0 2.96μs 1.74ns 6.72ns 0.0311 0 0 2.2 KB
#6641 EnrichedLog netcoreapp3.1 4.25μs 1.73ns 6.7ns 0.0297 0 0 2.2 KB
#6641 EnrichedLog net472 4.67μs 1.15ns 3.99ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.32μs 0.814ns 3.15ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.74μs 0.51ns 1.91ns 0.015 0 0 1.14 KB
master SendReceive net472 2.11μs 1.07ns 4.15ns 0.183 0 0 1.16 KB
#6641 SendReceive net6.0 1.38μs 2.68ns 10.4ns 0.0161 0 0 1.14 KB
#6641 SendReceive netcoreapp3.1 1.76μs 0.869ns 3.25ns 0.0151 0 0 1.14 KB
#6641 SendReceive net472 2.12μs 0.406ns 1.57ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.84ns 3.25ns 0.0222 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.89μs 1.64ns 6.37ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.35μs 3.41ns 13.2ns 0.323 0 0 2.04 KB
#6641 EnrichedLog net6.0 2.7μs 0.946ns 3.66ns 0.0216 0 0 1.6 KB
#6641 EnrichedLog netcoreapp3.1 3.84μs 1.96ns 7.59ns 0.021 0 0 1.65 KB
#6641 EnrichedLog net472 4.39μs 1.27ns 4.75ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6641

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.163 486.23 565.68

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 409ns 0.585ns 2.27ns 0.00808 0 0 576 B
master StartFinishSpan netcoreapp3.1 582ns 0.539ns 2.02ns 0.00758 0 0 576 B
master StartFinishSpan net472 581ns 1.38ns 5.33ns 0.0917 0 0 578 B
master StartFinishScope net6.0 487ns 1.2ns 4.63ns 0.00974 0 0 696 B
master StartFinishScope netcoreapp3.1 695ns 0.995ns 3.85ns 0.00946 0 0 696 B
master StartFinishScope net472 853ns 1.5ns 5.8ns 0.105 0 0 658 B
#6641 StartFinishSpan net6.0 412ns 1.31ns 5.08ns 0.00803 0 0 576 B
#6641 StartFinishSpan netcoreapp3.1 552ns 1.22ns 4.38ns 0.00784 0 0 576 B
#6641 StartFinishSpan net472 578ns 1.37ns 5.32ns 0.0916 0 0 578 B
#6641 StartFinishScope net6.0 565ns 0.815ns 3.16ns 0.00982 0 0 696 B
#6641 StartFinishScope netcoreapp3.1 653ns 1.11ns 4.28ns 0.00924 0 0 696 B
#6641 StartFinishScope net472 851ns 2.48ns 9.59ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 664ns 0.983ns 3.81ns 0.00965 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 928ns 1.93ns 7.49ns 0.00924 0 0 696 B
master RunOnMethodBegin net472 1.12μs 3.51ns 13.6ns 0.105 0 0 658 B
#6641 RunOnMethodBegin net6.0 688ns 1.04ns 4.01ns 0.00965 0 0 696 B
#6641 RunOnMethodBegin netcoreapp3.1 955ns 1.42ns 5.5ns 0.00901 0 0 696 B
#6641 RunOnMethodBegin net472 1.03μs 2.28ns 8.81ns 0.104 0 0 658 B

@andrewlock andrewlock force-pushed the bot/test-package-versions-bump branch from de900ff to 107b233 Compare February 10, 2025 11:49
@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 107b233 to ae59568 Compare February 10, 2025 12:37
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New major for HotChocolate.AspNetCore

@@ -95,7 +95,7 @@

<!-- Integration: HotChocolate.Execution -->
<!-- Assembly: HotChocolate.Execution -->
<!-- Latest package https://www.nuget.org/packages/HotChocolate.AspNetCore/15.0.1 -->
<!-- Latest package https://www.nuget.org/packages/HotChocolate.AspNetCore/15.0.3 -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new major last week

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewlock andrewlock merged commit a0f581e into master Feb 10, 2025
123 of 128 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch February 10, 2025 14:40
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 10, 2025
@andrewlock andrewlock added area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file area:dependabot dependabot updates labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants