Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet Installer] Don't block uninstall if IIS isn't available #6676

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[Fleet Installer] Don't block uninstall if IIS isn't available #6676

merged 1 commit into from
Feb 18, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

If IIS is uninstalled before you run the uninstall-product command, don't fail the uninstall.

Reason for change

It's a niche issue. We block install if IIS isn't available or is <10.0, but we currently also block the uninstall. This PR makes it so that if the customer uninstalls IIS after installing the product, we don't block the uninstall

Implementation details

If they uninstalled IIS, there's not really anything to uninstall, as this stage just removes the env vars from the apps (which isn't possible once IIS is uninstalled). So basically just move the check from being a global check to an install-only check.

Test coverage

:shhh:

@andrewlock andrewlock requested a review from a team as a code owner February 17, 2025 16:13
@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6676) - mean (69ms)  : 65, 74
     .   : milestone, 69,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6676) - mean (998ms)  : 979, 1017
     .   : milestone, 998,
    master - mean (998ms)  : 974, 1023
     .   : milestone, 998,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6676) - mean (102ms)  : 101, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6676) - mean (678ms)  : 656, 700
     .   : milestone, 678,
    master - mean (677ms)  : 644, 709
     .   : milestone, 677,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6676) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6676) - mean (634ms)  : 617, 651
     .   : milestone, 634,
    master - mean (633ms)  : 614, 652
     .   : milestone, 633,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6676) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6676) - mean (1,112ms)  : 1084, 1139
     .   : milestone, 1112,
    master - mean (1,112ms)  : 1078, 1145
     .   : milestone, 1112,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6676) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (273ms)  : 267, 280
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (6676) - mean (870ms)  : 837, 904
     .   : milestone, 870,
    master - mean (866ms)  : 838, 894
     .   : milestone, 866,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6676) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (263ms)  : 259, 268
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6676) - mean (851ms)  : 817, 886
     .   : milestone, 851,
    master - mean (850ms)  : 820, 880
     .   : milestone, 850,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6676 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.171
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.95μs 45.5ns 341ns 0.0115 0.00384 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 53.2ns 287ns 0.0202 0.0101 0 5.8 KB
master StartStopWithChild net472 16μs 32.7ns 123ns 1.05 0.327 0.0958 6.2 KB
#6676 StartStopWithChild net6.0 7.76μs 44.1ns 315ns 0.0161 0.00806 0 5.61 KB
#6676 StartStopWithChild netcoreapp3.1 9.76μs 54.7ns 359ns 0.0195 0.00487 0 5.8 KB
#6676 StartStopWithChild net472 16μs 56ns 217ns 1.03 0.293 0.095 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 491μs 357ns 1.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 518ns 1.94μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 842μs 787ns 3.05μs 0.419 0 0 3.3 KB
#6676 WriteAndFlushEnrichedTraces net6.0 483μs 487ns 1.88μs 0 0 0 2.7 KB
#6676 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 301ns 1.13μs 0 0 0 2.7 KB
#6676 WriteAndFlushEnrichedTraces net472 852μs 716ns 2.77μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 423ns 1.64μs 0.13 0 0 14.47 KB
master SendRequest netcoreapp3.1 142μs 616ns 2.39μs 0.215 0 0 17.27 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6676 SendRequest net6.0 130μs 294ns 1.14μs 0.129 0 0 14.47 KB
#6676 SendRequest netcoreapp3.1 146μs 230ns 890ns 0.219 0 0 17.27 KB
#6676 SendRequest net472 0.000587ns 0.000347ns 0.0013ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 572μs 3.11μs 17.3μs 0.598 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 696μs 3.96μs 27.5μs 0.365 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 857μs 3.53μs 13.7μs 8.28 2.48 0.414 53.29 KB
#6676 WriteAndFlushEnrichedTraces net6.0 585μs 3.14μs 16μs 0.573 0 0 41.7 KB
#6676 WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 3.47μs 17.4μs 0.319 0 0 41.75 KB
#6676 WriteAndFlushEnrichedTraces net472 858μs 3.95μs 15.3μs 8.25 2.6 0.434 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.39μs 1.66ns 6.2ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.74μs 1.29ns 4.84ns 0.0131 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 2.51ns 9.38ns 0.156 0.00102 0 987 B
#6676 ExecuteNonQuery net6.0 1.32μs 1.91ns 7.41ns 0.0145 0 0 1.02 KB
#6676 ExecuteNonQuery netcoreapp3.1 1.73μs 0.636ns 2.46ns 0.0139 0 0 1.02 KB
#6676 ExecuteNonQuery net472 2.14μs 3.94ns 15.3ns 0.157 0.00107 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.13μs 1.29ns 4.99ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.48μs 0.627ns 2.43ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.63μs 13.1ns 54.1ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.85ns 3.29ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 1.6ns 6.21ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.71μs 4.08ns 15.8ns 0.167 0 0 1.05 KB
#6676 CallElasticsearch net6.0 1.2μs 0.456ns 1.71ns 0.0132 0 0 976 B
#6676 CallElasticsearch netcoreapp3.1 1.56μs 0.728ns 2.72ns 0.0132 0 0 976 B
#6676 CallElasticsearch net472 2.55μs 1.11ns 4.16ns 0.158 0 0 995 B
#6676 CallElasticsearchAsync net6.0 1.23μs 0.397ns 1.49ns 0.0135 0 0 952 B
#6676 CallElasticsearchAsync netcoreapp3.1 1.59μs 1.04ns 3.77ns 0.0135 0 0 1.02 KB
#6676 CallElasticsearchAsync net472 2.66μs 1.94ns 7.51ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 0.978ns 3.79ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 0.679ns 2.63ns 0.013 0 0 952 B
master ExecuteAsync net472 1.9μs 0.88ns 3.41ns 0.144 0 0 915 B
#6676 ExecuteAsync net6.0 1.32μs 0.898ns 3.36ns 0.0132 0 0 952 B
#6676 ExecuteAsync netcoreapp3.1 1.61μs 3.65ns 13.7ns 0.0126 0 0 952 B
#6676 ExecuteAsync net472 1.83μs 0.609ns 2.36ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.47μs 1.75ns 6.3ns 0.032 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.43μs 2.37ns 8.86ns 0.0382 0 0 2.85 KB
master SendAsync net472 7.43μs 2.68ns 10.4ns 0.493 0 0 3.12 KB
#6676 SendAsync net6.0 4.31μs 1.7ns 6.37ns 0.032 0 0 2.31 KB
#6676 SendAsync netcoreapp3.1 5.31μs 1.51ns 5.83ns 0.037 0 0 2.85 KB
#6676 SendAsync net472 7.46μs 2.06ns 8ns 0.496 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.588ns 2.2ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.15μs 6.17ns 22.2ns 0.0223 0 0 1.64 KB
master EnrichedLog net472 2.61μs 1.43ns 5.55ns 0.249 0 0 1.57 KB
#6676 EnrichedLog net6.0 1.62μs 0.783ns 3.03ns 0.0227 0 0 1.64 KB
#6676 EnrichedLog netcoreapp3.1 2.16μs 0.912ns 3.29ns 0.0216 0 0 1.64 KB
#6676 EnrichedLog net472 2.59μs 1.11ns 4.29ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 169ns 656ns 0.0564 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 116μs 195ns 755ns 0.058 0 0 4.28 KB
master EnrichedLog net472 152μs 277ns 1.07μs 0.67 0.223 0 4.46 KB
#6676 EnrichedLog net6.0 112μs 108ns 403ns 0.0559 0 0 4.28 KB
#6676 EnrichedLog netcoreapp3.1 117μs 105ns 405ns 0.0584 0 0 4.28 KB
#6676 EnrichedLog net472 149μs 99.6ns 373ns 0.676 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.04μs 12ns 46.5ns 0.0312 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 1.89ns 7.33ns 0.0306 0 0 2.2 KB
master EnrichedLog net472 4.82μs 1.35ns 5.04ns 0.32 0 0 2.02 KB
#6676 EnrichedLog net6.0 3μs 1.01ns 3.79ns 0.03 0 0 2.2 KB
#6676 EnrichedLog netcoreapp3.1 4.28μs 2.11ns 8.19ns 0.0299 0 0 2.2 KB
#6676 EnrichedLog net472 4.76μs 2.38ns 9.23ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 0.882ns 3.42ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 3.61ns 14ns 0.0157 0 0 1.14 KB
master SendReceive net472 2.18μs 2.48ns 9.29ns 0.183 0 0 1.16 KB
#6676 SendReceive net6.0 1.39μs 1.29ns 4.99ns 0.0159 0 0 1.14 KB
#6676 SendReceive netcoreapp3.1 1.76μs 3.55ns 13.7ns 0.0148 0 0 1.14 KB
#6676 SendReceive net472 2.04μs 1.75ns 6.54ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.85μs 2.65ns 9.93ns 0.023 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.9μs 1.79ns 6.7ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.25μs 2.89ns 11.2ns 0.322 0 0 2.04 KB
#6676 EnrichedLog net6.0 2.65μs 1.1ns 3.96ns 0.0226 0 0 1.6 KB
#6676 EnrichedLog netcoreapp3.1 3.84μs 2.46ns 9.52ns 0.021 0 0 1.65 KB
#6676 EnrichedLog net472 4.4μs 3.75ns 14.5ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6676

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.202 468.31 389.67
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.168 889.00 761.45
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.145 692.21 604.60

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 468ns 0.208ns 0.806ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 556ns 0.587ns 2.27ns 0.00776 0 0 576 B
master StartFinishSpan net472 692ns 0.499ns 1.93ns 0.0918 0 0 578 B
master StartFinishScope net6.0 495ns 0.249ns 0.964ns 0.00981 0 0 696 B
master StartFinishScope netcoreapp3.1 706ns 0.646ns 2.5ns 0.00956 0 0 696 B
master StartFinishScope net472 886ns 1.58ns 6.11ns 0.104 0 0 658 B
#6676 StartFinishSpan net6.0 390ns 0.593ns 2.22ns 0.00815 0 0 576 B
#6676 StartFinishSpan netcoreapp3.1 561ns 1.17ns 4.54ns 0.0079 0 0 576 B
#6676 StartFinishSpan net472 604ns 2.04ns 7.91ns 0.0918 0 0 578 B
#6676 StartFinishScope net6.0 490ns 0.861ns 3.11ns 0.0099 0 0 696 B
#6676 StartFinishScope netcoreapp3.1 760ns 1.47ns 5.69ns 0.00931 0 0 696 B
#6676 StartFinishScope net472 762ns 1.15ns 4.46ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 610ns 0.318ns 1.23ns 0.00978 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 916ns 1.36ns 5.28ns 0.00932 0 0 696 B
master RunOnMethodBegin net472 1.17μs 0.969ns 3.63ns 0.104 0 0 658 B
#6676 RunOnMethodBegin net6.0 628ns 1.15ns 4.45ns 0.00988 0 0 696 B
#6676 RunOnMethodBegin netcoreapp3.1 950ns 1.31ns 5.08ns 0.00942 0 0 696 B
#6676 RunOnMethodBegin net472 1.09μs 2.66ns 10.3ns 0.104 0 0 658 B

@andrewlock andrewlock merged commit 9154889 into master Feb 18, 2025
62 of 67 checks passed
@andrewlock andrewlock deleted the andrew/win-ssi/allow-uninstall-without-iis branch February 18, 2025 15:07
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

Assignees
No one assigned
Labels
area:ssi
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @kevingosse