-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fleet installer] Add additional logging for app pool modifications #6700
Conversation
4dae76a
to
d76e29c
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6700) - mean (70ms) : 63, 76
. : milestone, 70,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6700) - mean (1,002ms) : 979, 1026
. : milestone, 1002,
master - mean (1,002ms) : 981, 1024
. : milestone, 1002,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6700) - mean (103ms) : 101, 105
. : milestone, 103,
master - mean (102ms) : 100, 104
. : milestone, 102,
section CallTarget+Inlining+NGEN
This PR (6700) - mean (676ms) : 660, 691
. : milestone, 676,
master - mean (676ms) : 656, 696
. : milestone, 676,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6700) - mean (89ms) : 88, 91
. : milestone, 89,
master - mean (89ms) : 87, 92
. : milestone, 89,
section CallTarget+Inlining+NGEN
This PR (6700) - mean (635ms) : 616, 654
. : milestone, 635,
master - mean (635ms) : 618, 652
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6700) - mean (192ms) : 186, 198
. : milestone, 192,
master - mean (191ms) : 188, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6700) - mean (1,110ms) : 1085, 1136
. : milestone, 1110,
master - mean (1,107ms) : 1077, 1136
. : milestone, 1107,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6700) - mean (272ms) : 267, 277
. : milestone, 272,
master - mean (271ms) : 267, 276
. : milestone, 271,
section CallTarget+Inlining+NGEN
This PR (6700) - mean (869ms) : 839, 898
. : milestone, 869,
master - mean (866ms) : 835, 898
. : milestone, 866,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6700) - mean (263ms) : 259, 267
. : milestone, 263,
master - mean (263ms) : 258, 268
. : milestone, 263,
section CallTarget+Inlining+NGEN
This PR (6700) - mean (845ms) : 812, 878
. : milestone, 845,
master - mean (843ms) : 811, 876
. : milestone, 843,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// Similarly, not showing the value we're setting here. It isn't a sensitive value now, but | ||
// that won't always be the case, so this avoids the risk. Obviously that's less useful | ||
// for troubleshooting unfortunately. | ||
log.WriteInfo($"Adding new variable '{kvp.Key}'"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary of changes
Adds more logging about modifications we're making to app pool variables
Reason for change
We want to make sure the logs are very explicit about what the installer is doing, so that if we need to determine how the pools got into the existing state, we have as much information as possible.
Implementation details
Lots more logs
Test coverage
Meh