Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Add Export project in Demo for datadog-ci tests #6708

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

chrisnas
Copy link
Contributor

Summary of changes

Add Export C++ project

Reason for change

We need a way to build .dll PE files for datadog-ci tests where debug info are extracted

Implementation details

Just a simple C++ Visual Studio DLL project

Test coverage

Soon in datadog-ci

Other details

@chrisnas chrisnas requested review from a team as code owners February 24, 2025 16:31
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Feb 24, 2025
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6708) - mean (70ms)  : 65, 75
     .   : milestone, 70,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6708) - mean (1,002ms)  : 978, 1025
     .   : milestone, 1002,
    master - mean (998ms)  : 977, 1018
     .   : milestone, 998,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6708) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6708) - mean (676ms)  : 659, 692
     .   : milestone, 676,
    master - mean (673ms)  : 656, 690
     .   : milestone, 673,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6708) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6708) - mean (631ms)  : 612, 651
     .   : milestone, 631,
    master - mean (634ms)  : 618, 651
     .   : milestone, 634,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6708) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 186, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6708) - mean (1,109ms)  : 1080, 1138
     .   : milestone, 1109,
    master - mean (1,110ms)  : 1078, 1142
     .   : milestone, 1110,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6708) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (274ms)  : 267, 282
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (6708) - mean (870ms)  : 840, 899
     .   : milestone, 870,
    master - mean (869ms)  : 829, 908
     .   : milestone, 869,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6708) - mean (264ms)  : 259, 268
     .   : milestone, 264,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6708) - mean (848ms)  : 815, 880
     .   : milestone, 848,
    master - mean (848ms)  : 817, 880
     .   : milestone, 848,

Loading

@chrisnas chrisnas merged commit 2015a76 into master Feb 25, 2025
147 of 152 checks passed
@chrisnas chrisnas deleted the chrisnas/add_demo_app_for_symbolization branch February 25, 2025 10:04
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 25, 2025
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants