Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification channel for build pipeline #6717

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

randomanderson
Copy link
Contributor

@randomanderson randomanderson commented Feb 25, 2025

Summary of changes

This PR adds a channel for notifications for pipeline failures

Reason for change

The shared pipeline has added notifications for failures during a release pipeline. More notifications may be added in the future.

Implementation details

Of the channels available, I chose #apm-dotnet-bots

@randomanderson randomanderson added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 25, 2025
@randomanderson randomanderson requested a review from a team as a code owner February 25, 2025 17:26
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>
Copy link
Collaborator

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that we will now get a new notification when the build fails (which is a great change), but I am unsure how to act on that notification.

Granted I haven't seen it yet, so maybe it is just go to the GitLab build and click re-run?

@randomanderson randomanderson merged commit cf95e5a into master Mar 4, 2025
100 of 104 checks passed
@randomanderson randomanderson deleted the landerson/notification-channel branch March 4, 2025 17:44
@github-actions github-actions bot added this to the vNext-v3 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants