-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build
workflow from CircleCI to GitHub Actions
#1974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
requested changes
Apr 6, 2022
8cc5e48
to
0ef0b44
Compare
Codecov Report
@@ Coverage Diff @@
## master #1974 +/- ##
===========================================
+ Coverage 80.92% 93.13% +12.21%
===========================================
Files 200 195 -5
Lines 8195 8044 -151
===========================================
+ Hits 6632 7492 +860
+ Misses 1563 552 -1011 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
build
workflow from CircleCI to GitHub Actions
a412a53
to
67de4fa
Compare
bengl
approved these changes
Apr 29, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
May 5, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
May 5, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move
build
workflow from CircleCI to GitHub Actions.Motivation
There are several advantages of switching to GitHub Actions for this type of project:
This PR focused only on the
build
workflow which is now split into separate workflows:Tracing
but for now I felt like it was easier to use to group them in a single workflow.Upstream tests and benchmarks will be done in separate PRs.
Additional Notes
master
as there was a new version released which breaks.pg
minimum version to make it pass, but this shouldn't be an issue since older versions only support up to Node 4 which we don't support .