-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove codecov status checks #2326
Conversation
Overall package sizeSelf size: 2.61 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2326 +/- ##
==========================================
- Coverage 92.70% 92.70% -0.01%
==========================================
Files 224 220 -4
Lines 8718 8580 -138
==========================================
- Hits 8082 7954 -128
+ Misses 636 626 -10 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
You need to use the status threshold setting. https://docs.codecov.com/docs/commit-status |
The doc is extremely unclear how this should be used, and in any case I'd put it so low that it would effectively be the same as setting the config to |
What does this PR do?
Remove Codecov status checks.
Motivation
These fail as soon as there is a tiny variation in code coverage, creating unnecessary noise. I wasn't able to find in the documentation how to make these behave properly. The report is still generated and we can address this when the new test suite lands since it will make it easier to cover the entire codebase.