Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove codecov status checks #2326

Merged
merged 1 commit into from
Aug 31, 2022
Merged

remove codecov status checks #2326

merged 1 commit into from
Aug 31, 2022

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Aug 30, 2022

What does this PR do?

Remove Codecov status checks.

Motivation

These fail as soon as there is a tiny variation in code coverage, creating unnecessary noise. I wasn't able to find in the documentation how to make these behave properly. The report is still generated and we can address this when the new test suite lands since it will make it easier to cover the entire codebase.

@github-actions
Copy link

Overall package size

Self size: 2.61 MB
Deduped: 29.79 MB
No deduping: 30.42 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.0.2 8.74 MB 14.46 MB
@datadog/native-metrics 1.4.2 6.61 MB 7.04 MB
@datadog/native-appsec 1.2.1 5.1 MB 5.43 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.0.0 105.44 kB 105.44 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
semver 5.7.1 61.58 kB 61.58 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.0 30.3 kB 34.77 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #2326 (5d2d954) into master (abb87ff) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2326      +/-   ##
==========================================
- Coverage   92.70%   92.70%   -0.01%     
==========================================
  Files         224      220       -4     
  Lines        8718     8580     -138     
==========================================
- Hits         8082     7954     -128     
+ Misses        636      626      -10     
Impacted Files Coverage Δ
packages/datadog-plugin-ioredis/src/index.js
packages/datadog-instrumentations/src/ioredis.js
packages/datadog-plugin-redis/src/index.js
packages/datadog-instrumentations/src/redis.js

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Qard
Copy link
Contributor

Qard commented Aug 31, 2022

You need to use the status threshold setting. https://docs.codecov.com/docs/commit-status

@rochdev
Copy link
Member Author

rochdev commented Aug 31, 2022

You need to use the status threshold setting. https://docs.codecov.com/docs/commit-status

The doc is extremely unclear how this should be used, and in any case I'd put it so low that it would effectively be the same as setting the config to off.

@rochdev rochdev merged commit 7218bca into master Aug 31, 2022
@rochdev rochdev deleted the remove-codecov-status-checks branch August 31, 2022 19:21
rochdev added a commit that referenced this pull request Sep 1, 2022
rochdev added a commit that referenced this pull request Sep 1, 2022
rochdev added a commit that referenced this pull request Sep 1, 2022
rochdev added a commit that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants