-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to tap for ci/core/tracing/profiling tests #2889
Conversation
Overall package sizeSelf size: 3.88 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2889 +/- ##
==========================================
- Coverage 89.30% 83.98% -5.33%
==========================================
Files 302 17 -285
Lines 11091 668 -10423
Branches 33 33
==========================================
- Hits 9905 561 -9344
+ Misses 1186 107 -1079 see 285 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksComparing candidate commit 77fc89f in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 664 metrics, 42 unstable metrics. scenario:exporting-pipeline-0.5-18
|
@tlhunter For the comment in #2538 (comment): @bengl For the comment in #2538 (comment) it was fixed a long time ago. @juan-fernandez Please confirm if moving to tap works for you, if not I can just remove CI from the PR, although this should enable you to run tests in isolation without having to rely on the integration tests. @simon-id I removed AppSec since it was failing, but I still moved it to its own jobs, so you can decide to switch to tap as well after this PR is merged or keep Mocha for your team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from CI Vis' perspective. I only worry about a test we're skipping. Just to confirm: this PR is a noop for plugins
test, right?
Correct, at least for now. |
What does this PR do?
Update some tests to run in isolated workers using tap. There is also no global setup anymore, so individual tests files can be run directly with
node somefile.spec.js
.Motivation
We need a way to isolate tests so that we can write integration tests without complex logic to cleanup after the suite, which is also not always possible.
Additional Notes
This is exactly the same code as #2538 but without AppSec as there are new test failures that I wasn't able to fix. I also wasn't able to merge properly as there were too many changes on the main branch, so I decided to open a new PR, but again it's the same code as #2538 so any review that was done there applies here as well.