Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix aws-sdk failing test suite #3860

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Dec 11, 2023

What does this PR do?

Aws tests have not passed for several months. This PR fixes the connection issues we were previously getting and upgrades the localstack image. Ideally we would like to only be using a newer image of localstack, but the older image is being kept due to failures of s3 tests and lambda tests when trying to use the newer image.

Motivation

Fixes failing suite in order to unblock future PR's that will add DSM for AWS SQS and SNS

Plugin Checklist

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@wconti27 wconti27 requested review from a team as code owners December 11, 2023 19:10
@wconti27 wconti27 requested a review from jbertran December 11, 2023 19:10
Copy link

github-actions bot commented Dec 11, 2023

Overall package size

Self size: 5.66 MB
Deduped: 61.73 MB
No deduping: 62.49 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 5.0.0 15.16 MB 15.17 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.1 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2023

Benchmarks

Benchmark execution time: 2023-12-11 21:17:24

Comparing candidate commit af16096 in PR branch conti/fix-aws-sdk-tests with baseline commit 1afbe57 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 519 metrics, 12 unstable metrics.

scenario:log-with-error-16

  • 🟥 cpu_user_time [+14.798ms; +23.274ms] or [+5.056%; +7.952%]

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1afbe57) 84.81% compared to head (af16096) 93.28%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3860      +/-   ##
==========================================
+ Coverage   84.81%   93.28%   +8.46%     
==========================================
  Files         233       84     -149     
  Lines        9654     2724    -6930     
  Branches       33       33              
==========================================
- Hits         8188     2541    -5647     
+ Misses       1466      183    -1283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wconti27 wconti27 merged commit 68f2d61 into master Dec 12, 2023
khanayan123 pushed a commit that referenced this pull request Dec 14, 2023
khanayan123 pushed a commit that referenced this pull request Dec 14, 2023
khanayan123 pushed a commit that referenced this pull request Dec 14, 2023
khanayan123 pushed a commit that referenced this pull request Dec 14, 2023
@Qard Qard deleted the conti/fix-aws-sdk-tests branch December 28, 2023 14:58
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants