-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix aws-sdk failing test suite #3860
Conversation
Overall package sizeSelf size: 5.66 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2023-12-11 21:17:24 Comparing candidate commit af16096 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 519 metrics, 12 unstable metrics. scenario:log-with-error-16
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3860 +/- ##
==========================================
+ Coverage 84.81% 93.28% +8.46%
==========================================
Files 233 84 -149
Lines 9654 2724 -6930
Branches 33 33
==========================================
- Hits 8188 2541 -5647
+ Misses 1466 183 -1283 ☔ View full report in Codecov by Sentry. |
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
* fix aws-sdk plugin tests
What does this PR do?
Aws tests have not passed for several months. This PR fixes the connection issues we were previously getting and upgrades the localstack image. Ideally we would like to only be using a newer image of localstack, but the older image is being kept due to failures of s3 tests and lambda tests when trying to use the newer image.
Motivation
Fixes failing suite in order to unblock future PR's that will add DSM for AWS SQS and SNS
Plugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!