Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run DNS and Net timeline events integration tests on Node 16+ #3879

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Dec 14, 2023

What does this PR do?

Restricts running DNS and Net timeline events integration tests only to Node 16 and above.

Motivation

DNS and Net perf events aren't available in Node 14; the tests can't work.

Additional Notes

Recommended to review in whitespace-ignore mode.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@szegedi szegedi requested a review from a team as a code owner December 14, 2023 15:18
@szegedi szegedi requested a review from khanayan123 December 14, 2023 15:18
@szegedi szegedi added bug Something isn't working profiling semver-patch labels Dec 14, 2023
Copy link

Overall package size

Self size: 5.71 MB
Deduped: 61.81 MB
No deduping: 62.56 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 5.0.0 15.16 MB 15.17 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.1 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25e0686) 84.47% compared to head (9f1250b) 86.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
+ Coverage   84.47%   86.76%   +2.29%     
==========================================
  Files         234      228       -6     
  Lines        9802     9182     -620     
  Branches       33       33              
==========================================
- Hits         8280     7967     -313     
+ Misses       1522     1215     -307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 14, 2023

Benchmarks

Benchmark execution time: 2023-12-14 15:28:47

Comparing candidate commit 9f1250b in PR branch szegedi/no-net-tests-on-14 with baseline commit 25e0686 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 521 metrics, 11 unstable metrics.

@szegedi szegedi merged commit 7aa75b0 into master Dec 14, 2023
@szegedi szegedi deleted the szegedi/no-net-tests-on-14 branch December 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working profiling semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants