-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run DNS and Net timeline events integration tests on Node 16+ #3879
Conversation
Overall package sizeSelf size: 5.71 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
+ Coverage 84.47% 86.76% +2.29%
==========================================
Files 234 228 -6
Lines 9802 9182 -620
Branches 33 33
==========================================
- Hits 8280 7967 -313
+ Misses 1522 1215 -307 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-14 15:28:47 Comparing candidate commit 9f1250b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 521 metrics, 11 unstable metrics. |
What does this PR do?
Restricts running DNS and Net timeline events integration tests only to Node 16 and above.
Motivation
DNS and Net perf events aren't available in Node 14; the tests can't work.
Additional Notes
Recommended to review in whitespace-ignore mode.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.