V5.0.0 proposal #3917
Closed
V5.0.0 proposal #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
khanayan123
force-pushed
the
v5.0.0-proposal
branch
from
11fa2f8 to
35ac996
Compare
…erimental ones (#3659) * Deprecate EXPERIMENTAL_ env vars for code hostpots; introduce non-experimental variants * make sure code hotspots being enabled is consistent with endpoint profiling being enabled
* Instrumentate nextjs and call to waf * Feature implementation, pending to fix the tests * Add appsec nextjs pipeline * execute less tests * Execute tests again * try other approach to instrumentate next app request * Fix lints * Extract body and query in diagnostics channel publish not in subscribe * Fix tests * Fix query monitoring nextjs * small fixes * Remove unnecessary files * Restore next test * fixes * Fix from PR comments * Small changes from PR comments * Replace some exec by fs functions
* Fix SQLi location when using knex * Remove onProgress wrapping from knex then * Rename asyncResource * Add spacing in code to improve readability * Avoid using shimmer to wrap then from knex raw result * Detect dialect for SQLi with knex * Instrument knex catch and asCallback
* Prevent sending query address twice to the waf * Small changes + test * Fix invalid query type test and behaviour * Comment in the PR
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Fix supported MongoDB versions in NoSQL injection test * Simplify version range for mongodb
Add tracking of supported integrations and supported integration versions and output data as artifacts during testing
--------- Co-authored-by: Stephen Belanger <stephen.belanger@datadoghq.com>
* default error tagging for next and pageLoad safeguarding
#3889) * Configure parametric test to get the nodejs tracer in same way as system-tests
* Upload module skeleton. * Blocking in apollo, very very first version * Move graphql implementation to another module. * Blocking for apollo-server-core, ugly but it works, lets find a better way * Use real blocking data * Set blocking to true. * Throw before resolver execution in order to stop the operation's execution flow. * Use HttpQueryError in apollo-server-core * Blocking test in apollo-server-fastify * Refactor graphql blocking. * Remove previous implementation which only supported monitoring. * Add new waf address in order to check the payload of every resolver. * Use apm start resolver address instead of a new one. * Remove mock and perform an actual call to the waf. * Add non blocking graphql test * Move abortController constructor to context creation. This reduces the performance overhead due to just one instance is shared across the whole query exectution. * Add pollo-server-express block tests * Add unit tests. * Add @apollo/server tests * Update test rules for blocking by `graphql.server.resolver` * Block with graphql templates data * Add tests. * Block with graphql data in graphql endpoint * Fix tests. * Execute @apollo/server and apollo-server-express tests * Unify code in @apollo/server and apollo-server-core * update comments * Add appsec.blocked tag in blocked requests * Add test with non graphql block response * Tests for block with redirect * Prevent creation of resolve span when it is blocked before the execution of the resolve code * Refactor addResolver in order to get directives information. * Add tests to block on directives. * Add test for directives. * Undo prevent creating resolve span * Configurable graphql blocking json * Refactor graphql * Using resolver instead of resolvers. * Change graphql channel name to be consistent with the others. * Small changes in blocking * Move resover information resolution to plugin. * Revert "Move resover information resolution to plugin." This reverts commit 7cc8561. * Remove resolver information from context, pass it in a different field instead. * Throw custom exception rather than send an empty array. * Update packages/datadog-instrumentations/src/graphql.js Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> * Change a bit apollo-server-core instrumentation * Protect Header map, if in future version it is moved/removed, prevent breaks * Remove some duplicated code * Update packages/datadog-instrumentations/src/apollo-server.js Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com> * Fix comments in the PR * Fix PR comments. * Fix some comments in the PR * Move resolver information formatting to the plugin. * Fix PR comments. * Fix proper use of Promise.race. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
* Add thread id to heap and wall profiles * Allow generateLabels to be called without arguments In wall profile, if generateLabels is called without arguments, return thread labels.
* New RC ASM_API_SECURITY_SAMPLE_RATE capability * Do not report ASM_API_SECURITY_SAMPLE_RATE capability if apiSecurity is not enabled * Change Activation constants case * Update ASM_API_SECURITY_SAMPLE_RATE capability when enabling RemoteConfig * Apply same coertion logic as in config.js * Clean up * Do not turn off ASM_API_SECURITY_SAMPLE_RATE when disabling waf update * Include api_security_sampler test case * Fix test comment * remove NOTE
* Ensure recording start time of next profile is the same as the recording end time of the current profile. * Pass the start-end range to profilers so they can use it * Use passed-in start-end instead of internal duration computations * Use end date to cut off late events for the next profile
* github: suggest new issues use helpdesk instead * remove deprecated bug report / feature request options
* Update waf bindings to 6.0.0. * Pass graphql.server.resolver as ephemeral address type. * Add test.
* Update test agent configuration * Update test sgent config * Update test agent configuration --------- Co-authored-by: William Conti <william.conti@datadoghq.com>
* add support for node specifiers
* simplify ci build for aerospike
Node 14 versions prior to 14.18 do not support require statements with `node:` prefix.
* Bump github actions versions * Stop using deprecated set-output command * Fix incompatible GLIBC version in GHA
Add a `process_id` that contains process pid to profiles.
khanayan123
force-pushed
the
v5.0.0-proposal
branch
from
35ac996 to
777fbea
Compare
BenchmarksBenchmark execution time: 2024-01-02 19:08:29 Comparing candidate commit 777fbea in PR branch Found 2 performance improvements and 67 performance regressions! Performance is the same for 313 metrics, 10 unstable metrics. scenario:appsec-appsec-enabled-16
scenario:appsec-appsec-enabled-18
scenario:appsec-appsec-enabled-with-attacks-16
scenario:appsec-appsec-enabled-with-attacks-18
scenario:appsec-control-16
scenario:appsec-control-18
scenario:appsec-control-with-attacks-16
scenario:appsec-control-with-attacks-18
scenario:appsec-iast-no-vulnerability-control-16
scenario:appsec-iast-no-vulnerability-control-18
scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-16
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18
scenario:appsec-iast-with-vulnerability-control-16
scenario:appsec-iast-with-vulnerability-control-18
scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18
scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18
scenario:log-skip-log-16
scenario:log-skip-log-18
scenario:log-with-debug-16
scenario:log-with-debug-18
scenario:log-with-error-16
scenario:log-with-error-18
scenario:log-without-log-16
scenario:log-without-log-18
scenario:net-with-tracer-16
scenario:plugin-bluebird-with-tracer-16
scenario:spans-finish-immediately-16
scenario:spans-finish-immediately-18
scenario:spans-finish-later-16
scenario:spans-finish-later-18
|
|
This looks huge! Are these commits not already in v4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
More information about the breaking changes from this release can be found in
the migration guide.
Features
process_idtag to profiles #3911)Improvements
Bug Fixes