-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROF-8714: Code hotspots and endpoint collection shouldn't be enabled on Windows #3944
Conversation
Overall package sizeSelf size: 5.83 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3944 +/- ##
=======================================
Coverage 85.01% 85.02%
=======================================
Files 238 238
Lines 10176 10181 +5
Branches 33 33
=======================================
+ Hits 8651 8656 +5
Misses 1525 1525 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-09 18:10:38 Comparing candidate commit 5df01a8 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
2bce160
to
5df01a8
Compare
What does this PR do?
Ensures that code hotspots and endpoint collection are not enabled on Windows.
Motivation
#3940 enabled code hotspots and endpoint collection by default. However, these features don't work on Windows, so defaults need to remain true on that platform. Additionally, we added code to prevent these features to be attempted to be turned on accidentally.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.