-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new initializer file #4334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, non-programmatic tracer initialization was done via a combination of several command-line options, depending on whether ESM support is required, and what version of Node.js. This has now been consolidated to a single `initialize.mjs` file, which can be used either with the `--loader` option, or the `--import` option. In either case, it will initialize both the tracer and the ESM loader hook. For versions of Node.js prior to 20.6.0, the `--loader` option must be used. For versions after that, either may be used, but `--import` is preferred, since the `--loader` option will eventually be deprecated, and emits a warning as such already. All previous behavior, and related files, are preserved, so this is a semver-minor change. For now, docs are not included, since the current README does not even address non-programmatic initialization. Future work (for future PRs): * Have `.init()` also call `register()` for the loader hook if it hasn't been registered, so that CLI options become unnecessary for ESM support in Node.js * Allow programmatic config when using non-programmatic initialization.
Overall package sizeSelf size: 6.51 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Qard
approved these changes
May 21, 2024
rochdev
reviewed
May 21, 2024
rochdev
approved these changes
May 21, 2024
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 4, 2024
Previously, non-programmatic tracer initialization was done via a combination of several command-line options, depending on whether ESM support is required, and what version of Node.js. This has now been consolidated to a single `initialize.mjs` file, which can be used either with the `--loader` option, or the `--import` option. In either case, it will initialize both the tracer and the ESM loader hook. For versions of Node.js prior to 20.6.0, the `--loader` option must be used. For versions after that, either may be used, but `--import` is preferred, since the `--loader` option will eventually be deprecated, and emits a warning as such already. All previous behavior, and related files, are preserved, so this is a semver-minor change. For now, docs are not included, since the current README does not even address non-programmatic initialization. Future work (for future PRs): * Have `.init()` also call `register()` for the loader hook if it hasn't been registered, so that CLI options become unnecessary for ESM support in Node.js * Allow programmatic config when using non-programmatic initialization.
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 4, 2024
Previously, non-programmatic tracer initialization was done via a combination of several command-line options, depending on whether ESM support is required, and what version of Node.js. This has now been consolidated to a single `initialize.mjs` file, which can be used either with the `--loader` option, or the `--import` option. In either case, it will initialize both the tracer and the ESM loader hook. For versions of Node.js prior to 20.6.0, the `--loader` option must be used. For versions after that, either may be used, but `--import` is preferred, since the `--loader` option will eventually be deprecated, and emits a warning as such already. All previous behavior, and related files, are preserved, so this is a semver-minor change. For now, docs are not included, since the current README does not even address non-programmatic initialization. Future work (for future PRs): * Have `.init()` also call `register()` for the loader hook if it hasn't been registered, so that CLI options become unnecessary for ESM support in Node.js * Allow programmatic config when using non-programmatic initialization.
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 5, 2024
Previously, non-programmatic tracer initialization was done via a combination of several command-line options, depending on whether ESM support is required, and what version of Node.js. This has now been consolidated to a single `initialize.mjs` file, which can be used either with the `--loader` option, or the `--import` option. In either case, it will initialize both the tracer and the ESM loader hook. For versions of Node.js prior to 20.6.0, the `--loader` option must be used. For versions after that, either may be used, but `--import` is preferred, since the `--loader` option will eventually be deprecated, and emits a warning as such already. All previous behavior, and related files, are preserved, so this is a semver-minor change. For now, docs are not included, since the current README does not even address non-programmatic initialization. Future work (for future PRs): * Have `.init()` also call `register()` for the loader hook if it hasn't been registered, so that CLI options become unnecessary for ESM support in Node.js * Allow programmatic config when using non-programmatic initialization.
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 5, 2024
Previously, non-programmatic tracer initialization was done via a combination of several command-line options, depending on whether ESM support is required, and what version of Node.js. This has now been consolidated to a single `initialize.mjs` file, which can be used either with the `--loader` option, or the `--import` option. In either case, it will initialize both the tracer and the ESM loader hook. For versions of Node.js prior to 20.6.0, the `--loader` option must be used. For versions after that, either may be used, but `--import` is preferred, since the `--loader` option will eventually be deprecated, and emits a warning as such already. All previous behavior, and related files, are preserved, so this is a semver-minor change. For now, docs are not included, since the current README does not even address non-programmatic initialization. Future work (for future PRs): * Have `.init()` also call `register()` for the loader hook if it hasn't been registered, so that CLI options become unnecessary for ESM support in Node.js * Allow programmatic config when using non-programmatic initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, non-programmatic tracer initialization was done via a combination of several command-line options, depending on whether ESM support is required, and what version of Node.js.
This has now been consolidated to a single
initialize.mjs
file, which can be used either with the--loader
option, or the--import
option. In either case, it will initialize both the tracer and the ESM loader hook. For versions of Node.js prior to 20.6.0, the--loader
option must be used. For versions after that, either may be used, but--import
is preferred, since the--loader
option will eventually be deprecated, and emits a warning as such already.All previous behavior, and related files, are preserved, so this is a semver-minor change.
For now, docs are not included, since the current README does not even address non-programmatic initialization.
Future work (for future PRs):
.init()
also callregister()
for the loader hook if it hasn't been registered, so that CLI options become unnecessary for ESM support in Node.js