Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] [wip] Playwright active test span #4843

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Oct 30, 2024

Overall package size

Self size: 9.01 MB
Deduped: 101.54 MB
No deduping: 102.06 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2025-03-24 23:44:11

Comparing candidate commit fe29bef in PR branch juan-fernandez/playwright-active-span with baseline commit 402741b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 921 metrics, 12 unstable metrics.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

@juan-fernandez
Copy link
Collaborator Author

yes, let's keep it, as it's likely to be picked up again soon

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/playwright-active-span branch from 6c10620 to 6bfe386 Compare March 17, 2025 12:57
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (402741b) to head (fe29bef).

Files with missing lines Patch % Lines
...e/src/ci-visibility/exporters/test-worker/index.js 33.33% 2 Missing ⚠️
.../src/ci-visibility/exporters/test-worker/writer.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4843      +/-   ##
==========================================
- Coverage   79.59%   79.57%   -0.02%     
==========================================
  Files         510      510              
  Lines       22923    22927       +4     
==========================================
  Hits        18245    18245              
- Misses       4678     4682       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 17, 2025

Datadog Report

Branch report: juan-fernandez/playwright-active-span
Commit report: a2b18ea
Test service: dd-trace-js-integration-tests

❌ 26 Failed (0 Known Flaky), 780 Passed, 0 Skipped, 14m 57.51s Total Time

❌ Failed Tests (26)

This report shows up to 5 failed tests.

  • playwright@1.18.0 correctly calculates test code owners when working directory is not repository root - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     Cannot read properties of undefined (reading 'content')
    
  • playwright@1.18.0 correctly calculates test code owners when working directory is not repository root - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     Cannot read properties of undefined (reading 'content')
    
  • playwright@1.18.0 does not crash when maxFailures=1 and there is an error - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected [ Array(1) ] to be a superset of [ …(2) ]
    
  • playwright@1.18.0 does not crash when maxFailures=1 and there is an error - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected [ Array(1) ] to be a superset of [ …(2) ]
    
  • playwright@1.18.0 flaky test retries can automatically retry flaky tests - integration-tests/playwright/playwright.spec.js - Details

    Expand for error
     expected +0 to equal 3
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants