Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next.js: complete v14.x compatibility (fixing >=14.2.7) #4916

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Nov 20, 2024

What does this PR do?

  • fixs compatibility with Next.js >=v14.2.7 - 14.x
  • previously there were 27 test failures
  • note that this doesn't address v15.x, I'll do that in a follow up PR

Motivation

  • Next.js 14.2.7 broke compat when the internal headers concept was replaced with a symbol on the request object
  • it was further made complicated by us relying on the removal of said internal headers
    • now that they use a symbol they just keep the data around throughout the various stages of the request
    • for that reason I'm using a WeakSet to track the two stages of the request
  • AIDM-339

@tlhunter tlhunter added the integration-nextjs issues relating to the Next.js framework from Vercel label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Overall package size

Self size: 8.09 MB
Deduped: 94.59 MB
No deduping: 94.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks

Benchmark execution time: 2024-11-21 02:59:10

Comparing candidate commit 437d328 in PR branch tlhunter/next-14-2-7-fix with baseline commit c8ab3e4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 263 metrics, 3 unstable metrics.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.48%. Comparing base (c8ab3e4) to head (0c408a9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4916      +/-   ##
==========================================
- Coverage   66.51%   61.48%   -5.04%     
==========================================
  Files         143      304     +161     
  Lines        4784    14238    +9454     
==========================================
+ Hits         3182     8754    +5572     
- Misses       1602     5484    +3882     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tlhunter tlhunter force-pushed the tlhunter/next-14-2-7-fix branch 3 times, most recently from cfd54e1 to 0c408a9 Compare November 21, 2024 01:11
@tlhunter tlhunter marked this pull request as ready for review November 21, 2024 01:11
@tlhunter tlhunter requested review from a team as code owners November 21, 2024 01:11
@tlhunter tlhunter force-pushed the tlhunter/next-14-2-7-fix branch from 0c408a9 to ab4fffc Compare November 21, 2024 01:59
@tlhunter tlhunter changed the title next.js: fix compatibility with >=14.2.7 next.js: fix compatibility with >=14.2.7 - 14.x Nov 21, 2024
@tlhunter tlhunter changed the title next.js: fix compatibility with >=14.2.7 - 14.x next.js: complete v14.x compatibility (fixing >=14.2.7) Nov 21, 2024
@tlhunter tlhunter enabled auto-merge (squash) November 21, 2024 03:06
@tlhunter tlhunter merged commit d0e80ea into master Nov 21, 2024
240 checks passed
@tlhunter tlhunter deleted the tlhunter/next-14-2-7-fix branch November 21, 2024 12:24
rochdev pushed a commit that referenced this pull request Nov 21, 2024
- fixs compatibility with Next.js >=v14.2.7 - 14.x
- previously there were 27 test failures
- note that this doesn't address v15.x, I'll do that in a follow up PR
- Next.js 14.2.7 broke compat when the internal headers concept was replaced with a symbol on the request object
- it was further made complicated by us relying on the removal of said internal headers
  - now that they use a symbol they just keep the data around throughout the various stages of the request
  - for that reason I'm using a `WeakSet` to track the two stages of the request
- @see AIDM-339
@rochdev rochdev mentioned this pull request Nov 21, 2024
rochdev pushed a commit that referenced this pull request Nov 21, 2024
- fixs compatibility with Next.js >=v14.2.7 - 14.x
- previously there were 27 test failures
- note that this doesn't address v15.x, I'll do that in a follow up PR
- Next.js 14.2.7 broke compat when the internal headers concept was replaced with a symbol on the request object
- it was further made complicated by us relying on the removal of said internal headers
  - now that they use a symbol they just keep the data around throughout the various stages of the request
  - for that reason I'm using a `WeakSet` to track the two stages of the request
- @see AIDM-339
@rochdev rochdev mentioned this pull request Nov 21, 2024
rochdev pushed a commit that referenced this pull request Nov 21, 2024
- fixs compatibility with Next.js >=v14.2.7 - 14.x
- previously there were 27 test failures
- note that this doesn't address v15.x, I'll do that in a follow up PR
- Next.js 14.2.7 broke compat when the internal headers concept was replaced with a symbol on the request object
- it was further made complicated by us relying on the removal of said internal headers
  - now that they use a symbol they just keep the data around throughout the various stages of the request
  - for that reason I'm using a `WeakSet` to track the two stages of the request
- @see AIDM-339
rochdev pushed a commit that referenced this pull request Nov 21, 2024
- fixs compatibility with Next.js >=v14.2.7 - 14.x
- previously there were 27 test failures
- note that this doesn't address v15.x, I'll do that in a follow up PR
- Next.js 14.2.7 broke compat when the internal headers concept was replaced with a symbol on the request object
- it was further made complicated by us relying on the removal of said internal headers
  - now that they use a symbol they just keep the data around throughout the various stages of the request
  - for that reason I'm using a `WeakSet` to track the two stages of the request
- @see AIDM-339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-nextjs issues relating to the Next.js framework from Vercel semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants