Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify wrap and trace #5192

Merged
merged 1 commit into from
Feb 3, 2025
Merged

simplify wrap and trace #5192

merged 1 commit into from
Feb 3, 2025

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Feb 3, 2025

  • Remove orphanable option from wrap and trace. They were deprecated in v4, meaning they no longer work in supported versions anyway.
  • Remove noop check from wrap. The noop check is for internal use only, and we no longer use wrap internally, so it's unneeded in wrap.

@bengl bengl requested a review from a team as a code owner February 3, 2025 16:14
Copy link

github-actions bot commented Feb 3, 2025

Overall package size

Self size: 8.6 MB
Deduped: 94.99 MB
No deduping: 95.51 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@bengl bengl force-pushed the bengl/simplify-wrap-and-trace branch from f83bd3f to 38668cb Compare February 3, 2025 16:26
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (5d6e698) to head (99d412b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5192   +/-   ##
=======================================
  Coverage   81.13%   81.14%           
=======================================
  Files         481      481           
  Lines       21489    21481    -8     
=======================================
- Hits        17436    17430    -6     
+ Misses       4053     4051    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-03 21:44:12

Comparing candidate commit 99d412b in PR branch bengl/simplify-wrap-and-trace with baseline commit 5d6e698 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 906 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-115.789MB; -57.831MB] or [-12.054%; -6.020%]

* Remove orphanable option from wrap and trace. They were deprecated in
  v4, meaning they no longer work in supported versions anyway.
* Remove noop check from wrap. The noop check is for internal use only,
  and we no longer use wrap internally, so it's unneeded in wrap.
@bengl bengl force-pushed the bengl/simplify-wrap-and-trace branch from 38668cb to 99d412b Compare February 3, 2025 21:32
@bengl bengl enabled auto-merge (squash) February 3, 2025 21:32
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: bengl/simplify-wrap-and-trace
Commit report: a4ad871
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 616 Passed, 0 Skipped, 15m 23.31s Total Time

@bengl bengl merged commit c403eee into master Feb 3, 2025
324 of 353 checks passed
@bengl bengl deleted the bengl/simplify-wrap-and-trace branch February 3, 2025 21:45
rochdev pushed a commit that referenced this pull request Feb 7, 2025

Verified

This commit was signed with the committer’s verified signature.
rochdev Roch Devost
* Remove orphanable option from wrap and trace. They were deprecated in
  v4, meaning they no longer work in supported versions anyway.
* Remove noop check from wrap. The noop check is for internal use only,
  and we no longer use wrap internally, so it's unneeded in wrap.
@rochdev rochdev mentioned this pull request Feb 7, 2025
rochdev pushed a commit that referenced this pull request Feb 10, 2025
* Remove orphanable option from wrap and trace. They were deprecated in
  v4, meaning they no longer work in supported versions anyway.
* Remove noop check from wrap. The noop check is for internal use only,
  and we no longer use wrap internally, so it's unneeded in wrap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants