Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin github actions by hash and update via dependabot #5193

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

xopham
Copy link
Contributor

@xopham xopham commented Feb 3, 2025

What does this PR do?

  • Add dependabot for github actions
  • Pin all actions by hash

Motivation

Pinning 3rd-party GitHub Actions by commit SHA makes them less vulnerable to compromise of the 3rd party. To avoid outdating and non-verbosity, versions are commented after the SHA and updating via dependabot is introduced that will automatically update the commented version tag as well.

In case of a false commit SHA, this change could break the corresponding workflow. Typically, this does not cause major interruptions, but it can for example affect a release pipeline and require restart causing delays.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (386f4e7) to head (77a74f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5193      +/-   ##
==========================================
- Coverage   81.13%   81.03%   -0.11%     
==========================================
  Files         481      476       -5     
  Lines       21489    21341     -148     
==========================================
- Hits        17436    17293     -143     
+ Misses       4053     4048       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xopham xopham marked this pull request as ready for review February 3, 2025 17:21
@xopham xopham requested review from a team as code owners February 3, 2025 17:21
@xopham xopham requested a review from juan-fernandez February 3, 2025 17:21
@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-03 17:25:40

Comparing candidate commit 77a74f0 in PR branch christoph.hamsen/pin-update-gh-actions with baseline commit 386f4e7 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 908 metrics, 24 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-83.186MB; -75.382MB] or [-8.791%; -7.966%]

Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen reasonable enough 👍 I'm approving but please wait until you get approval from other teams as I'm not the only stakeholder of this repo :)

@bengl bengl enabled auto-merge (squash) February 3, 2025 17:39
@bengl bengl merged commit 5d6e698 into master Feb 3, 2025
353 of 354 checks passed
@bengl bengl deleted the christoph.hamsen/pin-update-gh-actions branch February 3, 2025 17:40
@xopham xopham mentioned this pull request Feb 4, 2025
rochdev pushed a commit that referenced this pull request Feb 7, 2025
* Add dependabot for github actions

* Pin all actions by hash
@rochdev rochdev mentioned this pull request Feb 7, 2025
rochdev pushed a commit that referenced this pull request Feb 10, 2025
* Add dependabot for github actions

* Pin all actions by hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants