-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin github actions by hash and update via dependabot #5193
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5193 +/- ##
==========================================
- Coverage 81.13% 81.03% -0.11%
==========================================
Files 481 476 -5
Lines 21489 21341 -148
==========================================
- Hits 17436 17293 -143
+ Misses 4053 4048 -5 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-03 17:25:40 Comparing candidate commit 77a74f0 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 908 metrics, 24 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen reasonable enough 👍 I'm approving but please wait until you get approval from other teams as I'm not the only stakeholder of this repo :)
* Add dependabot for github actions * Pin all actions by hash
* Add dependabot for github actions * Pin all actions by hash
What does this PR do?
Motivation
Pinning 3rd-party GitHub Actions by commit SHA makes them less vulnerable to compromise of the 3rd party. To avoid outdating and non-verbosity, versions are commented after the SHA and updating via dependabot is introduced that will automatically update the commented version tag as well.
In case of a false commit SHA, this change could break the corresponding workflow. Typically, this does not cause major interruptions, but it can for example affect a release pipeline and require restart causing delays.