Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog-plugin-mongoose test remove forgotten skip condition for versions >= 8.10.0 #5238

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Feb 10, 2025

What does this PR do?

mongoose-plugin remove forgotten skip condition for versions >= 8.10.0

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Feb 10, 2025

Overall package size

Self size: 8.63 MB
Deduped: 95.03 MB
No deduping: 95.55 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (ca855f8) to head (ba71de7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5238      +/-   ##
==========================================
- Coverage   81.16%   81.11%   -0.05%     
==========================================
  Files         482      481       -1     
  Lines       21527    21450      -77     
==========================================
- Hits        17473    17400      -73     
+ Misses       4054     4050       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iunanua iunanua changed the title mongoose-plugin remove forgotten skip condition for versions >= 8.10.0 datadog-plugin-mongoose test remove forgotten skip condition for versions >= 8.10.0 Feb 10, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 10, 2025

Datadog Report

Branch report: igor/fix-mongoose-8.10.0-the-final
Commit report: d4e8de6
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 626 Passed, 0 Skipped, 12m 51.65s Total Time

@iunanua iunanua marked this pull request as ready for review February 10, 2025 17:18
@iunanua iunanua requested review from a team as code owners February 10, 2025 17:18
@iunanua iunanua merged commit c64020a into master Feb 11, 2025
354 of 356 checks passed
@iunanua iunanua deleted the igor/fix-mongoose-8.10.0-the-final branch February 11, 2025 08:08
watson pushed a commit that referenced this pull request Feb 17, 2025
…ions >= 8.10.0 (#5238)

* remove skip condition :S

* await disconnect
@watson watson mentioned this pull request Feb 17, 2025
watson pushed a commit that referenced this pull request Feb 17, 2025
…ions >= 8.10.0 (#5238)

* remove skip condition :S

* await disconnect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants