Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): keep the lookup value as passed #5244

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Feb 11, 2025

The previous version was transforming the lookup
parameter to a string.

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

The previous version was transforming the lookup
parameter to a string.

Closes #4894
@tlhunter tlhunter requested a review from a team as a code owner February 11, 2025 19:47
Copy link

Overall package size

Self size: 8.63 MB
Deduped: 95.04 MB
No deduping: 95.56 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.7.1 | 96.67 kB | 96.67 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (b8c03bd) to head (75b36d3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5244      +/-   ##
==========================================
+ Coverage   81.09%   81.17%   +0.08%     
==========================================
  Files         480      482       +2     
  Lines       21438    21530      +92     
==========================================
+ Hits        17386    17478      +92     
  Misses       4052     4052              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: tlhunter/lookup-as-fn-in-config
Commit report: 384552f
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 631 Passed, 0 Skipped, 16m 0.51s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • cypress@latest commonJS flaky test retries retries flaky tests - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     expected +0 to equal 1
    

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-11 19:56:46

Comparing candidate commit 75b36d3 in PR branch tlhunter/lookup-as-fn-in-config with baseline commit b8c03bd in branch master.

Found 1 performance improvements and 3 performance regressions! Performance is the same for 906 metrics, 23 unstable metrics.

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 cpu_user_time [+237.163ms; +246.060ms] or [+5.376%; +5.578%]
  • 🟥 execution_time [+287.707ms; +320.565ms] or [+5.959%; +6.639%]
  • 🟥 max_rss_usage [+92.418MB; +93.510MB] or [+17.512%; +17.719%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-120.562MB; -66.414MB] or [-12.592%; -6.936%]

@tlhunter tlhunter enabled auto-merge (squash) February 12, 2025 16:48
@tlhunter tlhunter merged commit d7a574b into master Feb 12, 2025
357 checks passed
@tlhunter tlhunter deleted the tlhunter/lookup-as-fn-in-config branch February 12, 2025 16:50
watson pushed a commit that referenced this pull request Feb 17, 2025
The previous version was transforming the lookup parameter to a string.

Closes #4894

Co-authored-by: Benoit Lemoine <benoit.lemoine@busbud.com>
@watson watson mentioned this pull request Feb 17, 2025
watson pushed a commit that referenced this pull request Feb 17, 2025
The previous version was transforming the lookup parameter to a string.

Closes #4894

Co-authored-by: Benoit Lemoine <benoit.lemoine@busbud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lookup function throws The "options.lookup" property must be of type function. Received type string in 4.49.0
3 participants