Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd-trace-api: remove runtime tests that should be test time #5246

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Feb 11, 2025

This was previously checking that objects returned by APIs are wrapped. This shouldn't be checked at run time, but at test time in dd-trace-api.

@bengl bengl requested review from a team as code owners February 11, 2025 20:39
Copy link

github-actions bot commented Feb 11, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.24%. Comparing base (872bac8) to head (90e815e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-plugin-dd-trace-api/src/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5246      +/-   ##
==========================================
- Coverage   81.26%   81.24%   -0.03%     
==========================================
  Files         487      487              
  Lines       21706    21703       -3     
==========================================
- Hits        17640    17633       -7     
- Misses       4066     4070       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: bengl/remove-unneeded-dd-trace-api-tests
Commit report: 44462f1
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 629 Passed, 0 Skipped, 15m 22.69s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-12 19:51:39

Comparing candidate commit 90e815e in PR branch bengl/remove-unneeded-dd-trace-api-tests with baseline commit 872bac8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 908 metrics, 25 unstable metrics.

This was previously checking that objects returned by APIs are wrapped.
This shouldn't be checked at run time, but at test time in
dd-trace-api.
@bengl bengl force-pushed the bengl/remove-unneeded-dd-trace-api-tests branch from c387150 to 90e815e Compare February 12, 2025 19:41
@bengl bengl enabled auto-merge (squash) February 12, 2025 19:41
@bengl bengl merged commit 8e8898d into master Feb 12, 2025
358 checks passed
@bengl bengl deleted the bengl/remove-unneeded-dd-trace-api-tests branch February 12, 2025 20:08
watson pushed a commit that referenced this pull request Feb 17, 2025
This was previously checking that objects returned by APIs are wrapped.
This shouldn't be checked at run time, but at test time in
dd-trace-api.
@watson watson mentioned this pull request Feb 17, 2025
watson pushed a commit that referenced this pull request Feb 17, 2025
This was previously checking that objects returned by APIs are wrapped.
This shouldn't be checked at run time, but at test time in
dd-trace-api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants