Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change telemetry name for dd-trace-api #5264

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Feb 13, 2025

This is as per the landed change in dd-go.

This is as per the landed change in dd-go.
@bengl bengl requested review from a team as code owners February 13, 2025 16:09
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (b8c03bd) to head (a94113a).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5264      +/-   ##
==========================================
+ Coverage   81.09%   81.24%   +0.14%     
==========================================
  Files         480      487       +7     
  Lines       21438    21703     +265     
==========================================
+ Hits        17386    17633     +247     
- Misses       4052     4070      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bengl bengl enabled auto-merge (squash) February 13, 2025 16:14
Copy link

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 16:22:27

Comparing candidate commit a94113a in PR branch bengl/change-telemetry-name-for-api with baseline commit b8c03bd in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 904 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 execution_time [+251.870ms; +326.009ms] or [+5.205%; +6.737%]
  • 🟥 max_rss_usage [+85.696MB; +94.044MB] or [+16.218%; +17.798%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-90.172MB; -70.880MB] or [-9.555%; -7.511%]

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: bengl/change-telemetry-name-for-api
Commit report: 1523f90
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 628 Passed, 0 Skipped, 15m 15.24s Total Time

@bengl bengl merged commit ee6423f into master Feb 13, 2025
358 of 359 checks passed
@bengl bengl deleted the bengl/change-telemetry-name-for-api branch February 13, 2025 16:59
watson pushed a commit that referenced this pull request Feb 17, 2025
This is as per the landed change in dd-go.
@watson watson mentioned this pull request Feb 17, 2025
watson pushed a commit that referenced this pull request Feb 17, 2025
This is as per the landed change in dd-go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants