-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test optimization] Fix session fingerprint in playwright #5273
[test optimization] Fix session fingerprint in playwright #5273
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5273 +/- ##
==========================================
- Coverage 81.24% 81.24% -0.01%
==========================================
Files 487 487
Lines 21703 21702 -1
==========================================
- Hits 17633 17632 -1
Misses 4070 4070 ☔ View full report in Codecov by Sentry. |
Overall package sizeSelf size: 8.68 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Datadog ReportBranch report: ✅ 0 Failed, 629 Passed, 0 Skipped, 15m 51.49s Total Time |
BenchmarksBenchmark execution time: 2025-02-14 14:21:54 Comparing candidate commit 1bcb598 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 905 metrics, 27 unstable metrics. scenario:plugin-graphql-with-async-hooks-22
|
What does this PR do?
test.configuration.browser_name
from test events.test.parameter
test.browser.name
Motivation
My initial intention with using
test.configuration.browser_name
was to make tests running in different browsers have a different fingerprint. This is a problem becausetest.configuration.*
is part of the fingerprint both for session and events. Sincetest.configuration.browser_name
is not in the test session event (it wouldn't make sense, as there are multiple used browsers per session), thetest_session.fingerprint
calculated in the backend is different in test and session events. This makes correlating events impossible.By using
test.parameter
we still distinguish fingerprints for different browsers. Also, the browser name can be queried / filtered by usingtest.browser.name
, so user functionality remains.Plugin Checklist
Only manual tests possible, as the fingerprints are calculated in the backend.