-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase GraphQL benchmark stability #5284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5284 +/- ##
==========================================
+ Coverage 80.87% 80.91% +0.04%
==========================================
Files 484 488 +4
Lines 21783 21817 +34
==========================================
+ Hits 17616 17654 +38
+ Misses 4167 4163 -4 ☔ View full report in Codecov by Sentry. |
Overall package sizeSelf size: 8.75 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Datadog ReportBranch report: ✅ 0 Failed, 673 Passed, 0 Skipped, 16m 17.89s Total Time |
This is done to try and increase stability of the benchmark as the numbers collected currently fluctuate a lot.
4a848a8
to
6ca4809
Compare
BenchmarksBenchmark execution time: 2025-02-18 14:29:16 Comparing candidate commit e4b24ef in PR branch Found 68 performance improvements and 0 performance regressions! Performance is the same for 848 metrics, 17 unstable metrics. scenario:plugin-graphql-control-18
scenario:plugin-graphql-control-20
scenario:plugin-graphql-control-22
scenario:plugin-graphql-with-async-hooks-18
scenario:plugin-graphql-with-async-hooks-20
scenario:plugin-graphql-with-async-hooks-22
scenario:plugin-graphql-with-depth-and-collapse-off-18
scenario:plugin-graphql-with-depth-and-collapse-off-20
scenario:plugin-graphql-with-depth-and-collapse-off-22
scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-and-collapse-on-20
scenario:plugin-graphql-with-depth-and-collapse-on-22
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-off-20
scenario:plugin-graphql-with-depth-off-22
scenario:plugin-graphql-with-depth-on-max-18
scenario:plugin-graphql-with-depth-on-max-20
scenario:plugin-graphql-with-depth-on-max-22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks way better in BP UI.
What does this PR do?
Motivation
This is done to try and increase stability of the benchmark as the numbers collected currently fluctuate a lot, which results in a lot of warnings on PRs saying that the performance of the GraphQL instrumentation has either significantly improved or gotten worse, even though the PR shouldn't affect it.
Plugin Checklist
Additional Notes