Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new baggage APIs which act on currently active baggage #5365

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ida613
Copy link
Collaborator

@ida613 ida613 commented Mar 5, 2025

What does this PR do?

Provides users with a set of global functions which act on the currently active baggage of implicitly propagated context

Motivation

From the baggage RFC:

Generally speaking, the Baggage API should be exposed on the Context object or class on APM SDKs where the context itself is exposed. On SDKs where context is implicit, the Baggage API can be exposed through static/global functions that act on the currently active baggage.

Added return statements because

If any language implements baggage as an immutable object or data structure (as defined in the OpenTelemetry Baggage API specification), the functions above that modify baggage (set and remove) will need to return the new (modified) baggage object. However, if baggage is mutable and modified in place, those functions don't need to return a value.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Mar 5, 2025

Overall package size

Self size: 8.97 MB
Deduped: 101.5 MB
No deduping: 102.02 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (28eaa41) to head (980689b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5365      +/-   ##
==========================================
+ Coverage   79.47%   79.48%   +0.01%     
==========================================
  Files         509      510       +1     
  Lines       22811    22823      +12     
==========================================
+ Hits        18128    18140      +12     
  Misses       4683     4683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: ida613/global-baggage
Commit report: a451a06
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 805 Passed, 0 Skipped, 16m 42.9s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 17, 2025

Benchmarks

Benchmark execution time: 2025-03-18 14:08:58

Comparing candidate commit 980689b in PR branch ida613/global-baggage with baseline commit 28eaa41 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

@ida613 ida613 changed the title WIP: add new baggage APIs which act on currently active baggage add new baggage APIs which act on currently active baggage Mar 17, 2025
@ida613 ida613 marked this pull request as ready for review March 17, 2025 21:17
@ida613 ida613 requested a review from a team as a code owner March 17, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant