CI: Run spec files in datadog-instrumentations sub-dirs #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Overall package sizeSelf size: 8.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5417 +/- ##
==========================================
- Coverage 80.70% 80.63% -0.07%
==========================================
Files 493 495 +2
Lines 22125 22159 +34
==========================================
+ Hits 17857 17869 +12
- Misses 4268 4290 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 803 Passed, 0 Skipped, 15m 53.67s Total Time |
BenchmarksBenchmark execution time: 2025-03-14 14:46:43 Comparing candidate commit 49bbd29 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 918 metrics, 15 unstable metrics. |
watson
force-pushed
the
watson/fix-instrumentations-ci
branch
6 times, most recently
from
bbb9299 to
ae3e109
Compare
Ensure that `*.spec.js` files inside of sub-directories of the `packages/datadog-instrumentations/test` folder are also run in CI. Today, there's a `helpers` directory, which currently contains a single spec file. Since this spec file isn't run during CI, it's been silently broken since 2022. Therefore, this commit also updates the spec file to work, by: - Fixing references to missing variables - Changing it from tap to mocha, as this is the style of the other spec files in the package
watson
force-pushed
the
watson/fix-instrumentations-ci
branch
from
ae3e109 to
49bbd29
Compare
rochdev
approved these changes
Mar 14, 2025
|
I think the failing GitLab tests are due to issues with GitLab. I've been able to restart them. In any case, they are completely unrelated to the changes in how we run the test with GitHub Actions, so I'll go ahead and merge regardless. |
Merged
rochdev
pushed a commit
that referenced
this pull request
Mar 14, 2025
Ensure that `*.spec.js` files inside of sub-directories of the `packages/datadog-instrumentations/test` folder are also run in CI. Today, there's a `helpers` directory, which currently contains a single spec file. Since this spec file isn't run during CI, it's been silently broken since 2022. Therefore, this commit also updates the spec file to work, by: - Fixing references to missing variables - Changing it from tap to mocha, as this is the style of the other spec files in the package
rochdev
pushed a commit
that referenced
this pull request
Mar 14, 2025
Ensure that `*.spec.js` files inside of sub-directories of the `packages/datadog-instrumentations/test` folder are also run in CI. Today, there's a `helpers` directory, which currently contains a single spec file. Since this spec file isn't run during CI, it's been silently broken since 2022. Therefore, this commit also updates the spec file to work, by: - Fixing references to missing variables - Changing it from tap to mocha, as this is the style of the other spec files in the package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
*.spec.jsfiles inside of sub-directories of thepackages/datadog-instrumentations/testfolder are also run in CI.Today, there's a
helpersdirectory, which currently contains a single spec file. Since this spec file isn't run during CI, it's been silently broken since 2022. Therefore, this commit also updates the spec file to work, by: