Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Fix playwright e2e tests flakiness #5438

Merged
merged 2 commits into from
Mar 19, 2025
Merged

[test optimization] Fix playwright e2e tests flakiness #5438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c296b1
increase timeout installation
juan-fernandez Mar 19, 2025
028628c
improvements
juan-fernandez Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions integration-tests/playwright/playwright.spec.js
View file
Original file line number Diff line number Diff line change
@@ -47,12 +47,14 @@ versions.forEach((version) => {
let sandbox, cwd, receiver, childProcess, webAppPort

before(async function () {
// bump from 30 to 60 seconds because playwright dependencies are heavy
this.timeout(60000)
// bump from 60 to 90 seconds because we also need to install dependencies and download chromium
this.timeout(90000)
sandbox = await createSandbox([`@playwright/test@${version}`, 'typescript'], true)
cwd = sandbox.folder
// install necessary browser
const { NODE_OPTIONS, ...restOfEnv } = process.env
// Install system dependencies
execSync('npx playwright install-deps', { cwd, env: restOfEnv })
// Install chromium (configured in integration-tests/playwright.config.js)
execSync('npx playwright install', { cwd, env: restOfEnv })
webAppPort = await getPort()
webAppServer.listen(webAppPort)
Loading