-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-3568 DRY transport options, remove HTTP.new method #4469
Open
p-datadog
wants to merge
13
commits into
master
Choose a base branch
from
transport-options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 20624 Passed, 1373 Skipped, 3m 17.49s Total Time |
b28262f
to
0097941
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4469 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 1379 1380 +1
Lines 83881 83813 -68
Branches 4251 4226 -25
=======================================
- Hits 81953 81888 -65
+ Misses 1928 1925 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduces duplication of existing transport code by removing the HTTP.new method which was identical for all transports and removing the code that copied agent settings into transport options.
Transport options are now explicitly enumerated (they are
api_version
andheaders
) instead of being a hash. This will make code that passed invalid or unknown options fail instead of silently doing nothing.Motivation:
Preparation for chunking of dynamic instrumentation event submissions
Change log entry
None
Additional Notes:
This PR should not contain any API changes. The
options
style arguments have been replaced with explicit keyword arguments in some methods but the set of arguments accepted remains the same as before.How to test the change?
Existing unit tests