Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY transport exceptions #4484

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

DRY transport exceptions #4484

wants to merge 6 commits into from

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Mar 12, 2025

What does this PR do?

Moves the "endpoint not supported" and "endpoint not defined" exceptions into the core.

Motivation:
Currently these exceptions are defined for each endpoint but their contents is identical.

Change log entry
None

Additional Notes:

How to test the change?
Existing unit tests

Copy link

github-actions bot commented Mar 12, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-03-12 14:14:55 UTC

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Mar 12, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 12, 2025

Datadog Report

Branch report: transport-dry-4
Commit report: 6104c35
Test service: dd-trace-rb

✅ 0 Failed, 20626 Passed, 1373 Skipped, 3m 16.34s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025

Benchmarks

Benchmark execution time: 2025-03-12 14:36:03

Comparing candidate commit 6104c35 in PR branch transport-dry-4 with baseline commit 65b2901 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.70%. Comparing base (65b2901) to head (6104c35).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/core/remote/transport/http/config.rb 66.66% 1 Missing ⚠️
.../datadog/core/remote/transport/http/negotiation.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4484   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files        1379     1381    +2     
  Lines       83881    83903   +22     
  Branches     4251     4256    +5     
=======================================
+ Hits        81953    81980   +27     
+ Misses       1928     1923    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog marked this pull request as ready for review March 12, 2025 14:14
@p-datadog p-datadog requested review from a team as code owners March 12, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants