Add cilium helm and kind cluster installation #1444
Conversation
components/kubernetes/kind.go
Outdated
| func init() { | ||
| var err error | ||
| kindCiliumClusterTemplate, err = template.ParseFS(kindCilumClusterFS, "kind-cilium-cluster.yaml") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a real advantage to put it there instead of in NewCiliumKindCluster function. So that it is not executed when not useful.
There was a problem hiding this comment.
Moved to NewCiliumKindCluster
| return false | ||
| } | ||
|
|
||
| func NewHelmInstallation(e config.Env, params *Params, opts ...pulumi.ResourceOption) (*HelmComponent, error) { |
There was a problem hiding this comment.
I think it can make sense that NewHelmInstallation take a kubernetes cluster as an argument, because it needs information about the cluster to work properly
func NewHelmInstallation(e config.Env, cluster *componentskube.Cluster, params *Params, opts ...pulumi.ResourceOption)
That way it is explicit that you need to give the cluster for it to work. And you can have that: https://github.com/DataDog/datadog-agent/pull/34398/files#diff-9dbae0537bf500d77990a2ef3697b49f572cd967cca5f890c84058eea75885b6R133-R134 in this function.
There was a problem hiding this comment.
Added the parameter
hmahmood
force-pushed
the
hasan.mahmood/add-cilium
branch
from
22aa96d to
c9a011b
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The median merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
What does this PR do?
Adds a new variant to a remote kind cluster that supports cilium. There is also a new helm installation component for cilium added.
Which scenarios this will impact?
Motivation
Additional Notes