Prevent panic when decompression input slice is empty #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viq111
reviewed
Aug 6, 2018
There was a problem hiding this comment.
Hi @folbricht,
Thanks a lot for contributing!
Your PR looks good, I would just suggest adding a test to ensure now (& in the future) that we have the corret behavior.
Mind adding a test for Decompress on empty silce ? (should be the same as
Line 87 in 8bc925a
|
Not a problem, test added. Thanks |
Viq111
approved these changes
Aug 6, 2018
Viq111
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns an error instead of an
index out of rangepanic when the src slice to Decompress() is empty. The function uses&src[0]without first confirming the length.