PiMixin: Enable support for ignoring provided forecast dates #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflows: add work flow based on the gitlab ci workflow
Use the correct workflow status badge in the README.md.
Provide some information on the migration from gitlab to github and how to update the git remote url.
Update readme
Update the autogenereted versioneer.py and _version.py files with the latest versioneer package. This makes versioneer compatible with python 3.12.
Remove the upper limit on numpy and scipy versions. The older versions are no longer compatible with python 3.12.
Fix string-to-datetime/float conversions in loading csv files for latest numpy version. With the latest numpy.genfromtxt, strings are not always passed to converters in byte format but sometimes in plain text format.
Fix the except clause when model transferring a model failed due to an incompatible cache file. Raise the error only when no cache file was used.
Use -999 instead of nan when missing values are indicated by -999.
Include tests using python 3.12.
Move the cross reference just above the section name, instead of in the middle of the section. Sphinx expects references to be just above sections/figures/tables.
Update install instructions for Python 3.12. Installing rtc-tools with Python 3.12 requires installation of setuptools.
Use np.genfromtxt instead of np.recfromcsv, since the latter is deprecated.
Remove the deprecated function get_html_theme_path.
Upgrade for python 3 12
Remove gitlab CI/CD yaml file, since the repository has moved to github.
Replace gitlab references with github references where applicable.
Replace gitlab with github reference for downloading examples.
fix: Typo in examples
Remove gitlab references
An exception is raised if forecast dates were provided and they are not all equal. This option allows users to ignore provided forecast dates.
There was a problem hiding this comment.
This option is basically equivalent to preprocessing xml files by removing all forecast_date elements. I would suggest to rename the option as ignore_forecast_date.
My main concern is if this is the correct place to apply preprocessing on xml files. Unfortunately, I don't know if there are alternative ways to achieve this through fews, fews-io, or some other library.
| @@ -44,6 +44,9 @@ class PIMixin(IOMixin): | |||
| #: Check consistency of timeseries | |||
| pi_validate_timeseries = True | |||
|
|
|||
| #: Read forecast date from timeseries_import | |||
| pi_read_forecast_date = True | |||
There was a problem hiding this comment.
I would also describe this var in the class docstring.
| @@ -101,6 +105,7 @@ def read(self): | |||
| self.timeseries_export_basename, | |||
| binary=self.pi_binary_timeseries, | |||
| pi_validate_times=False, | |||
| pi_read_forecast_date=True, | |||
There was a problem hiding this comment.
Shouldn't we use self.pi_read_forecast_date here as well?
| @@ -41,6 +41,9 @@ class PIMixin(IOMixin): | |||
| #: Check consistency of timeseries | |||
| pi_validate_timeseries = True | |||
|
|
|||
| #: Read forecast date from timeseries_import | |||
| pi_read_forecast_date = True | |||
There was a problem hiding this comment.
Please describe this var in the class docstring.
| @@ -103,6 +107,7 @@ def read(self): | |||
| self.timeseries_export_basename, | |||
| binary=self.pi_binary_timeseries, | |||
| pi_validate_times=False, | |||
| pi_read_forecast_date=True, | |||
There was a problem hiding this comment.
Shouldn't we use here self.pi_read_forecast_date as well?
|
Hi @jackvreeken Could you please review this PR? |
SGeeversAtVortech
force-pushed
the
master
branch
from
03367be to
240ff5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception is raised if forecast dates were provided and they are not all equal. This option allows users to ignore provided forecast dates.