Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE during NVD mirroring via REST API when encountering invalid CPEs #4732

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Fix NPE during NVD mirroring via REST API when encountering invalid CPEs #4732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/dependencytrack/parser/nvd/api20/ModelConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ public static List<VulnerableSoftware> convertConfigurations(final String cveId,
final List<CpeMatch> cpeMatches = extractCpeMatches(cveId, configurations);
return cpeMatches.stream()
.map(cpeMatch -> convertCpeMatch(cveId, cpeMatch))
.filter(Objects::nonNull)
.filter(distinctIgnoringDatastoreIdentity())
.collect(Collectors.toList());
}
Expand Down Expand Up @@ -283,10 +284,10 @@ private static VulnerableSoftware convertCpeMatch(final String cveId, final CpeM

return vs;
} catch (CpeParsingException e) {
LOGGER.warn("Failed to parse CPE %s of %s; Skipping".formatted(cpeMatch.getCriteria(), cveId));
LOGGER.warn("Failed to parse CPE %s of %s; Skipping".formatted(cpeMatch.getCriteria(), cveId), e);
return null;
} catch (CpeEncodingException e) {
LOGGER.warn("Failed to encode CPE %s of %s; Skipping".formatted(cpeMatch.getCriteria(), cveId));
LOGGER.warn("Failed to encode CPE %s of %s; Skipping".formatted(cpeMatch.getCriteria(), cveId), e);
return null;
}
}
Expand Down
Loading