Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification limiting to tags not working reliably #4733

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Mar 8, 2025

Description

Fixes notification limiting to tags not working reliably.

The code assumed inspected projects to be in persistent state, which they were in unit tests, but not at application runtime.

Notification subjects are always in detached state. NotificationRouterTest was updated to reflect this fact.

Addressed Issue

Fixes #4661

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

The code assumed inspected projects to be in persistent state, which they were in unit tests, but not at application runtime.

Notification subjects are always in detached state. `NotificationRouterTest` was updated to reflect this fact.

Fixes DependencyTrack#4661

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added defect Something isn't working backport/4.12.7 PRs to be backported to version 4.12.7 labels Mar 8, 2025
@nscuro nscuro added this to the 4.13 milestone Mar 8, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 90.91% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (49ad681) 23248 18668 80.30%
Head commit (95dc57f) 23261 (+13) 18679 (+11) 80.30% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4733) 22 20 90.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit d1573ed into DependencyTrack:master Mar 9, 2025
11 checks passed
@nscuro nscuro deleted the issue-4661 branch March 9, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.7 PRs to be backported to version 4.12.7 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No notifications of group NEW_VULNERABILITY were published when the alert is limit to tags
1 participant