WinSCard: refactoring and fixes #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBestTvarynka
commented
Feb 1, 2024
TheBestTvarynka
added a commit
that referenced
this pull request
Feb 13, 2024
TheBestTvarynka
added a commit
that referenced
this pull request
Feb 14, 2024
CBenoit
pushed a commit
that referenced
this pull request
Feb 15, 2024
CBenoit
pushed a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request contains fixes to all the issues I faced during the debugging. Also, I refactored the code. So, now the
winscardcrate is fully ready.These fixes contain a lot of tricky code. So I added comments to clarify this.
Also, I renamed the crate as you asked in my previous PR.
Docs & references:
winscard.h.