Correct is_object typo.
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like there was a typo that made it so a IValue would be checked for its numerical-ness before being transformed into an object. This switches it to check for its object-ness.
|
Thanks, could you add a regression test? |
Add in a test case to confirm that `into_object` works for IValues that are objects.
|
Sure! I've added a test in |
|
Perfect, thanks 👍 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 48.65% 48.82% +0.16%
==========================================
Files 10 10
Lines 3007 3009 +2
==========================================
+ Hits 1463 1469 +6
+ Misses 1544 1540 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was a typo that made it so a IValue would be checked for its numerical-ness before being transformed into an object. This switches it to check for its object-ness. Addresses #21