Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MechanicAcceptance page in manager. #202

Merged
merged 14 commits into from
Oct 20, 2024

Conversation

diyorzz
Copy link
Contributor

@diyorzz diyorzz commented Oct 13, 2024

Before:
Screenshot 2024-10-13 150112
After:
image

@Boburm1rzo
Copy link
Contributor

Do we need a "Mexanik (Qabul qiluvchi)" header?
I think removing this is a good option

@diyorzz
Copy link
Contributor Author

diyorzz commented Oct 13, 2024

Do we need a "Mexanik (Qabul qiluvchi)" header? I think removing this is a good option

"Yes, this is what we need, because we have written all the pages, and the information on the sidebar may not be enough, as older adults work there."

Copy link
Contributor

@Boburm1rzo Boburm1rzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jamshidbek-choriyev
Copy link
Contributor

Do we need to display data from all columns in the list? For example, "Acceptance distance" and "Remaining fuel".

@jamshidbek-choriyev
Copy link
Contributor

I think it would be better if you set the data in the "qabul qilish" column to be the same as the "status" column. That is, giving colors.

@diyorzz
Copy link
Contributor Author

diyorzz commented Oct 15, 2024

Do we need to display data from all columns in the list? For example, "Acceptance distance" and "Remaining fuel".

No, we don't need to display data from all columns in the list. We can choose specific columns that are relevant or necessary for the current context.
For example : "Mexanik F.I.SH" , "Haydovchi F.I.SH" , "Mashina" , "Ro'yxatdan o'tgan vaqt" and "Status".

@diyorzz
Copy link
Contributor Author

diyorzz commented Oct 15, 2024

I think it would be better if you set the data in the "qabul qilish" column to be the same as the "status" column. That is, giving colors.

Now, I don't need to add color to "Qabul qilish" column because we won't display it on the index. we display on details page.

@diyorzz diyorzz self-assigned this Oct 15, 2024
@jamshidbek-choriyev
Copy link
Contributor

I think it would be better if you set the data in the "qabul qilish" column to be the same as the "status" column. That is, giving colors.

Now, I don't need to add color to "Qabul qilish" column because we won't display it on the index. we display on details page.

Good great

Copy link

@FirdavsAX FirdavsAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pull request need code review , is this branch merged

Copy link
Contributor

@Ramadan1011 Ramadan1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@diyorzz diyorzz merged commit 939c028 into integration Oct 20, 2024
@Ramadan1011 Ramadan1011 deleted the Update-MechanicAcceptance-page-in-manager- branch December 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants